Page MenuHomePhabricator
Feed All Stories

All Stories
Use Results
Edit Query

Today

PiRK updated the diff for D19040: introduce CharNotInt8 and BasicByte C++20 concepts.

rebase on master with D19045, see if clang builds pass now

Thu, Dec 4, 12:09
PiRK updated the diff for D19034: crypto: refactor ChaCha20 classes to use Span<std::byte> interface.

fix 3 comments as suggested

Thu, Dec 4, 12:07
PiRK closed D19045: addrman: tidy up unit tests.
Thu, Dec 4, 12:05
PiRK committed rABC17c06149ddd9: addrman: tidy up unit tests (authored by John Newbery <john@johnnewbery.com>).
addrman: tidy up unit tests
Thu, Dec 4, 12:05
Fabien accepted D19045: addrman: tidy up unit tests.
Thu, Dec 4, 11:48
Fabien requested changes to D19034: crypto: refactor ChaCha20 classes to use Span<std::byte> interface.
Thu, Dec 4, 11:47
PiRK added inline comments to D19045: addrman: tidy up unit tests.
Thu, Dec 4, 10:45
PiRK updated the summary of D19045: addrman: tidy up unit tests.
Thu, Dec 4, 10:44
teamcity updated the summary of D19045: addrman: tidy up unit tests.
Thu, Dec 4, 10:43
PiRK requested review of D19045: addrman: tidy up unit tests.
Thu, Dec 4, 10:43
PiRK updated the diff for D19034: crypto: refactor ChaCha20 classes to use Span<std::byte> interface.

add another comment about the same in SetKey

Thu, Dec 4, 10:13
PiRK updated the diff for D19034: crypto: refactor ChaCha20 classes to use Span<std::byte> interface.

add a TODO comment regarding compile time enforcement of KEYLEN

Thu, Dec 4, 10:10
PiRK requested review of D19034: crypto: refactor ChaCha20 classes to use Span<std::byte> interface.

We can probably do that after we switch from Span to std::span. The Span template does not have the Extent parameter

Thu, Dec 4, 10:05
Fabien accepted D19039: crypto: make ChaCha20::SetKey wipe buffer.
Thu, Dec 4, 08:39
Fabien accepted D19038: tests: miscellaneous hex / std::byte improvements.
Thu, Dec 4, 08:38
Fabien accepted D19037: fuzz: support std::byte in Consume{Fixed,Variable}LengthByteVector.
Thu, Dec 4, 08:35
Fabien accepted D19036: crypto: require key on ChaCha20 initialization.
Thu, Dec 4, 08:35
Fabien accepted D19035: random: simplify FastRandomContext::randbytes using fillrand.
Thu, Dec 4, 08:32
Fabien requested changes to D19034: crypto: refactor ChaCha20 classes to use Span<std::byte> interface.

More a question than requesting change

Thu, Dec 4, 08:31

Yesterday

johnkuney committed rABCcdff4f1d69cc: [e.cash] Add video to about page (authored by johnkuney).
[e.cash] Add video to about page
Wed, Dec 3, 17:41
johnkuney closed D19033: [e.cash] Add video to about page.
Wed, Dec 3, 17:41
teamcity added a comment to D19044: random: use BasicByte concept in randbytes.
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.
Wed, Dec 3, 16:42
teamcity added a comment to D19043: random: add a few noexcepts to FastRandomContext.
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.
Wed, Dec 3, 16:38
teamcity added a comment to D19044: random: use BasicByte concept in randbytes.
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.
Wed, Dec 3, 16:33
teamcity added a comment to D19042: random: move rand256() and randbytes() to .h file.
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.
Wed, Dec 3, 16:27
PiRK added a comment to D19040: introduce CharNotInt8 and BasicByte C++20 concepts.
In D19040#433674, @PiRK wrote:

should have checked clang before submitting

Wed, Dec 3, 16:27
teamcity added a comment to D19043: random: add a few noexcepts to FastRandomContext.
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.
Wed, Dec 3, 16:26
teamcity added a comment to D19041: random: write rand256() and rand160() in function of fillrand().
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.
Wed, Dec 3, 16:23
teamcity added a comment to D19042: random: move rand256() and randbytes() to .h file.
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.
Wed, Dec 3, 16:17
PiRK planned changes to D19044: random: use BasicByte concept in randbytes.
Wed, Dec 3, 16:15
PiRK planned changes to D19043: random: add a few noexcepts to FastRandomContext.
Wed, Dec 3, 16:15
PiRK planned changes to D19042: random: move rand256() and randbytes() to .h file.
Wed, Dec 3, 16:14
PiRK planned changes to D19041: random: write rand256() and rand160() in function of fillrand().
Wed, Dec 3, 16:14
PiRK planned changes to D19040: introduce CharNotInt8 and BasicByte C++20 concepts.

should have checked clang before submitting

Wed, Dec 3, 16:14
teamcity added a comment to D19040: introduce CharNotInt8 and BasicByte C++20 concepts.
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.
Wed, Dec 3, 16:12
teamcity added a comment to D19041: random: write rand256() and rand160() in function of fillrand().
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.
Wed, Dec 3, 16:10
teamcity updated the summary of D19044: random: use BasicByte concept in randbytes.
Wed, Dec 3, 16:09
PiRK requested review of D19044: random: use BasicByte concept in randbytes.
Wed, Dec 3, 16:09
teamcity updated the summary of D19043: random: add a few noexcepts to FastRandomContext.
Wed, Dec 3, 16:08
PiRK requested review of D19043: random: add a few noexcepts to FastRandomContext.
Wed, Dec 3, 16:08
teamcity updated the summary of D19042: random: move rand256() and randbytes() to .h file.
Wed, Dec 3, 16:07
PiRK requested review of D19042: random: move rand256() and randbytes() to .h file.
Wed, Dec 3, 16:07
teamcity updated the summary of D19041: random: write rand256() and rand160() in function of fillrand().
Wed, Dec 3, 16:06
PiRK requested review of D19041: random: write rand256() and rand160() in function of fillrand().
Wed, Dec 3, 16:06
teamcity added a comment to D19040: introduce CharNotInt8 and BasicByte C++20 concepts.
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.
Wed, Dec 3, 16:04
PiRK updated the summary of D19040: introduce CharNotInt8 and BasicByte C++20 concepts.
Wed, Dec 3, 16:00
teamcity updated the summary of D19040: introduce CharNotInt8 and BasicByte C++20 concepts.
Wed, Dec 3, 15:56
PiRK requested review of D19040: introduce CharNotInt8 and BasicByte C++20 concepts.
Wed, Dec 3, 15:56
teamcity updated the summary of D19039: crypto: make ChaCha20::SetKey wipe buffer.
Wed, Dec 3, 14:20
PiRK requested review of D19039: crypto: make ChaCha20::SetKey wipe buffer.
Wed, Dec 3, 14:20
teamcity updated the summary of D19038: tests: miscellaneous hex / std::byte improvements.
Wed, Dec 3, 14:19
PiRK requested review of D19038: tests: miscellaneous hex / std::byte improvements.
Wed, Dec 3, 14:19
teamcity updated the summary of D19037: fuzz: support std::byte in Consume{Fixed,Variable}LengthByteVector.
Wed, Dec 3, 14:19
PiRK requested review of D19037: fuzz: support std::byte in Consume{Fixed,Variable}LengthByteVector.
Wed, Dec 3, 14:19
teamcity updated the summary of D19036: crypto: require key on ChaCha20 initialization.
Wed, Dec 3, 14:17
PiRK requested review of D19036: crypto: require key on ChaCha20 initialization.
Wed, Dec 3, 14:17
teamcity updated the summary of D19035: random: simplify FastRandomContext::randbytes using fillrand.
Wed, Dec 3, 14:16
PiRK requested review of D19035: random: simplify FastRandomContext::randbytes using fillrand.
Wed, Dec 3, 14:16
teamcity updated the summary of D19034: crypto: refactor ChaCha20 classes to use Span<std::byte> interface.
Wed, Dec 3, 14:13
PiRK requested review of D19034: crypto: refactor ChaCha20 classes to use Span<std::byte> interface.
Wed, Dec 3, 14:13
PiRK closed D19022: crypto: support split plaintext in ChaCha20Poly1305 Encrypt/Decrypt.
Wed, Dec 3, 12:21
PiRK closed D19021: bench: add benchmark for FSChaCha20Poly1305.
Wed, Dec 3, 12:21
PiRK committed rABC69375ba14d16: bench: add benchmark for FSChaCha20Poly1305 (authored by Pieter Wuille <pieter@wuille.net>).
bench: add benchmark for FSChaCha20Poly1305
Wed, Dec 3, 12:21
PiRK committed rABC02005029af2f: crypto: support split plaintext in ChaCha20Poly1305 Encrypt/Decrypt (authored by Pieter Wuille <pieter@wuille.net>).
crypto: support split plaintext in ChaCha20Poly1305 Encrypt/Decrypt
Wed, Dec 3, 12:21
PiRK closed D19020: crypto: add FSChaCha20Poly1305, rekeying wrapper around ChaCha20Poly1305.
Wed, Dec 3, 12:21
PiRK closed D19019: crypto: add FSChaCha20, a rekeying wrapper around ChaCha20.
Wed, Dec 3, 12:21
PiRK committed rABCbe0a2db1ebe5: crypto: add the ChaCha20Poly1305 AEAD as specified in RFC8439 (authored by Pieter Wuille <pieter@wuille.net>).
crypto: add the ChaCha20Poly1305 AEAD as specified in RFC8439
Wed, Dec 3, 12:21
PiRK committed rABC82a77c13ec76: crypto: add FSChaCha20, a rekeying wrapper around ChaCha20 (authored by Pieter Wuille <pieter@wuille.net>).
crypto: add FSChaCha20, a rekeying wrapper around ChaCha20
Wed, Dec 3, 12:21
PiRK committed rABC588797934f6b: crypto: add FSChaCha20Poly1305, rekeying wrapper around ChaCha20Poly1305 (authored by Pieter Wuille <pieter@wuille.net>).
crypto: add FSChaCha20Poly1305, rekeying wrapper around ChaCha20Poly1305
Wed, Dec 3, 12:21
PiRK closed D19018: crypto: add the ChaCha20Poly1305 AEAD as specified in RFC8439.
Wed, Dec 3, 12:21
PiRK closed D19017: crypto: remove outdated variant of ChaCha20Poly1305 AEAD.
Wed, Dec 3, 12:20
PiRK committed rABC2c7236d682f0: Switch all callers from poly1305_auth to Poly1305 class (authored by Pieter Wuille <pieter@wuille.net>).
Switch all callers from poly1305_auth to Poly1305 class
Wed, Dec 3, 12:20
PiRK committed rABC090592f0cc19: crypto: remove outdated variant of ChaCha20Poly1305 AEAD (authored by Pieter Wuille <pieter@wuille.net>).
crypto: remove outdated variant of ChaCha20Poly1305 AEAD
Wed, Dec 3, 12:20
PiRK closed D19016: Switch all callers from poly1305_auth to Poly1305 class.
Wed, Dec 3, 12:20
PiRK closed D19015: Make poly1305 support incremental computation + modernize.
Wed, Dec 3, 12:20
PiRK committed rABCa7d0eef1aa10: Make poly1305 support incremental computation + modernize (authored by Pieter Wuille <pieter@wuille.net>).
Make poly1305 support incremental computation + modernize
Wed, Dec 3, 12:20
PiRK updated the summary of D19015: Make poly1305 support incremental computation + modernize.
Wed, Dec 3, 12:01
PiRK closed D19032: Allow std::byte serialization.
Wed, Dec 3, 12:00
PiRK committed rABC6d2396b14b92: Allow std::byte serialization (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>).
Allow std::byte serialization
Wed, Dec 3, 12:00
PiRK closed D19031: Allow FastRandomContext::randbytes for all byte types.
Wed, Dec 3, 12:00
PiRK committed rABC32cfbe0e0fdd: Use only Span{} constructor for byte-like types where possible (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>).
Use only Span{} constructor for byte-like types where possible
Wed, Dec 3, 12:00
PiRK committed rABC992f1accb751: Allow FastRandomContext::randbytes for all byte types (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>).
Allow FastRandomContext::randbytes for all byte types
Wed, Dec 3, 12:00
PiRK closed D19030: Use only Span{} constructor for byte-like types where possible.
Wed, Dec 3, 12:00
PiRK committed rABC57b5db459e01: util: Allow std::byte and char Span serialization (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>).
util: Allow std::byte and char Span serialization
Wed, Dec 3, 11:59
PiRK closed D19029: util: Allow std::byte and char Span serialization.
Wed, Dec 3, 11:59
Fabien accepted D19032: Allow std::byte serialization.
Wed, Dec 3, 10:10
Fabien accepted D19031: Allow FastRandomContext::randbytes for all byte types.
Wed, Dec 3, 10:09
Fabien accepted D19016: Switch all callers from poly1305_auth to Poly1305 class.
Wed, Dec 3, 10:09
Fabien accepted D19018: crypto: add the ChaCha20Poly1305 AEAD as specified in RFC8439.
Wed, Dec 3, 10:08
PiRK updated the diff for D19022: crypto: support split plaintext in ChaCha20Poly1305 Encrypt/Decrypt.

rebase so we can check i correctly handled the conflict

Wed, Dec 3, 10:00
PiRK updated the diff for D19018: crypto: add the ChaCha20Poly1305 AEAD as specified in RFC8439.

squash https://github.com/bitcoin/bitcoin/pull/29815/commits/2d1819455cb4c516f6cdf81c11e869a23dee3e6b

Wed, Dec 3, 09:58
PiRK added inline comments to D19018: crypto: add the ChaCha20Poly1305 AEAD as specified in RFC8439.
Wed, Dec 3, 09:37
Fabien accepted D19030: Use only Span{} constructor for byte-like types where possible.
Wed, Dec 3, 09:07
Fabien accepted D19029: util: Allow std::byte and char Span serialization.
Wed, Dec 3, 09:06
Fabien accepted D19022: crypto: support split plaintext in ChaCha20Poly1305 Encrypt/Decrypt.
Wed, Dec 3, 09:04
Fabien accepted D19021: bench: add benchmark for FSChaCha20Poly1305.
Wed, Dec 3, 09:01
Fabien accepted D19020: crypto: add FSChaCha20Poly1305, rekeying wrapper around ChaCha20Poly1305.
Wed, Dec 3, 09:01
Fabien accepted D19019: crypto: add FSChaCha20, a rekeying wrapper around ChaCha20.
Wed, Dec 3, 08:59
Fabien requested changes to D19018: crypto: add the ChaCha20Poly1305 AEAD as specified in RFC8439.
Wed, Dec 3, 08:48
PiRK updated the diff for D19016: Switch all callers from poly1305_auth to Poly1305 class.

rebase

Wed, Dec 3, 08:48
First
Prev
Next