Page MenuHomePhabricator

Fabien (Fabien)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Oct 7 2018, 09:05 (344 w, 4 d)
Roles
Administrator
Slack Username
Fabien

Recent Activity

Today

Fabien updated the diff for D18087: [chronik] Add the blockchain.scripthash.subscribe endpoint.

Rebase

Fri, May 16, 07:25

Yesterday

Fabien requested changes to D18099: [assumeutxo] add release notes.

I think we should add a note about chronik being incompatible also

Thu, May 15, 21:02
Fabien accepted D18098: Bump version to 0.31.5.
Thu, May 15, 20:59
Fabien requested changes to D18093: [assumeutxo] add mainnet and testnet UTXO snapshot checkpoints.
Thu, May 15, 20:59
Fabien updated the diff for D18087: [chronik] Add the blockchain.scripthash.subscribe endpoint.

Don't send several notifications for the same status, fix status computation and endianness, fix comment

Thu, May 15, 20:54
Fabien closed D18097: [chronik] Electrum: handle multiple messages in a single packet in the test framework.
Thu, May 15, 20:19
Fabien committed rABC46f7816d9a73: [chronik] Electrum: handle multiple messages in a single packet in the test… (authored by Fabien).
[chronik] Electrum: handle multiple messages in a single packet in the test…
Thu, May 15, 20:19
Fabien closed D18092: [chronik] Add the blockchain.headers.unsubscribe endpoint.
Thu, May 15, 20:19
Fabien committed rABCb439dfc45f3f: [chronik] Add the blockchain.headers.unsubscribe endpoint (authored by Fabien).
[chronik] Add the blockchain.headers.unsubscribe endpoint
Thu, May 15, 20:19
Fabien closed D18096: Add checkoints after the May 2025 network upgrade.
Thu, May 15, 18:19
Fabien committed rABC5bfbdb51bd4e: Add checkoints after the May 2025 network upgrade (authored by Fabien).
Add checkoints after the May 2025 network upgrade
Thu, May 15, 18:19
Fabien planned changes to D18087: [chronik] Add the blockchain.scripthash.subscribe endpoint.
Thu, May 15, 17:06
Fabien updated the diff for D18097: [chronik] Electrum: handle multiple messages in a single packet in the test framework.

feedback

Thu, May 15, 15:26
Fabien updated the diff for D18087: [chronik] Add the blockchain.scripthash.subscribe endpoint.

Missed one implementation instance

Thu, May 15, 14:41
Fabien updated the summary of D18087: [chronik] Add the blockchain.scripthash.subscribe endpoint.
Thu, May 15, 14:31
Fabien updated the diff for D18087: [chronik] Add the blockchain.scripthash.subscribe endpoint.

Rebase on D18097

Thu, May 15, 14:31
Fabien requested review of D18097: [chronik] Electrum: handle multiple messages in a single packet in the test framework.
Thu, May 15, 14:30
Fabien updated the diff for D18087: [chronik] Add the blockchain.scripthash.subscribe endpoint.

Don't call unimplemented methods

Thu, May 15, 14:24
teamcity awarded D18096: Add checkoints after the May 2025 network upgrade a Piece of Eight token.
Thu, May 15, 14:21
Fabien added a comment to D18096: Add checkoints after the May 2025 network upgrade.

@bot build-ibd-no-assumevalid-checkpoint

Thu, May 15, 14:21
teamcity awarded D18096: Add checkoints after the May 2025 network upgrade a Haypence token.
Thu, May 15, 13:50
Fabien added a comment to D18096: Add checkoints after the May 2025 network upgrade.

@bot build-ibd-no-assumevalid

Thu, May 15, 13:50
Fabien requested review of D18096: Add checkoints after the May 2025 network upgrade.
Thu, May 15, 13:44
Fabien closed D18095: [website] Update the upgrade page after the may 15, 2025 upgrade.
Thu, May 15, 13:42
Fabien committed rABCWEB987dac941e22: [website] Update the upgrade page after the may 15, 2025 upgrade (authored by Fabien).
[website] Update the upgrade page after the may 15, 2025 upgrade
Thu, May 15, 13:42
Fabien closed D18088: Bump version to 0.31.4.
Thu, May 15, 13:39
Fabien committed rABCa152ae83fd46: Bump version to 0.31.4 (authored by Fabien).
Bump version to 0.31.4
Thu, May 15, 13:39
Fabien requested review of D18095: [website] Update the upgrade page after the may 15, 2025 upgrade.
Thu, May 15, 13:37
Fabien accepted D18094: [e.cash] Mark upgrade as complete - 2025-05-15.
Thu, May 15, 13:17
Fabien added a comment to D18094: [e.cash] Mark upgrade as complete - 2025-05-15.

@bot preview-e.cash

Thu, May 15, 13:08
Fabien planned changes to D18087: [chronik] Add the blockchain.scripthash.subscribe endpoint.

let's investigate

Thu, May 15, 11:22
Fabien published D18087: [chronik] Add the blockchain.scripthash.subscribe endpoint for review.
Thu, May 15, 10:33
Fabien requested review of D18092: [chronik] Add the blockchain.headers.unsubscribe endpoint.
Thu, May 15, 07:21
Fabien closed D18090: [chronik] Fix "elided lifetime has a name" warnings.
Thu, May 15, 07:14
Fabien committed rABC7fae9e3bf328: [chronik] Fix "elided lifetime has a name" warnings (authored by Fabien).
[chronik] Fix "elided lifetime has a name" warnings
Thu, May 15, 07:14
Fabien closed D18089: [chronik] Extract scripthash history lookup into its own function.
Thu, May 15, 07:14
Fabien committed rABC7a00db9aae23: [chronik] Extract scripthash history lookup into its own function (authored by Fabien).
[chronik] Extract scripthash history lookup into its own function
Thu, May 15, 07:14

Wed, May 14

Fabien requested review of D18090: [chronik] Fix "elided lifetime has a name" warnings.
Wed, May 14, 14:57
Fabien requested review of D18089: [chronik] Extract scripthash history lookup into its own function.
Wed, May 14, 14:53
Fabien requested review of D18088: Bump version to 0.31.4.
Wed, May 14, 12:35

Tue, May 13

Fabien accepted D18079: [assumeutxo] document and enforce incompatability with -chronik.
Tue, May 13, 09:40
Fabien closed D18084: [chronik-client] Properly handle txs ordering in the test.
Tue, May 13, 07:20
Fabien committed rABCe29827cea629: [chronik-client] Properly handle txs ordering in the test (authored by Fabien).
[chronik-client] Properly handle txs ordering in the test
Tue, May 13, 07:20
Fabien added inline comments to D18084: [chronik-client] Properly handle txs ordering in the test.
Tue, May 13, 07:18

Mon, May 12

Fabien closed D18080: [chronik] Electrum: add the blockchain.headers.subscribe endpoint.
Mon, May 12, 22:24
Fabien committed rABCd9be9a3dbe35: [chronik] Electrum: add the blockchain.headers.subscribe endpoint (authored by Fabien).
[chronik] Electrum: add the blockchain.headers.subscribe endpoint
Mon, May 12, 22:24
Fabien closed D18083: More clang-tidy fixes.
Mon, May 12, 22:24
Fabien committed rABC0b231a78864e: More clang-tidy fixes (authored by Fabien).
More clang-tidy fixes
Mon, May 12, 22:24
Fabien requested review of D18084: [chronik-client] Properly handle txs ordering in the test.
Mon, May 12, 22:17
Fabien closed D18081: Remove c++20 header.
Mon, May 12, 21:50
Fabien committed rABCd9414bd7cdc0: Remove c++20 header (authored by Fabien).
Remove c++20 header
Mon, May 12, 21:50
Fabien requested review of D18083: More clang-tidy fixes.
Mon, May 12, 20:29
Fabien closed D18082: Fix a use after free error.
Mon, May 12, 20:26
Fabien committed rABCd0c31e0913ed: Fix a use after free error (authored by Fabien).
Fix a use after free error
Mon, May 12, 20:26
teamcity awarded D18082: Fix a use after free error a Haypence token.
Mon, May 12, 20:04
Fabien added a comment to D18082: Fix a use after free error.

@bot build-asan

Mon, May 12, 20:04
Fabien requested review of D18082: Fix a use after free error.
Mon, May 12, 19:51
Fabien requested review of D18081: Remove c++20 header.
Mon, May 12, 19:34
Fabien requested review of D18080: [chronik] Electrum: add the blockchain.headers.subscribe endpoint.
Mon, May 12, 15:40
Fabien accepted D18071: clang-tidy: Add `performance-no-automatic-move` check.
Mon, May 12, 14:40
Fabien closed D18077: Revert "[chronik] Electrum: add the blockchain.headers.subscribe endpoint".
Mon, May 12, 14:40
Fabien added a reverting change for D18068: [chronik] Electrum: add the blockchain.headers.subscribe endpoint: rABCcdb17840db55: Revert "[chronik] Electrum: add the blockchain.headers.subscribe endpoint".
Mon, May 12, 14:40
Fabien committed rABCcdb17840db55: Revert "[chronik] Electrum: add the blockchain.headers.subscribe endpoint" (authored by Fabien).
Revert "[chronik] Electrum: add the blockchain.headers.subscribe endpoint"
Mon, May 12, 14:40
Fabien added a reverting change for rABC9b02451660e2: [chronik] Electrum: add the blockchain.headers.subscribe endpoint: rABCcdb17840db55: Revert "[chronik] Electrum: add the blockchain.headers.subscribe endpoint".
Mon, May 12, 14:40
Fabien updated the summary of D18077: Revert "[chronik] Electrum: add the blockchain.headers.subscribe endpoint".
Mon, May 12, 14:30
Fabien requested review of D18077: Revert "[chronik] Electrum: add the blockchain.headers.subscribe endpoint".
Mon, May 12, 14:30
Fabien planned changes to D18077: Revert "[chronik] Electrum: add the blockchain.headers.subscribe endpoint".
Mon, May 12, 13:12
Fabien requested review of D18077: Revert "[chronik] Electrum: add the blockchain.headers.subscribe endpoint".
Mon, May 12, 13:11
Fabien added a reverting change for rABC9b02451660e2: [chronik] Electrum: add the blockchain.headers.subscribe endpoint: D18077: Revert "[chronik] Electrum: add the blockchain.headers.subscribe endpoint".
Mon, May 12, 13:11
Fabien added a reverting change for D18068: [chronik] Electrum: add the blockchain.headers.subscribe endpoint: D18077: Revert "[chronik] Electrum: add the blockchain.headers.subscribe endpoint".
Mon, May 12, 13:11
Fabien closed D18068: [chronik] Electrum: add the blockchain.headers.subscribe endpoint.
Mon, May 12, 12:57
Fabien committed rABC9b02451660e2: [chronik] Electrum: add the blockchain.headers.subscribe endpoint (authored by Fabien).
[chronik] Electrum: add the blockchain.headers.subscribe endpoint
Mon, May 12, 12:57
Fabien accepted D18076: clang-tidy: Add more performance checks.
Mon, May 12, 12:47
Fabien accepted D18075: clang-tidy: Add `performance-inefficient-vector-operation` check.
Mon, May 12, 12:42
Fabien updated the test plan for D18068: [chronik] Electrum: add the blockchain.headers.subscribe endpoint.
Mon, May 12, 12:38
Fabien accepted D18074: Fix clang-tidy readability-const-return-type violations.
Mon, May 12, 12:37
Fabien accepted D18073: refactor: Make const refs vars where applicable and enable related clang-tidy checks.
Mon, May 12, 12:30
Fabien added a comment to D18073: refactor: Make const refs vars where applicable and enable related clang-tidy checks.

@bot build-fuzzer

Mon, May 12, 12:28
Fabien accepted D18072: tidy: add readability-redundant-declaration.
Mon, May 12, 12:17
Fabien added inline comments to D18071: clang-tidy: Add `performance-no-automatic-move` check.
Mon, May 12, 12:14
Fabien accepted D17928: [chronik] Add address.rs from givelotus/bitcoinsuite into bitcoinsuite-chronik-client.
Mon, May 12, 12:03
Fabien updated the diff for D18068: [chronik] Electrum: add the blockchain.headers.subscribe endpoint.

Add integration test

Mon, May 12, 09:30
Fabien updated the test plan for D18068: [chronik] Electrum: add the blockchain.headers.subscribe endpoint.
Mon, May 12, 09:30

Fri, May 9

Fabien accepted D18065: restart chronik when reaching the assumeutxo base block.
Fri, May 9, 19:15
Fabien requested changes to D18065: restart chronik when reaching the assumeutxo base block.
Fri, May 9, 15:39
Fabien requested changes to D18065: restart chronik when reaching the assumeutxo base block.
Fri, May 9, 14:44
Fabien updated the summary of D18065: restart chronik when reaching the assumeutxo base block.
Fri, May 9, 14:36
Fabien closed D18070: [chronik] Use the chronik category for logging chronik broadcast errors.
Fri, May 9, 12:18
Fabien committed rABC7a25796cc35a: [chronik] Use the chronik category for logging chronik broadcast errors (authored by Fabien).
[chronik] Use the chronik category for logging chronik broadcast errors
Fri, May 9, 12:18
Fabien requested review of D18070: [chronik] Use the chronik category for logging chronik broadcast errors.
Fri, May 9, 10:01
Fabien added a comment to D18068: [chronik] Electrum: add the blockchain.headers.subscribe endpoint.

still missing the tests

Fri, May 9, 10:01
Fabien planned changes to D18068: [chronik] Electrum: add the blockchain.headers.subscribe endpoint.
Fri, May 9, 10:00
Fabien published D18068: [chronik] Electrum: add the blockchain.headers.subscribe endpoint for review.
Fri, May 9, 10:00
Fabien accepted D18061: [Cashtab] Allow user to receive specified amount of XEC or FIRMA on Receive page.
Fri, May 9, 05:22

Thu, May 8

Fabien accepted D18067: test: remove TODO in feature_assumeutxo.py.
Thu, May 8, 21:13
Fabien accepted D18065: restart chronik when reaching the assumeutxo base block.

We should document this behavior somehow

Thu, May 8, 11:47
Fabien added a comment to D18061: [Cashtab] Allow user to receive specified amount of XEC or FIRMA on Receive page.

Can we have the unit in the amount input field ? IMO it avoids confusion better than the icon only, and 10 XEC is very different from 10 FIRMA

Thu, May 8, 10:27
Fabien added a comment to D18061: [Cashtab] Allow user to receive specified amount of XEC or FIRMA on Receive page.

@bot preview-cashtab

Thu, May 8, 10:15
Fabien requested changes to D18061: [Cashtab] Allow user to receive specified amount of XEC or FIRMA on Receive page.

@bot preview-cashtab

Thu, May 8, 10:14
Fabien requested changes to D17928: [chronik] Add address.rs from givelotus/bitcoinsuite into bitcoinsuite-chronik-client.

Clearing my queue, my previous comment still holds.

Thu, May 8, 10:01