User Details
- User Since
- Oct 7 2018, 09:05 (329 w, 4 d)
- Roles
- Administrator
- Slack Username
- Fabien
Today
Yesterday
Revert link update in the ecashaddrjs README
Tue, Jan 28
Mon, Jan 27
Revert link to op_return-prefix-guideline.md
fix cashaddr.md link (need to reference the legacy spec here)
Rebase, fix more links
Remove duplicated file
Remove the Json doc (duplicated) and the IFP doc (this one never happened).
I'll keep the block and transaction docs which are still mostly good today.
Don't modify the already added specs
Sat, Jan 25
Clearing my queue
This is not testing what you think, as it's not testing the node stops polling the invalidated item. It checks that it rejects a unexpected vote, which is the correct behavior but will happen whatever the vote status of the item is.
Fri, Jan 24
Invalidated invs are removed from the polling list anyway so I'm not sure what the use case is for this. Clearing my queue for now.
Thu, Jan 23
@bot preview-e.cash
Tue, Jan 21
Mon, Jan 20
So look at the code:
- The second test is doing the same as the first plus some more. This makes it clear that you don't need both because they are overlapping
- As a result you don't need serial. To be honest I don't know why you needed it in the first place, but after it's obvious that it's no longer needed.
- Because you only need a single test, you can build on top of the one from the dependency diff D17564, which will avoid me requesting the same changes again.
Please fix the typos in the summary, and fix the test plan which doesn't work.
To format commands you can either use backticks (example) or on a newline prepend with two spaces:
like so
Don't use quotes for "Depends on xxxxx" (I edited your summary to remove them)
The test plan doesn't work
Fix the ordering icons