Page MenuHomePhabricator

Fabien (Fabien)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Oct 7 2018, 09:05 (324 w, 1 d)
Roles
Administrator
Slack Username
Fabien

Recent Activity

Yesterday

Fabien updated the diff for D17392: Wait for remote proof messages in functional tests.

Revert accidental newline

Mon, Dec 23, 22:21
Fabien requested review of D17392: Wait for remote proof messages in functional tests.
Mon, Dec 23, 22:06
Fabien updated the diff for D17390: Improve Indices on pruned nodes via prune blockers.

Bump the syncing timeout

Mon, Dec 23, 18:13
Fabien updated the diff for D17390: Improve Indices on pruned nodes via prune blockers.

Add core#25123

Mon, Dec 23, 17:38
Fabien updated the summary of D17390: Improve Indices on pruned nodes via prune blockers.
Mon, Dec 23, 17:37
Fabien planned changes to D17390: Improve Indices on pruned nodes via prune blockers.
Mon, Dec 23, 17:32
Fabien updated the diff for D17390: Improve Indices on pruned nodes via prune blockers.

Bump the coinstatindex syncing timeout

Mon, Dec 23, 16:09
Fabien closed D17387: Fix a race in abc_p2p_avalanche_remote_proofs.py.
Mon, Dec 23, 15:53
Fabien committed rABC504a0b703be6: Fix a race in abc_p2p_avalanche_remote_proofs.py (authored by Fabien).
Fix a race in abc_p2p_avalanche_remote_proofs.py
Mon, Dec 23, 15:53
Fabien closed D17389: init: disallow reindex-chainstate when pruning.
Mon, Dec 23, 15:53
Fabien committed rABC541bfc8db064: init: disallow reindex-chainstate when pruning (authored by Martin Zumsande <mzumsande@gmail.com>).
init: disallow reindex-chainstate when pruning
Mon, Dec 23, 15:53
Fabien closed D17388: test: check for invalid `-prune` parameters.
Mon, Dec 23, 15:53
Fabien committed rABC65eec8ee3f69: test: check for invalid `-prune` parameters (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
test: check for invalid `-prune` parameters
Mon, Dec 23, 15:52
Fabien planned changes to D17390: Improve Indices on pruned nodes via prune blockers.
Mon, Dec 23, 15:47
Fabien requested review of D17390: Improve Indices on pruned nodes via prune blockers.
Mon, Dec 23, 10:58
Fabien requested review of D17389: init: disallow reindex-chainstate when pruning.
Mon, Dec 23, 10:26
Fabien requested review of D17388: test: check for invalid `-prune` parameters.
Mon, Dec 23, 10:19
Fabien requested review of D17387: Fix a race in abc_p2p_avalanche_remote_proofs.py.
Mon, Dec 23, 09:56

Sun, Dec 22

Fabien accepted D17384: [CI] Update dockerfiles that build-wasm to include bitcoinsuite-chronik-client.

Maybe we shouldn't use workspace for this?

Sun, Dec 22, 20:33

Sat, Dec 21

Fabien closed D17382: test: Avoid intermittent block download timeout in p2p_ibd_stalling.
Sat, Dec 21, 14:43
Fabien committed rABC5396e280be4c: test: Avoid intermittent block download timeout in p2p_ibd_stalling (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>).
test: Avoid intermittent block download timeout in p2p_ibd_stalling
Sat, Dec 21, 14:43

Fri, Dec 20

Fabien requested review of D17382: test: Avoid intermittent block download timeout in p2p_ibd_stalling.
Fri, Dec 20, 22:16
Fabien accepted D17381: test: Avoid race after connect_nodes.
Fri, Dec 20, 21:53
Fabien accepted D17379: [mock-chronik-client] Dockerfile back to latest.
Fri, Dec 20, 13:07
Fabien accepted D17377: [chronik-client] Dockerfile back to latest.

We could do some hacking of the docker file so we don't have to clear the cache when not needed, I will look in to it

Fri, Dec 20, 13:06

Thu, Dec 19

Fabien added inline comments to D17370: [chronik] add blockchain.transaction.broadcast electrum method.
Thu, Dec 19, 13:02
Fabien accepted D17371: [electrum] update server response message for excessive fee.
Thu, Dec 19, 08:17

Wed, Dec 18

Fabien added a comment to D17269: [ecash-lib] Improve address handling of ecash dev libraries.

change toLegacyAddress behavior to throw if called with legacy address

Wed, Dec 18, 20:34
Fabien accepted D17337: [avalanche] Set local stake winner in the contender cache.
Wed, Dec 18, 20:23
Fabien accepted D17345: [avalanche] Make sure each proof is added to contender cache before mining the next block in contender voting test.
Wed, Dec 18, 20:15
Fabien accepted D17368: Fix race to check chaintips in p2p_headers_sync_with_minchainwork.
Wed, Dec 18, 20:11
Fabien requested changes to D17368: Fix race to check chaintips in p2p_headers_sync_with_minchainwork.
Wed, Dec 18, 08:35

Tue, Dec 17

Fabien accepted D17366: [chronik] use custom jsonrpc error codes for application specific errors.
Tue, Dec 17, 20:51
Fabien added a comment to D17366: [chronik] use custom jsonrpc error codes for application specific errors.
In D17366#394875, @PiRK wrote:

Unrelated. Looks like a permission error when creating a directory

20:03:09     File "/work/abc-ci-builds/ecash-lib-integration-tests/test/functional/test_runner.py", line 1094, in <module>
20:03:09       main()
20:03:09     File "/work/abc-ci-builds/ecash-lib-integration-tests/test/functional/test_runner.py", line 361, in main
20:03:09       os.makedirs(tmpdir)
20:03:09     File "<frozen os>", line 225, in makedirs
20:03:09     FileExistsError: [Errno 17] File exists: '/work/abc-ci-builds/ecash-lib-integration-tests/test/tmp/test_runner_₿₵_🏃_20241217_200307'
Tue, Dec 17, 20:48
Fabien accepted D17349: [seeder] Bump thread stacksize.
Tue, Dec 17, 20:46
Fabien accepted D17364: [chronik] check max number of parameters for Electrum commands.
Tue, Dec 17, 20:03
Fabien committed rABC48a7ec65fcf9: [CI] Make sure the nobody user account isn't expired on Arch (authored by Fabien).
[CI] Make sure the nobody user account isn't expired on Arch
Tue, Dec 17, 16:29
Fabien closed D17365: [CI] Make sure the nobody user account isn't expired on Arch.
Tue, Dec 17, 16:29
Fabien requested changes to D17364: [chronik] check max number of parameters for Electrum commands.
Tue, Dec 17, 16:28
Fabien requested review of D17365: [CI] Make sure the nobody user account isn't expired on Arch.
Tue, Dec 17, 15:36
Fabien accepted D17356: [chronik] add electrum method blockchain.transaction.get_height.
Tue, Dec 17, 13:29
Fabien accepted D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.
Tue, Dec 17, 10:35
Fabien added a comment to D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.

@bot build-bitcoinsuite-chronik-client

Tue, Dec 17, 10:33
Fabien requested changes to D17337: [avalanche] Set local stake winner in the contender cache.
Tue, Dec 17, 10:31
Fabien requested changes to D17345: [avalanche] Make sure each proof is added to contender cache before mining the next block in contender voting test.
Tue, Dec 17, 10:14
Fabien requested changes to D17356: [chronik] add electrum method blockchain.transaction.get_height.
Tue, Dec 17, 10:10
Fabien closed D17363: Bump version to 0.30.7.
Tue, Dec 17, 08:44
Fabien committed rABC10d026eb1e67: Bump version to 0.30.7 (authored by Fabien).
Bump version to 0.30.7
Tue, Dec 17, 08:44

Mon, Dec 16

Fabien requested review of D17363: Bump version to 0.30.7.
Mon, Dec 16, 15:09
Fabien accepted D17362: [ecash-herald] Make sure to build mock-chronik-client.
Mon, Dec 16, 14:44
Fabien accepted D17347: [chronik] add macros to extract params from a JSONRPC request.
Mon, Dec 16, 13:54
Fabien closed D17360: [chronik-docs] Fix download links.
Mon, Dec 16, 13:51
Fabien committed rABC951384487677: [chronik-docs] Fix download links (authored by Fabien).
[chronik-docs] Fix download links
Mon, Dec 16, 13:50
Fabien closed D17359: [chronik-docs] Update the latest client version.
Mon, Dec 16, 13:50
Fabien committed rABCacf701c2ff16: [chronik-docs] Update the latest client version (authored by Fabien).
[chronik-docs] Update the latest client version
Mon, Dec 16, 13:50
Fabien accepted D17354: [electrum] use blockchain.transaction.get_height method.

now it works even if electrum is not synced to the tip btw

Mon, Dec 16, 11:10
Fabien requested changes to D17347: [chronik] add macros to extract params from a JSONRPC request.

I would love to see a test for these error cases, since blockchain.transaction.get has both a mandatory and an optional arg it fits perfectly

Mon, Dec 16, 11:06
Fabien accepted D17323: [chronik] add electrum method blockchain.transaction.get.
Mon, Dec 16, 11:01
Fabien requested review of D17360: [chronik-docs] Fix download links.
Mon, Dec 16, 10:50
Fabien requested review of D17359: [chronik-docs] Update the latest client version.
Mon, Dec 16, 10:36
Fabien requested changes to D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.
Mon, Dec 16, 09:52
Fabien requested changes to D17349: [seeder] Bump thread stacksize.
Mon, Dec 16, 09:15

Sat, Dec 14

Fabien accepted D17352: [explorer.Dockerfile][build-configurations.yml] Removed --locked flag.

This unbreaks the explorer deployment, however we should find a fix for this issue

Sat, Dec 14, 12:08

Fri, Dec 13

Fabien closed D17342: Wait for the disconnected peers to be accounted in the getavalancheinfo test.
Fri, Dec 13, 08:30
Fabien committed rABC1bca2c29c6ae: Wait for the disconnected peers to be accounted in the getavalancheinfo test (authored by Fabien).
Wait for the disconnected peers to be accounted in the getavalancheinfo test
Fri, Dec 13, 08:30
Fabien added a comment to D17345: [avalanche] Make sure each proof is added to contender cache before mining the next block in contender voting test.

waiting for len(getavalanchepeerinfo) == QUORUM_NODE_COUNT should be enough here

Fri, Dec 13, 08:28
Fabien requested changes to D17345: [avalanche] Make sure each proof is added to contender cache before mining the next block in contender voting test.
Fri, Dec 13, 08:22

Thu, Dec 12

Fabien added inline comments to D17344: [e.cash] Add Pay2Stay to Use eCash page.
Thu, Dec 12, 21:58
Fabien added a comment to D17344: [e.cash] Add Pay2Stay to Use eCash page.

Any reason for the selected ordering ? Poker first then pay2stay then paybutton ?

Thu, Dec 12, 21:47
Fabien added a comment to D17344: [e.cash] Add Pay2Stay to Use eCash page.

@bot preview-e.cash

Thu, Dec 12, 21:41
Fabien closed D17343: [CI] Fix a type in the build configuration file.
Thu, Dec 12, 20:37
Fabien committed rABC2c16f87cbe8f: [CI] Fix a type in the build configuration file (authored by Fabien).
[CI] Fix a type in the build configuration file
Thu, Dec 12, 20:37
Fabien requested review of D17343: [CI] Fix a type in the build configuration file.
Thu, Dec 12, 20:30
Fabien requested review of D17342: Wait for the disconnected peers to be accounted in the getavalancheinfo test.
Thu, Dec 12, 20:27
Fabien closed D17341: [CI] Don't run the electrum tests in parallel of the functional tests.
Thu, Dec 12, 20:19
Fabien committed rABCde781d9db6de: [CI] Don't run the electrum tests in parallel of the functional tests (authored by Fabien).
[CI] Don't run the electrum tests in parallel of the functional tests
Thu, Dec 12, 20:19
Fabien updated the summary of D17341: [CI] Don't run the electrum tests in parallel of the functional tests.
Thu, Dec 12, 20:18
Fabien requested review of D17341: [CI] Don't run the electrum tests in parallel of the functional tests.
Thu, Dec 12, 20:16
Fabien added inline comments to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Thu, Dec 12, 15:04
Fabien accepted D17314: [chronik] add a test for the new JSON RPC interface.
Thu, Dec 12, 14:55
Fabien closed D17333: [chronik] Add support for TLS to the electrum server.
Thu, Dec 12, 12:13
Fabien committed rABC67384414e3f9: [chronik] Add support for TLS to the electrum server (authored by Fabien).
[chronik] Add support for TLS to the electrum server
Thu, Dec 12, 12:13
Fabien updated the diff for D17333: [chronik] Add support for TLS to the electrum server.

Improve doc, var names and use .min()

Thu, Dec 12, 11:00
Fabien accepted D17338: [mock-chronik-client] Remember to build before publishing.
Thu, Dec 12, 10:05
Fabien added inline comments to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Thu, Dec 12, 10:05
Fabien added inline comments to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Thu, Dec 12, 10:04
Fabien requested changes to D17337: [avalanche] Set local stake winner in the contender cache.

Questions more than requesting changes

Thu, Dec 12, 09:59
Fabien accepted D17336: [avalanche] Restrict scope of cs_stakingRewards lock during cleanup.
Thu, Dec 12, 09:52
Fabien updated the diff for D17333: [chronik] Add support for TLS to the electrum server.

Rebase

Thu, Dec 12, 09:50
Fabien updated the diff for D17333: [chronik] Add support for TLS to the electrum server.

Feedback

Thu, Dec 12, 09:46
Fabien added inline comments to D17333: [chronik] Add support for TLS to the electrum server.
Thu, Dec 12, 09:45

Wed, Dec 11

Fabien added a comment to D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.

nice.

is this a greenfield lib or is it initializing a repo in the monorepo that exists somewhere else?

Wed, Dec 11, 20:14
Fabien accepted D17295: [BITCOIN-ABC CI] Added `cargo build --locked` CI to web/explorer && `explorer.Dockerfile`.
Wed, Dec 11, 11:55
Fabien added a comment to D17295: [BITCOIN-ABC CI] Added `cargo build --locked` CI to web/explorer && `explorer.Dockerfile`.

@bot build-explorer

Wed, Dec 11, 10:43
Fabien requested changes to D17314: [chronik] add a test for the new JSON RPC interface.

The API is now very good imo

Wed, Dec 11, 10:37
Fabien added inline comments to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Wed, Dec 11, 09:14
Fabien requested changes to D17295: [BITCOIN-ABC CI] Added `cargo build --locked` CI to web/explorer && `explorer.Dockerfile`.

Make sure to run the test plan yourself

Wed, Dec 11, 08:42

Tue, Dec 10

Fabien updated the diff for D17333: [chronik] Add support for TLS to the electrum server.

Fix a typo

Tue, Dec 10, 20:21
Fabien updated the test plan for D17333: [chronik] Add support for TLS to the electrum server.
Tue, Dec 10, 20:19
Fabien accepted D17331: Add symlink to most recent functional test failure directory.
Tue, Dec 10, 19:31