User Details
- User Since
- Oct 7 2018, 09:05 (334 w, 18 h)
- Roles
- Administrator
- Slack Username
- Fabien
Fri, Feb 28
Thu, Feb 27
Remove stupid timeout
Remove debug statements
Wed, Feb 26
Since the button will only work based on the external api, it's better to not show the button if the api is unavailable for some reason.
I suggest you do this:
- Attempt to retrieve the price from that endpoint
- If not successful, don't show the button. Otherwise show the button with the actual price, like "Redeem FIRMA for 1234 XEC"
- Not sure if it's worth refreshing periodically (in the even the price changes quickly)
@bot build-tsan
Tue, Feb 25
Mon, Feb 24
To ensure no breaking changes from the updated IPC file, run ./contrib/teamcity/build-configurations.py chronik-client-integration-tests from bitcoin-abc to run typescript tests.
Maybe we could actually print to stdout what step is running and what it does instead of the comment, since stdout is captured by default and not shown upon success. But we can do that later if it feels necessary.
I can see a reason to enforce the char limit. When dealing with UI representation of the donation address, you can be certain that it will fit in your UI field that way.
Another reason is that an abc server might be rejected for invalid content by clients checking the limit if such a thing exists.
Fri, Feb 21
Please make the linter happy
back to your queue
Thu, Feb 20
The title and the file name are incorrect, please fix this before the review
Wed, Feb 19
I reviewed the previous revision, the TODO is indeed done