Page MenuHomePhabricator

Fabien (Fabien)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Oct 7 2018, 09:05 (373 w, 2 d)
Roles
Administrator
Slack Username
Fabien

Recent Activity

Today

Fabien requested review of D19028: [marlin-website] Add a README.
Tue, Dec 2, 15:30
Fabien requested review of D19027: [marlin-website] Enforce bottom padding in the hero.
Tue, Dec 2, 15:22
Fabien requested review of D19026: [marlin-website] Add support for favicons.
Tue, Dec 2, 15:19
Fabien requested review of D19025: [marlin-website] Move the logo to the assets/ folder.
Tue, Dec 2, 15:18
Fabien requested review of D19024: [marlin-website] Rename folder per the domain name.
Tue, Dec 2, 15:02
Fabien committed rABC628626bf44eb: [avalanche] Make the processor's staking preconsensus flag atomic (authored by Fabien).
[avalanche] Make the processor's staking preconsensus flag atomic
Tue, Dec 2, 14:59
Fabien closed D19014: [avalanche] Make the processor's staking preconsensus flag atomic.
Tue, Dec 2, 14:59
Fabien requested review of D19023: [warlin-website] Add a featured image.
Tue, Dec 2, 14:59
teamcity awarded D19014: [avalanche] Make the processor's staking preconsensus flag atomic a Haypence token.
Tue, Dec 2, 12:47
Fabien added a comment to D19014: [avalanche] Make the processor's staking preconsensus flag atomic.

@bot build-tsan

Tue, Dec 2, 12:47
Fabien requested review of D19014: [avalanche] Make the processor's staking preconsensus flag atomic.
Tue, Dec 2, 12:47
Fabien closed D19013: Add release notes for 0.32.4.
Tue, Dec 2, 12:29
Fabien committed rABCf5841cff4bdb: Add release notes for 0.32.4 (authored by Fabien).
Add release notes for 0.32.4
Tue, Dec 2, 12:29
Fabien requested review of D19013: Add release notes for 0.32.4.
Tue, Dec 2, 11:50
Fabien closed D19011: [chronik] Add an unconfirmed-txs endpoint.
Tue, Dec 2, 11:44
Fabien committed rABC0f0a581c406d: [chronik] Add an unconfirmed-txs endpoint (authored by Fabien).
[chronik] Add an unconfirmed-txs endpoint
Tue, Dec 2, 11:44
Fabien updated the diff for D19011: [chronik] Add an unconfirmed-txs endpoint.

Remove debug print

Tue, Dec 2, 09:42
Fabien updated the diff for D19011: [chronik] Add an unconfirmed-txs endpoint.

Remove dead pagination code, fix clippy

Tue, Dec 2, 08:27
Fabien planned changes to D19011: [chronik] Add an unconfirmed-txs endpoint.
Tue, Dec 2, 08:20
Fabien abandoned D18734: [cmake] Add a build target for the proof-manager tool.

Superseded by D18958

Tue, Dec 2, 08:19

Yesterday

Fabien accepted D19012: [electrum] bump version to 5.4.4 and add release notes.
Mon, Dec 1, 19:01
Fabien accepted D19010: [electrum] fix or remove hooks in send_tab.
Mon, Dec 1, 11:25
Fabien accepted D19009: [electrum] fix transaction_dialog when creating a multisig partially signed transaction.
Mon, Dec 1, 11:23
Fabien requested review of D19011: [chronik] Add an unconfirmed-txs endpoint.
Mon, Dec 1, 11:13

Fri, Nov 28

Fabien closed D19008: [e.cash] Add Marlin Wallet.
Fri, Nov 28, 19:44
Fabien committed rABCccf40620701b: [e.cash] Add Marlin Wallet (authored by Fabien).
[e.cash] Add Marlin Wallet
Fri, Nov 28, 19:44
Fabien closed D19007: Add the Marlin Wallet website.
Fri, Nov 28, 19:44
Fabien committed rABC5ddde92c1101: Add the Marlin Wallet website (authored by Fabien).
Add the Marlin Wallet website
Fri, Nov 28, 19:43
Fabien added a comment to D19007: Add the Marlin Wallet website.

Maybe mention that it's open source.

Fri, Nov 28, 15:43
Fabien requested review of D19008: [e.cash] Add Marlin Wallet.
Fri, Nov 28, 15:38
Fabien requested review of D19007: Add the Marlin Wallet website.
Fri, Nov 28, 15:18
Fabien accepted D19004: Reduce cache lookups in CCoinsViewCache::FetchCoin.
Fri, Nov 28, 14:40
Fabien accepted D19005: refactor: Avoid UB in SHA3_256::Write.
Fri, Nov 28, 14:29
Fabien accepted D19006: [electrum] fix context menu in Contacts tab.
Fri, Nov 28, 14:28

Thu, Nov 27

Fabien accepted D19002: [electrum] appimage: bump appimagetool to new version/repo.
Thu, Nov 27, 10:30
Fabien accepted D19001: [electrum] unbreak the appimage build (new transitive dependency required newer version of Cargo).
Thu, Nov 27, 10:29

Wed, Nov 26

Fabien requested changes to D19000: [explorer] Add live transactions view.

There is no point adding a mempool view that doesn't show the mempool. The explorer is a source of trust that we send to users and business to check their node is working, you can explain tons of questions within seconds because users nodes will not show the same as the explorer.
Also:

  • This will break the testnet explorer
  • This is trying to fit cubes into circle holes with finalization. Rather than copying what other chain without preconsensus do, let's take advantage of it to show a better representation. Here is my proposal:
    • Have a view with 2 sides, non final and final
    • Move the tx from one side the other upon finalization This will be useful if e.g. the mempool is full to see what transaction are being finalized and which are pending. Also helps figuring out how block mining works by draining the finalized txs
Wed, Nov 26, 08:50

Tue, Nov 25

Fabien accepted D18999: [electrum] bump version to 5.4.3 and add release notes.
Tue, Nov 25, 20:01
Fabien closed D18998: [avalanche] Reduce the logs verbosity.
Tue, Nov 25, 19:59
Fabien committed rABC80a4dc36201c: [avalanche] Reduce the logs verbosity (authored by Fabien).
[avalanche] Reduce the logs verbosity
Tue, Nov 25, 19:58
Fabien retitled D18998: [avalanche] Reduce the logs verbosity from [avalanche] Reduse the logs verbosity to [avalanche] Reduce the logs verbosity.
Tue, Nov 25, 19:58
Fabien retitled D18998: [avalanche] Reduce the logs verbosity from [avalanche] Redume the logs verbosity to [avalanche] Reduse the logs verbosity.
Tue, Nov 25, 19:58
Fabien requested review of D18998: [avalanche] Reduce the logs verbosity.
Tue, Nov 25, 15:20
Fabien accepted D18997: [chronik-client] Patch version for CI publication with correct deps.
Tue, Nov 25, 12:29
Fabien accepted D18995: [ecash-agora] Patch bump to catch updated chronik-client and ecash-wallet deps.
Tue, Nov 25, 08:27
Fabien accepted D18994: [ecash-wallet] Minor bump to catch updated chronik-client.
Tue, Nov 25, 08:26
Fabien accepted D18993: [chronik-client] Support the new txs ws subscription.
Tue, Nov 25, 08:26

Mon, Nov 24

Fabien accepted D18985: [Chronik] Add `WsSubTxs` subscription.
Mon, Nov 24, 21:14
Fabien accepted D18991: [electrum] bump version of ubuntu packages.
Mon, Nov 24, 20:50
Fabien accepted D18990: [electrum] enable sorting when selecting utxos for a proof.
Mon, Nov 24, 20:49
Fabien accepted D18989: [electrum] fix unit for proof editor.
Mon, Nov 24, 20:48
Fabien accepted D18988: [electrum] don't use magic values for decimal_point and num_zeros.
Mon, Nov 24, 20:44
Fabien accepted D18987: [IBD] coins: increase default UTXO flush batch size to 32 MiB.
Mon, Nov 24, 08:26
Fabien accepted D18986: txpool: add a fast path in TxPool::EraseForBlock when the pool is empty.
Mon, Nov 24, 08:24

Sat, Nov 22

Fabien closed D18978: Cleanup Shibusawa activation after the November 15, 2025 upgrade.
Sat, Nov 22, 16:31
Fabien committed rABCcb55399c0ea3: Cleanup Shibusawa activation after the November 15, 2025 upgrade (authored by Fabien).
Cleanup Shibusawa activation after the November 15, 2025 upgrade
Sat, Nov 22, 16:31
Fabien accepted D18984: [Cashtab] Only show extension install notification for webapp.
Sat, Nov 22, 02:33

Fri, Nov 21

Fabien accepted D18983: Add AutoFile::detail_fread member function.
Fri, Nov 21, 19:32
Fabien accepted D18982: refactor: Modernize AutoFile.
Fri, Nov 21, 19:29
Fabien accepted D18981: doc: Remove comments that just repeat what the code does.
Fri, Nov 21, 19:28
Fabien accepted D18980: refactor: Remove redundant file check from AutoFile shift operators.
Fri, Nov 21, 19:27
Fabien accepted D18979: refactor: Remove unused CDataStream SerializeMany constructor.
Fri, Nov 21, 16:31
Fabien published D18978: Cleanup Shibusawa activation after the November 15, 2025 upgrade for review.
Fri, Nov 21, 16:30
teamcity awarded D18978: Cleanup Shibusawa activation after the November 15, 2025 upgrade a Haypence token.
Fri, Nov 21, 15:22
Fabien accepted D18955: [64-bit ints] 32-bit integers? I never knew you.
Fri, Nov 21, 12:31
Fabien accepted D18977: log: Nuke error(...).
Fri, Nov 21, 12:29

Thu, Nov 20

Fabien accepted D18975: [ecash-wallet] Patch bump to catch updated chronik-client.
Thu, Nov 20, 22:55
Fabien accepted D18976: [ecash-agora] Patch version bump for updated chronik-client and ecash-wallet deps.
Thu, Nov 20, 22:55
Fabien accepted D18974: blockstorage: Separate reindexing from saving new blocks.
Thu, Nov 20, 22:22
Fabien accepted D18960: [Cashtab, chronik-client] Add and implement ws methods to support mobile app backgrounding.
Thu, Nov 20, 22:12
Fabien added inline comments to D18960: [Cashtab, chronik-client] Add and implement ws methods to support mobile app backgrounding.
Thu, Nov 20, 19:25
Fabien accepted D18973: blockstorage: do not flush block to disk if it is already there.
Thu, Nov 20, 11:10
Fabien accepted D18972: Remove utxo db upgrade code.
Thu, Nov 20, 11:02
Fabien accepted D18969: kernel: Add fatalError method to notifications.
Thu, Nov 20, 10:58
Fabien accepted D18971: test: cover read-only blockstore.
Thu, Nov 20, 09:03
Fabien requested changes to D18969: kernel: Add fatalError method to notifications.
Thu, Nov 20, 08:58
Fabien accepted D18968: kernel: Add flushError method to notifications.
Thu, Nov 20, 08:49
Fabien accepted D18967: scripted-diff: Rename FatalError to FatalErrorf.
Thu, Nov 20, 08:47
Fabien accepted D18966: kernel: Pass interrupt reference to chainman.
Thu, Nov 20, 08:47
Fabien accepted D18970: txdb: remove dependency on ui_interface.
Thu, Nov 20, 08:42
Fabien accepted D18965: util: Add SignalInterrupt class and use in shutdown.cpp.
Thu, Nov 20, 08:40
Fabien accepted D18964: util: move threadinterrupt into util.
Thu, Nov 20, 08:37

Wed, Nov 19

Fabien added a comment to D18960: [Cashtab, chronik-client] Add and implement ws methods to support mobile app backgrounding.

We have a keepalive already, and websocket has pings which seems a better/cleaner option

Indeed. However, when an app is backgrounded, the websocket nevertheless disconnects, and it does not automatically reconnect when the app is unbackgrounded. This would be nice to handle in chronik-client but I'm not sure how to listen for this event in chronik-client, or if it's even practical to do so there, as the whole backgrounded event is a mobile app thing. I don't think we want capacitor as a dep in chronik-client.

Wed, Nov 19, 21:45
Fabien accepted D18955: [64-bit ints] 32-bit integers? I never knew you.
Wed, Nov 19, 21:36
Fabien closed D18963: [website] Build the man pages for iguana and the proof-manager-cli.
Wed, Nov 19, 10:17
Fabien committed rABCWEB337c6cb67c02: [website] Build the man pages for iguana and the proof-manager-cli (authored by Fabien).
[website] Build the man pages for iguana and the proof-manager-cli
Wed, Nov 19, 10:17
Fabien closed D18961: [cmake] Add man pages for the new executables.
Wed, Nov 19, 10:17
Fabien committed rABCb391ea877c5f: [cmake] Add man pages for the new executables (authored by Fabien).
[cmake] Add man pages for the new executables
Wed, Nov 19, 10:17
Fabien closed D18962: Bump version to 0.32.4.
Wed, Nov 19, 10:16
Fabien committed rABC67398d127ca0: Bump version to 0.32.4 (authored by Fabien).
Bump version to 0.32.4
Wed, Nov 19, 10:16
Fabien added inline comments to D18961: [cmake] Add man pages for the new executables.
Wed, Nov 19, 10:15
Fabien requested review of D18963: [website] Build the man pages for iguana and the proof-manager-cli.
Wed, Nov 19, 10:04
Fabien requested review of D18962: Bump version to 0.32.4.
Wed, Nov 19, 09:47
Fabien updated the diff for D18961: [cmake] Add man pages for the new executables.

Rebase

Wed, Nov 19, 09:03
Fabien requested review of D18961: [cmake] Add man pages for the new executables.
Wed, Nov 19, 09:01
Fabien closed D18958: [cmake] Add a target for the proof-manager-cli tool.
Wed, Nov 19, 08:43
Fabien closed D18956: [proof-manager-cli] Rename the proof-manager executable to proof-manager-cli.
Wed, Nov 19, 08:43
Fabien closed D18959: [guix] Add the proof-manager-cli to the release.
Wed, Nov 19, 08:43
Fabien committed rABC7bc6ada8fa77: [proof-manager-cli] Rename the proof-manager executable to proof-manager-cli (authored by Fabien).
[proof-manager-cli] Rename the proof-manager executable to proof-manager-cli
Wed, Nov 19, 08:43
Fabien committed rABCa569b425ae1b: [cmake] Add a target for the proof-manager-cli tool (authored by Fabien).
[cmake] Add a target for the proof-manager-cli tool
Wed, Nov 19, 08:43