Page MenuHomePhabricator

Fabien (Fabien)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Oct 7 2018, 09:05 (329 w, 4 d)
Roles
Administrator
Slack Username
Fabien

Recent Activity

Today

Fabien closed D17600: [doc] Rename some spec file to remove the activation date.
Thu, Jan 30, 08:10
Fabien committed rABC8379d6a7bf1a: [doc] Rename some spec file to remove the activation date (authored by Fabien).
[doc] Rename some spec file to remove the activation date
Thu, Jan 30, 08:10

Yesterday

Fabien accepted D17590: [avalanche] Check that avalanche invalidated items no longer poll in the dont_poll_invalid_item test case.
Wed, Jan 29, 19:58
Fabien added inline comments to D17600: [doc] Rename some spec file to remove the activation date.
Wed, Jan 29, 09:51
Fabien updated the diff for D17600: [doc] Rename some spec file to remove the activation date.

Revert link update in the ecashaddrjs README

Wed, Jan 29, 09:50

Tue, Jan 28

Fabien committed rABCb6929f58a136: [cmake] Fix check-crates (authored by Fabien).
[cmake] Fix check-crates
Tue, Jan 28, 16:18
Fabien closed D17604: [cmake] Fix check-crates.
Tue, Jan 28, 16:18
teamcity awarded D17604: [cmake] Fix check-crates a Haypence token.
Tue, Jan 28, 15:47
Fabien added a comment to D17604: [cmake] Fix check-crates.

@bot build-chronik

Tue, Jan 28, 15:47
Fabien requested review of D17604: [cmake] Fix check-crates.
Tue, Jan 28, 15:47
Fabien closed D17603: Bump version to 0.30.10.
Tue, Jan 28, 14:14
Fabien committed rABC98280cb3c2b8: Bump version to 0.30.10 (authored by Fabien).
Bump version to 0.30.10
Tue, Jan 28, 14:14
Fabien requested review of D17603: Bump version to 0.30.10.
Tue, Jan 28, 11:59
Fabien closed D17601: [chronik] Fix check-crates.
Tue, Jan 28, 08:19
Fabien committed rABCe1a3a8f1fd34: [chronik] Fix check-crates (authored by Fabien).
[chronik] Fix check-crates
Tue, Jan 28, 08:19

Mon, Jan 27

Fabien added inline comments to D17600: [doc] Rename some spec file to remove the activation date.
Mon, Jan 27, 21:29
Fabien accepted D17589: [avalanche] Clear updates on each call to registerVotes.
Mon, Jan 27, 21:26
Fabien updated the diff for D17600: [doc] Rename some spec file to remove the activation date.

Revert link to op_return-prefix-guideline.md

Mon, Jan 27, 21:25
Fabien requested review of D17601: [chronik] Fix check-crates.
Mon, Jan 27, 21:19
Fabien updated the diff for D17600: [doc] Rename some spec file to remove the activation date.

fix cashaddr.md link (need to reference the legacy spec here)

Mon, Jan 27, 19:38
Fabien updated the diff for D17600: [doc] Rename some spec file to remove the activation date.

Rebase, fix more links

Mon, Jan 27, 19:34
Fabien closed D17597: [doc] Add all the legacy specifications to the monorepo.
Mon, Jan 27, 19:28
Fabien committed rABCd1b0c718b130: [doc] Add all the legacy specifications to the monorepo (authored by Fabien).
[doc] Add all the legacy specifications to the monorepo
Mon, Jan 27, 19:28
Fabien requested review of D17600: [doc] Rename some spec file to remove the activation date.
Mon, Jan 27, 19:21
Fabien updated the diff for D17597: [doc] Add all the legacy specifications to the monorepo.

Remove duplicated file

Mon, Jan 27, 19:07
Fabien updated the diff for D17597: [doc] Add all the legacy specifications to the monorepo.

Remove the Json doc (duplicated) and the IFP doc (this one never happened).
I'll keep the block and transaction docs which are still mostly good today.

Mon, Jan 27, 19:03
Fabien accepted D17599: [chronik] make -chronikelectrumbind require -chronikscripthashindex.
Mon, Jan 27, 16:16
Fabien accepted D17598: [ci] Add specific packages to run when calling cargo test.
Mon, Jan 27, 16:10
Fabien retitled D17598: [ci] Add specific packages to run when calling cargo test from [build-configurations] Add specific packages to run when calling cargo test to [ci] Add specific packages to run when calling cargo test.
Mon, Jan 27, 15:59
Fabien updated the diff for D17597: [doc] Add all the legacy specifications to the monorepo.

Don't modify the already added specs

Mon, Jan 27, 15:49
Fabien requested review of D17597: [doc] Add all the legacy specifications to the monorepo.
Mon, Jan 27, 15:46
Fabien closed D17596: Bump the timeout for searching the debug log in p2p_ibd_stalling.
Mon, Jan 27, 13:41
Fabien committed rABC405135290be7: Bump the timeout for searching the debug log in p2p_ibd_stalling (authored by Fabien).
Bump the timeout for searching the debug log in p2p_ibd_stalling
Mon, Jan 27, 13:41
Fabien accepted D16610: [explorer] Render cashaddr for all inputs and outputs on transaction page.
Mon, Jan 27, 09:35
Fabien requested review of D17596: Bump the timeout for searching the debug log in p2p_ibd_stalling.
Mon, Jan 27, 08:54

Sat, Jan 25

Fabien requested changes to D16610: [explorer] Render cashaddr for all inputs and outputs on transaction page.

Clearing my queue

Sat, Jan 25, 21:55
Fabien accepted D17592: [Cashtab] Make listing amounts more readable in agora listing notifications.
Sat, Jan 25, 15:10
Fabien requested changes to D17590: [avalanche] Check that avalanche invalidated items no longer poll in the dont_poll_invalid_item test case.

This is not testing what you think, as it's not testing the node stops polling the invalidated item. It checks that it rejects a unexpected vote, which is the correct behavior but will happen whatever the vote status of the item is.

Sat, Jan 25, 15:09
Fabien requested changes to D17589: [avalanche] Clear updates on each call to registerVotes.
Sat, Jan 25, 15:06
Fabien committed rABC8431d091c004: Bump the timeout in p2p_ibd_stalling (authored by Fabien).
Bump the timeout in p2p_ibd_stalling
Sat, Jan 25, 15:04
Fabien closed D17586: Bump the timeout in p2p_ibd_stalling.
Sat, Jan 25, 15:04
Fabien closed D17585: Bump the timeout for the feature_cltv test.
Sat, Jan 25, 15:03
Fabien committed rABCc81da9b925ae: Bump the timeout for the feature_cltv test (authored by Fabien).
Bump the timeout for the feature_cltv test
Sat, Jan 25, 15:03
Fabien accepted D17564: [chronik] Add test runner to bitcoinsuite-chronik-client.
Sat, Jan 25, 15:02

Fri, Jan 24

Fabien accepted D17587: [electrum] push release notification for 5.4.0.
Fri, Jan 24, 16:21
Fabien accepted D17565: [Chronik] Add unix socket listener to test_runner.rs.
Fri, Jan 24, 14:45
Fabien requested changes to D17582: [avalanche] Add an invalidation latch to contender cache.

Invalidated invs are removed from the polling list anyway so I'm not sure what the use case is for this. Clearing my queue for now.

Fri, Jan 24, 08:37
Fabien closed D17583: [e.cash] Add a link to the chronik documentation.
Fri, Jan 24, 08:32
Fabien committed rABC55ae02dedb89: [e.cash] Add a link to the chronik documentation (authored by Fabien).
[e.cash] Add a link to the chronik documentation
Fri, Jan 24, 08:32
Fabien requested review of D17586: Bump the timeout in p2p_ibd_stalling.
Fri, Jan 24, 08:30
Fabien requested review of D17585: Bump the timeout for the feature_cltv test.
Fri, Jan 24, 08:24

Thu, Jan 23

teamcity awarded D17583: [e.cash] Add a link to the chronik documentation a Haypence token.
Thu, Jan 23, 19:24
Fabien added a comment to D17583: [e.cash] Add a link to the chronik documentation.

@bot preview-e.cash

Thu, Jan 23, 19:24
Fabien requested review of D17583: [e.cash] Add a link to the chronik documentation.
Thu, Jan 23, 19:24
Fabien accepted D17580: [electrum] fix lib versions for windows release scripts.
Thu, Jan 23, 18:58
Fabien closed D17579: [electrum][trezor] 1-click install of the eCash logo as a homescreen.
Thu, Jan 23, 15:45
Fabien committed rABC9fe5282e5388: [electrum][trezor] 1-click install of the eCash logo as a homescreen (authored by Fabien).
[electrum][trezor] 1-click install of the eCash logo as a homescreen
Thu, Jan 23, 15:45
Fabien closed D17578: [electrum][trezor] Fix homescreen reset.
Thu, Jan 23, 14:08
Fabien committed rABCbca06065030d: [electrum][trezor] Fix homescreen reset (authored by Fabien).
[electrum][trezor] Fix homescreen reset
Thu, Jan 23, 14:08
Fabien accepted D17577: [electrum] Implement SLIP-0039 wallet recovery..
Thu, Jan 23, 14:04
Fabien requested review of D17579: [electrum][trezor] 1-click install of the eCash logo as a homescreen.
Thu, Jan 23, 13:36
Fabien accepted D17576: [electrum] pass the bip32 rootseed to the derivation path scanner.
Thu, Jan 23, 13:05
Fabien requested review of D17578: [electrum][trezor] Fix homescreen reset.
Thu, Jan 23, 13:02
Fabien accepted D17575: [Cashtab] No double notifications for SLP partial lists.
Thu, Jan 23, 08:16

Tue, Jan 21

Fabien accepted D17574: [avalanche] Fixup incorrect comment about contender cache vote status.
Tue, Jan 21, 20:27
Fabien requested changes to D17565: [Chronik] Add unix socket listener to test_runner.rs.
Tue, Jan 21, 17:11
Fabien requested changes to D17564: [chronik] Add test runner to bitcoinsuite-chronik-client.
Tue, Jan 21, 17:09
Fabien accepted D17572: [electrum] refactor: introduce a Wordlist class for seed phrases.
Tue, Jan 21, 15:34
Fabien accepted D17570: [electrum] seed completer: colour words yellow if only in old electrum list.
Tue, Jan 21, 15:31
Fabien accepted D17569: [electrum] implement autocompletion when restoring from seed.
Tue, Jan 21, 15:30
Fabien updated the summary of D17569: [electrum] implement autocompletion when restoring from seed.
Tue, Jan 21, 15:28
Fabien updated the summary of D17569: [electrum] implement autocompletion when restoring from seed.
Tue, Jan 21, 15:28
Fabien accepted D17568: [electrum] refactor text completion.
Tue, Jan 21, 15:28
Fabien requested changes to D17565: [Chronik] Add unix socket listener to test_runner.rs.
Tue, Jan 21, 15:24
Fabien requested changes to D17564: [chronik] Add test runner to bitcoinsuite-chronik-client.
Tue, Jan 21, 15:22

Mon, Jan 20

Fabien committed rABCf5df03af3064: [explorer] Update the address.js hash (authored by Fabien).
[explorer] Update the address.js hash
Mon, Jan 20, 10:19
Fabien closed D17567: [explorer] Update the address.js hash.
Mon, Jan 20, 10:19
Fabien requested review of D17567: [explorer] Update the address.js hash.
Mon, Jan 20, 10:13
Fabien added a comment to D17565: [Chronik] Add unix socket listener to test_runner.rs.

So look at the code:

  • The second test is doing the same as the first plus some more. This makes it clear that you don't need both because they are overlapping
  • As a result you don't need serial. To be honest I don't know why you needed it in the first place, but after it's obvious that it's no longer needed.
  • Because you only need a single test, you can build on top of the one from the dependency diff D17564, which will avoid me requesting the same changes again.
Mon, Jan 20, 09:16
Fabien requested changes to D17565: [Chronik] Add unix socket listener to test_runner.rs.

Please fix the typos in the summary, and fix the test plan which doesn't work.
To format commands you can either use backticks (example) or on a newline prepend with two spaces:

like so
Mon, Jan 20, 09:06
Fabien added a comment to D17565: [Chronik] Add unix socket listener to test_runner.rs.

Don't use quotes for "Depends on xxxxx" (I edited your summary to remove them)

Mon, Jan 20, 09:03
Fabien updated the summary of D17565: [Chronik] Add unix socket listener to test_runner.rs.
Mon, Jan 20, 09:03
Fabien closed D17562: [explorer] Fix sorting txs by age/date.
Mon, Jan 20, 08:57
Fabien committed rABCd160beb94e65: [explorer] Fix sorting txs by age/date (authored by Fabien).
[explorer] Fix sorting txs by age/date
Mon, Jan 20, 08:57
Fabien requested changes to D17564: [chronik] Add test runner to bitcoinsuite-chronik-client.

The test plan doesn't work

Mon, Jan 20, 08:57
Fabien updated the diff for D17562: [explorer] Fix sorting txs by age/date.

Fix the ordering icons

Mon, Jan 20, 08:36
Fabien added inline comments to D17566: [e.cash] Remove eCashPoker.
Mon, Jan 20, 08:09
Fabien closed D17563: [electrum] Fix Trezor 1 unlocking.
Mon, Jan 20, 08:08
Fabien committed rABCedd93d52945b: [electrum] Fix Trezor 1 unlocking (authored by Fabien).
[electrum] Fix Trezor 1 unlocking
Mon, Jan 20, 08:08

Sat, Jan 18

Fabien planned changes to D17562: [explorer] Fix sorting txs by age/date.

mb this issue is just from me running it locally?

sorting is broken at explorer.e.cash, but I do see the arrow highlighted on clicking to show sort:

image.png (316×192 px, 13 KB)

Running this diff, the sorting is fixed, but I do not see the up or down arrows highlight on click to indicate sort:

image.png (316×192 px, 8 KB)

The arrow highlighting still works on the "size" sort option but not Age or Date. Probably since Age and Date are now actually sorting by timestamp, so the templating is not picking up the effect.

probably still worth landing the diff to fix the behavior. I am not sure how I would fix this style issue with rust templating.

Sat, Jan 18, 22:01
Fabien requested review of D17563: [electrum] Fix Trezor 1 unlocking.
Sat, Jan 18, 21:57
Fabien accepted D17561: [electrum] trezor: allow PIN of length 50 for T1 firmware >=1.10.0 and other devices firmware >=2.4.0.
Sat, Jan 18, 21:16
Fabien requested review of D17562: [explorer] Fix sorting txs by age/date.
Sat, Jan 18, 21:14

Fri, Jan 17

Fabien accepted D17549: [Cashtab] Patch render logic for spinner.
Fri, Jan 17, 21:29
Fabien accepted D17555: [electrum] trezor: implement support for Shamir recovery.
Fri, Jan 17, 20:53
Fabien planned changes to D6571: [WIP] Test commit, don't review.
Fri, Jan 17, 20:21
Fabien updated the diff for D6571: [WIP] Test commit, don't review.

Rebase

Fri, Jan 17, 20:21
Fabien closed D17554: [electrum] Better trezor homescreen support.
Fri, Jan 17, 10:56
Fabien committed rABC0039c265e056: [electrum] Better trezor homescreen support (authored by Fabien).
[electrum] Better trezor homescreen support
Fri, Jan 17, 10:56
Fabien accepted D17553: [electrum] trezor: implement "seedless" mode (option during initialization).
Fri, Jan 17, 10:48