Page MenuHomePhabricator

Fabien (Fabien)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Oct 7 2018, 09:05 (334 w, 18 h)
Roles
Administrator
Slack Username
Fabien

Recent Activity

Fri, Feb 28

Fabien accepted D17719: [monorepo] Add --locked flag to Dockerfiles.
Fri, Feb 28, 11:30
Fabien published D17717: [avalanche] Also finalize the ancestors of a transaction for review.
Fri, Feb 28, 11:28
Fabien accepted D17718: [faucet] Add locked to dockerfile.
Fri, Feb 28, 11:19
Fabien accepted D17714: index: fix reindex-chainstate with active indexes.
Fri, Feb 28, 09:43
Fabien requested changes to D17700: [avalanche] Process responses to stake contender polls.
Fri, Feb 28, 09:39

Thu, Feb 27

Fabien accepted D17710: [avalanche] Simplify contenders by treating rejection and invalidation the same.
Thu, Feb 27, 21:20
Fabien accepted D17715: [e.cash] Tweak Build page wordings.
Thu, Feb 27, 20:38
Fabien requested changes to D17714: index: fix reindex-chainstate with active indexes.
Thu, Feb 27, 20:38
Fabien requested changes to D17710: [avalanche] Simplify contenders by treating rejection and invalidation the same.
Thu, Feb 27, 20:25
Fabien closed D17713: Prevent occasional timeout in feature_assumevalid.
Thu, Feb 27, 10:25
Fabien committed rABCba974a9c5381: Prevent occasional timeout in feature_assumevalid (authored by Fabien).
Prevent occasional timeout in feature_assumevalid
Thu, Feb 27, 10:25
Fabien updated the diff for D17713: Prevent occasional timeout in feature_assumevalid.

Remove stupid timeout

Thu, Feb 27, 10:15
Fabien updated the diff for D17713: Prevent occasional timeout in feature_assumevalid.

Remove debug statements

Thu, Feb 27, 10:07
Fabien planned changes to D17713: Prevent occasional timeout in feature_assumevalid.
Thu, Feb 27, 10:05
Fabien requested review of D17713: Prevent occasional timeout in feature_assumevalid.
Thu, Feb 27, 10:05
Fabien accepted D17711: [avalanche] Return proofids in addition to payout scripts in getWinners.
Thu, Feb 27, 08:22
Fabien requested changes to D17710: [avalanche] Simplify contenders by treating rejection and invalidation the same.
Thu, Feb 27, 08:19
Fabien accepted D17706: refactor: use std::string for thread names.
Thu, Feb 27, 08:15

Wed, Feb 26

Fabien accepted D17705: indexes, refactor: Pass Chain interface instead of CChainState class to indexes.
Wed, Feb 26, 20:34
Fabien accepted D17709: [Cashtab] Parse firma yield txs.
Wed, Feb 26, 20:20
Fabien accepted D17708: [Cashtab] Update token scam prevention list.
Wed, Feb 26, 20:16
Fabien accepted D17707: refactor: use std::string for index names.
Wed, Feb 26, 20:16
Fabien requested changes to D17706: refactor: use std::string for thread names.
Wed, Feb 26, 20:13
Fabien added a comment to D17701: [Cashtab] Support one-click redemptions.

Since the button will only work based on the external api, it's better to not show the button if the api is unavailable for some reason.
I suggest you do this:

  1. Attempt to retrieve the price from that endpoint
  2. If not successful, don't show the button. Otherwise show the button with the actual price, like "Redeem FIRMA for 1234 XEC"
  3. Not sure if it's worth refreshing periodically (in the even the price changes quickly)
Wed, Feb 26, 20:10
Fabien accepted D17686: [chronik] add Electrum RPC server.donation_address.
Wed, Feb 26, 19:44
Fabien requested changes to D17686: [chronik] add Electrum RPC server.donation_address.
Wed, Feb 26, 12:59
Fabien requested changes to D17686: [chronik] add Electrum RPC server.donation_address.
Wed, Feb 26, 10:30
Fabien requested changes to D17700: [avalanche] Process responses to stake contender polls.
Wed, Feb 26, 10:23
Fabien added a comment to D17700: [avalanche] Process responses to stake contender polls.

@bot build-tsan

Wed, Feb 26, 09:08

Tue, Feb 25

Fabien accepted D17699: [avalanche] Clarify and simplify checking polled contenders.
Tue, Feb 25, 20:16
Fabien accepted D17697: [Cashtab] Make sure whitelisted agora tokens load cache first.
Tue, Feb 25, 20:15
Fabien closed D17698: Avoid inflight polls in getavaaddr_interval_test.
Tue, Feb 25, 20:13
Fabien committed rABC7cab3cee14ab: Avoid inflight polls in getavaaddr_interval_test (authored by Fabien).
Avoid inflight polls in getavaaddr_interval_test
Tue, Feb 25, 20:13
Fabien requested review of D17698: Avoid inflight polls in getavaaddr_interval_test.
Tue, Feb 25, 15:18
teamcity awarded D17659: [WIP] CI investigation a Love token.
Tue, Feb 25, 13:38
teamcity awarded D17659: [WIP] CI investigation a Like token.
Tue, Feb 25, 13:38
teamcity awarded D17659: [WIP] CI investigation a Love token.
Tue, Feb 25, 12:11
Fabien accepted D17689: wallet: Ignore chainStateFlushed notifications while attaching chain.
Tue, Feb 25, 10:02
Fabien accepted D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.
Tue, Feb 25, 09:53
Fabien accepted D17696: [avalanche] Make contender test more comprehensive.
Tue, Feb 25, 09:52

Mon, Feb 24

Fabien requested changes to D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.
Mon, Feb 24, 20:34
Fabien requested changes to D17687: [Chronik] Add integration test for block_and_blocks endpoint into bitcoinsuite-chronik-client.
Mon, Feb 24, 19:49
Fabien requested changes to D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.
Mon, Feb 24, 19:41
Fabien accepted D17692: [avalanche] Fix missing wait_until in contender test.
Mon, Feb 24, 19:34
Fabien requested changes to D17687: [Chronik] Add integration test for block_and_blocks endpoint into bitcoinsuite-chronik-client.
Mon, Feb 24, 08:43
Fabien requested changes to D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.
Mon, Feb 24, 08:38
Fabien added a comment to D17687: [Chronik] Add integration test for block_and_blocks endpoint into bitcoinsuite-chronik-client.

To ensure no breaking changes from the updated IPC file, run ./contrib/teamcity/build-configurations.py chronik-client-integration-tests from bitcoin-abc to run typescript tests.

Mon, Feb 24, 08:29
Fabien added a comment to D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.

Maybe we could actually print to stdout what step is running and what it does instead of the comment, since stdout is captured by default and not shown upon success. But we can do that later if it feels necessary.

Mon, Feb 24, 08:27
Fabien accepted D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.
Mon, Feb 24, 08:25
Fabien requested changes to D17686: [chronik] add Electrum RPC server.donation_address.

I can see a reason to enforce the char limit. When dealing with UI representation of the donation address, you can be certain that it will fit in your UI field that way.
Another reason is that an abc server might be rejected for invalid content by clients checking the limit if such a thing exists.

Mon, Feb 24, 08:17

Fri, Feb 21

Fabien requested changes to D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.

Please make the linter happy

Fri, Feb 21, 18:01
Fabien requested changes to D17686: [chronik] add Electrum RPC server.donation_address.

back to your queue

Fri, Feb 21, 18:01
Fabien closed D17684: [chronik] Fix the chronik_plugins test.
Fri, Feb 21, 14:57
Fabien committed rABC689acf59eacb: [chronik] Fix the chronik_plugins test (authored by Fabien).
[chronik] Fix the chronik_plugins test
Fri, Feb 21, 14:57
Fabien requested review of D17684: [chronik] Fix the chronik_plugins test.
Fri, Feb 21, 14:02
Fabien closed D17682: Fix nullptr clientModel access during shutdown.
Fri, Feb 21, 13:58
Fabien committed rABC2f1230a53610: Fix nullptr clientModel access during shutdown (authored by furszy <matiasfurszyfer@protonmail.com>).
Fix nullptr clientModel access during shutdown
Fri, Feb 21, 13:58
Fabien closed D17683: [chronik] Fix handling of -chronikelectrummaxhistory.
Fri, Feb 21, 13:57
Fabien committed rABC4261e4fe94d7: [chronik] Fix handling of -chronikelectrummaxhistory (authored by Fabien).
[chronik] Fix handling of -chronikelectrummaxhistory
Fri, Feb 21, 13:57
Fabien requested review of D17683: [chronik] Fix handling of -chronikelectrummaxhistory.
Fri, Feb 21, 13:35
Fabien requested review of D17682: Fix nullptr clientModel access during shutdown.
Fri, Feb 21, 13:09
Fabien requested changes to D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.
Fri, Feb 21, 08:45
Fabien accepted D17607: [avalanche] Poll for stake contenders.
Fri, Feb 21, 08:41

Thu, Feb 20

Fabien accepted D17681: [chronik] make the maximum history length for electrum RPCs an init param.
Thu, Feb 20, 19:46
Fabien requested changes to D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.

The title and the file name are incorrect, please fix this before the review

Thu, Feb 20, 19:46
Fabien closed D17680: [chronik-client] Fix a bug in the plugins integration test.
Thu, Feb 20, 19:15
Fabien committed rABCea44416f09d0: [chronik-client] Fix a bug in the plugins integration test (authored by Fabien).
[chronik-client] Fix a bug in the plugins integration test
Thu, Feb 20, 19:15
Fabien requested review of D17680: [chronik-client] Fix a bug in the plugins integration test.
Thu, Feb 20, 13:25
Fabien added inline comments to D17607: [avalanche] Poll for stake contenders.
Thu, Feb 20, 08:37
Fabien closed D17679: Remove extra mockscheduler call in abc_p2p_getavaaddr.
Thu, Feb 20, 08:28
Fabien committed rABC2a1c960435b6: Remove extra mockscheduler call in abc_p2p_getavaaddr (authored by Fabien).
Remove extra mockscheduler call in abc_p2p_getavaaddr
Thu, Feb 20, 08:28

Wed, Feb 19

Fabien requested review of D17679: Remove extra mockscheduler call in abc_p2p_getavaaddr.
Wed, Feb 19, 17:01
Fabien accepted D17678: [Cashtab] Improve test match syntax for token actions.
Wed, Feb 19, 15:46
teamcity awarded D17659: [WIP] CI investigation a Like token.
Wed, Feb 19, 14:51
Fabien closed D17677: Improve reliability of abc_rpc_getavalancheproofs.
Wed, Feb 19, 13:46
Fabien committed rABC27cd694c2d62: Improve reliability of abc_rpc_getavalancheproofs (authored by Fabien).
Improve reliability of abc_rpc_getavalancheproofs
Wed, Feb 19, 13:46
Fabien closed D17675: [chronik] Consistently sync the validation queue in functional tests.
Wed, Feb 19, 13:46
Fabien committed rABC5db4ff6efcd3: [chronik] Consistently sync the validation queue in functional tests (authored by Fabien).
[chronik] Consistently sync the validation queue in functional tests
Wed, Feb 19, 13:46
teamcity awarded D17659: [WIP] CI investigation a Love token.
Wed, Feb 19, 13:45
teamcity awarded D17659: [WIP] CI investigation a Like token.
Wed, Feb 19, 10:13
Fabien accepted D17676: [chronik] implement server.version electrum method.

I reviewed the previous revision, the TODO is indeed done

Wed, Feb 19, 09:50
Fabien added inline comments to D17676: [chronik] implement server.version electrum method.
Wed, Feb 19, 09:48
teamcity awarded D17659: [WIP] CI investigation a Love token.
Wed, Feb 19, 09:38
Fabien requested review of D17677: Improve reliability of abc_rpc_getavalancheproofs.
Wed, Feb 19, 09:38
Fabien requested review of D17675: [chronik] Consistently sync the validation queue in functional tests.
Wed, Feb 19, 09:07
teamcity awarded D17659: [WIP] CI investigation a Like token.
Wed, Feb 19, 08:38

Tue, Feb 18

teamcity awarded D17659: [WIP] CI investigation a Love token.
Tue, Feb 18, 19:51
Fabien closed D17674: [avalanche] Deprecate the node availability score in the peerinfo RPC.
Tue, Feb 18, 19:50
Fabien committed rABCc78d17424346: [avalanche] Deprecate the node availability score in the peerinfo RPC (authored by Fabien).
[avalanche] Deprecate the node availability score in the peerinfo RPC
Tue, Feb 18, 19:50
Fabien requested review of D17674: [avalanche] Deprecate the node availability score in the peerinfo RPC.
Tue, Feb 18, 15:39
teamcity awarded D17659: [WIP] CI investigation a Like token.
Tue, Feb 18, 15:21
teamcity awarded D17659: [WIP] CI investigation a Love token.
Tue, Feb 18, 14:37
Fabien accepted D17673: test: Add explicit onion bind to p2p_permissions.
Tue, Feb 18, 14:07
teamcity awarded D17659: [WIP] CI investigation a Like token.
Tue, Feb 18, 11:00
Fabien accepted D17672: [chronik] Implement blockchain.scripthash.listunspent electrum method.
Tue, Feb 18, 10:15
Fabien closed D17671: Re-enable the getavaaddr_interval_test.
Tue, Feb 18, 09:47
Fabien committed rABC206472007eb6: Re-enable the getavaaddr_interval_test (authored by Fabien).
Re-enable the getavaaddr_interval_test
Tue, Feb 18, 09:47
Fabien requested review of D17671: Re-enable the getavaaddr_interval_test.
Tue, Feb 18, 09:06
Fabien closed D17669: [avalanche] Deprecate the peer availability score.
Tue, Feb 18, 08:24
Fabien committed rABC6eb30eafac84: [avalanche] Deprecate the peer availability score (authored by Fabien).
[avalanche] Deprecate the peer availability score
Tue, Feb 18, 08:24