User Details
- User Since
- Oct 7 2018, 09:05 (319 w, 4 d)
- Roles
- Administrator
- Slack Username
- Fabien
Yesterday
Tue, Nov 19
@bot preview-cashtab
Mon, Nov 18
See comment in D17138
Can you please squash D17139 ? I don't think it makes sense to have the bugfix and the test be separate diffs.
When you add a new feature like this you need to also add a test for the new feature so you demonstrate that it works as expected.
You can look at the functional tests in test/functional/chronik_*.py for test examples, and most likely you can extend one of the existing test instead of creating a new one.
Fri, Nov 15
@bot build-ibd
Thu, Nov 14
I think the backports are not correct for this diff, none of the netbase changes are from the listed commits afaict
Wed, Nov 13
Tue, Nov 12
@bot build-tsan
please include the mining_getblocktemplate_longpoll.py from D17113
You should go through the abc tests also. I use this a lot to speed up proof relay in tests
The commits are not the correct ones
Mon, Nov 11
Sat, Nov 9
Thu, Nov 7
Wed, Nov 6
Tue, Nov 5
Make sure the spam is processed after sending, otherwise it can be processed after the mocktime is increased and cause the getavaaddr test to fail.
Mon, Nov 4
Rebase on top of D17076 to fix the test
Uncomment tests
I will split out the test fix