Page MenuHomePhabricator

emack (Ethan Q)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 4 2021, 00:53 (180 w, 6 d)

Recent Activity

Fri, Feb 7

emack accepted D17649: [Cashtab] Improve form entry UX for agora listings.
Fri, Feb 7, 22:30
emack accepted D17641: [Cashtab] Support one-click redemptions for XECX.
Fri, Feb 7, 22:28
emack accepted D17647: [Cashtab] Patch price display in agora cancel modal.
Fri, Feb 7, 11:04
emack requested changes to D17641: [Cashtab] Support one-click redemptions for XECX.

Unable to redeem 7ish XECX for XEC, this is above dust so should be possible?

image.png (286×1 px, 19 KB)

Redemption worked fine for 10k XECX.

Fri, Feb 7, 10:01

Wed, Feb 5

emack accepted D17637: [ecash-agora] Move helper functions to get utxos for accepting and canceling agora txs from Cashtab to ecash-agora.
Wed, Feb 5, 12:05
emack accepted D17630: [ecash-agora] Do not include offers that have not been bought or canceled in historicOffers.
Wed, Feb 5, 02:47

Tue, Feb 4

emack requested changes to D17630: [ecash-agora] Do not include offers that have not been bought or canceled in historicOffers.

image.png (68×317 px, 6 KB)

Can you provide some context on how to validate this output from the script above and that it is indeed excluding the not-bought or cancelled offers?

Tue, Feb 4, 13:38

Mon, Feb 3

emack accepted D17627: [Cashtab] Make sure hide balance toggle also hides XECX balance.
Mon, Feb 3, 01:50
emack accepted D17628: [Cashtab] Do not wordbreak break-all for XECX summaries.
Mon, Feb 3, 01:46
emack accepted D17625: [Cashtab] Always show send button on send screen.
Mon, Feb 3, 01:43
emack added a comment to D17625: [Cashtab] Always show send button on send screen.

what is the browser / device here?

Ubuntu 22.04 / Chrome 125.0.6422.112

Mon, Feb 3, 01:43

Sun, Feb 2

emack requested changes to D17626: [Cashtab] Show close modal if window fails to close programmatically.

Tested on iOS Safari 18.1.1 - after paying in cashtab.com it automatically routes back to the paybutton page with the bell and then goes back to the original wp article that triggered it. I'm not seeing the reported issue where it stays on Cashtab.com.

Sun, Feb 2, 05:51
emack requested changes to D17625: [Cashtab] Always show send button on send screen.

On extension the Send button is aligned left, which is correct but the rest of the component is overflowing off to the right as per current behavior. Makes the Send button almost look like a pop up not to mention it covers the labels beneath it.

image.png (1×627 px, 99 KB)

Sun, Feb 2, 05:00
emack accepted D17624: [Cashtab] Patch button css.
Sun, Feb 2, 03:36

Thu, Jan 30

emack accepted D17608: [Cashtab] Support buying agora offers above spot, within reason.
Thu, Jan 30, 05:56

Sun, Jan 26

emack accepted D17593: [Cashtab] Change default setting for camera auto-open.
Sun, Jan 26, 11:05

Sat, Jan 25

emack accepted D17591: [Cashtab] Reduce tx autoclose time from 5s to 2s.
Sat, Jan 25, 08:57

Jan 21 2025

emack accepted D17571: [Cashtab] Make sure selectedOffer cannot be undefined after a ws update.
Jan 21 2025, 13:16

Jan 18 2025

emack accepted D17560: [Cashtab] Disable claim button while we wait for server response.
Jan 18 2025, 10:27
emack accepted D17559: [Cashtab] Rewards screen to typescript.
Jan 18 2025, 04:38
emack accepted D17558: [Cashtab] Improve wallet select behavior on wallets screen.
Jan 18 2025, 04:27
emack accepted D17557: [Cashtab] Convert wallet management screen to typescript.
Jan 18 2025, 04:22

Jan 17 2025

emack added a comment to D17549: [Cashtab] Patch render logic for spinner.

I assume the flakiness of the test you're referring to is when the int test is waiting for the spinner to disappear but it doesn't, and the await waitFor() call just hangs there holding up the entire test suite?

Jan 17 2025, 08:20
emack accepted D17552: [Cashtab] Lock UI and disable keyboard input while user switches wallets.
Jan 17 2025, 08:16
emack accepted D17551: [Cashtab] Do not double call updateCashtabState on wallet change.
Jan 17 2025, 08:10
emack accepted D17550: [Cashtab] Convert WalletLabel to ts.
Jan 17 2025, 08:07

Jan 16 2025

emack accepted D17545: [Cashtab] Patch bug in building token change outputs.
Jan 16 2025, 14:27
emack added a comment to D17540: [Cashtab] Show token qty and cumulative qty in any given agora offer in a tooltip.

image.png (172×542 px, 17 KB)

Actually, I did an actual check on the bundle size, one meg over 227 megs is negligible in the grand scheme of things. Non-issue unless the whole bundle is getting to a point where it may start to affect performance?

Jan 16 2025, 05:35
emack accepted D17540: [Cashtab] Show token qty and cumulative qty in any given agora offer in a tooltip.

Minor nit but tested all ok. Can confirm the transparency is not an issue on mobile screenshots, so must be Brave specific.

Jan 16 2025, 05:35

Jan 12 2025

emack accepted D17518: [Cashtab] Remove artifact useEffect from OrderBook.
Jan 12 2025, 05:47
emack accepted D17516: [ecash-herald] Show percent capacity in daily summaries.
Jan 12 2025, 02:03
emack accepted D17515: [Cashtab] Prevent creation of unacceptable agora offers.
Jan 12 2025, 01:59

Jan 10 2025

emack accepted D17504: [Cashtab] Show XECX balance.
Jan 10 2025, 13:59
emack requested changes to D17504: [Cashtab] Show XECX balance.
Jan 10 2025, 08:31
emack accepted D17506: [mock-chronik-client] Update README.
Jan 10 2025, 08:30
emack accepted D17505: [Cashtab] Patch CI by including mock-chronik-client.
Jan 10 2025, 05:08
emack accepted D17500: [Cashtab] Lazy loading for agora.

5 tokens to load on this page by default, then have a button to "load all" with a warning about how long it will take

SGTM

Jan 10 2025, 04:20
emack added a comment to D17500: [Cashtab] Lazy loading for agora.

I also did a manual test of cashtab-local-dev vs prod, on new wallets, and this diff loads slightly faster than prod, but are still taking over 2 minutes. Is that the expected behavior?

Jan 10 2025, 03:47
emack requested changes to D17500: [Cashtab] Lazy loading for agora.
Jan 10 2025, 03:18
emack accepted D17499: [Cashtab] useContext in OrderBook instead of prop drilling.
Jan 10 2025, 03:02

Jan 9 2025

emack accepted D17484: [Cashtab] Improve form entry and validation for listing tokens on agora.
Jan 9 2025, 10:19
emack requested changes to D17484: [Cashtab] Improve form entry and validation for listing tokens on agora.
Jan 9 2025, 06:22

Jan 7 2025

emack accepted D17482: [ecash-herald, Cashtab, explorer] chronik back to native1.
Jan 7 2025, 04:53

Jan 6 2025

emack accepted D17468: [Cashtab] Bring back noisy test logs if not in CI.
Jan 6 2025, 08:28
emack accepted D17466: [Cashtab] Prevent agora buys of offers above spot.
Jan 6 2025, 03:46
emack requested changes to D17466: [Cashtab] Prevent agora buys of offers above spot.
Jan 6 2025, 01:48

Jan 3 2025

emack accepted D17459: [Cashtab] [bugfix] Patch genesis supply validation for ALP tokens in create token form and ensure large number input fields are string.
Jan 3 2025, 05:57
emack requested changes to D17459: [Cashtab] [bugfix] Patch genesis supply validation for ALP tokens in create token form and ensure large number input fields are string.

Remove SlpDecimals import in Inputs.tsx to get the build working

Jan 3 2025, 03:00

Jan 2 2025

emack requested changes to D17459: [Cashtab] [bugfix] Patch genesis supply validation for ALP tokens in create token form and ensure large number input fields are string.
Jan 2 2025, 22:34
emack accepted D17450: [cashtab] Remove the avalanche finalized message/icon in the tx history expanded area.
Jan 2 2025, 10:33

Jan 1 2025

emack accepted D17445: [cashtab] Don't open agora offers on a new tab.

@bytesofman - as a side note, current versions of major browsers are all automatically assuming rel="noopener noreferrer" when opening links in a new window.

Jan 1 2025, 10:20
emack accepted D17444: [e.cash] Add clarificatio to XECX link page.
Jan 1 2025, 01:48
emack accepted D17443: [Cashtab] Improve price precision for Agora spot prices.
Jan 1 2025, 00:00

Dec 31 2024

emack accepted D17438: [Cashtab] Allow typed input for agora quantity selection.
Dec 31 2024, 23:44
emack requested changes to D17438: [Cashtab] Allow typed input for agora quantity selection.
Dec 31 2024, 01:49

Dec 30 2024

emack accepted D17423: [CI] Use recursive deps in CI builds.
Dec 30 2024, 11:17
emack requested changes to D17426: [Cashtab] Do not show wild-ass agora offers in OrderBook.

No issues on a technical level, but philosophically, I feel this is overreaching on Cashtab's part. There are valid use cases where the seller is essentially setting this as a limit order, to be sold at their target price. I know scammers are leveraging this but implementing this diff means all etoken prices would only move in controlled increments, which goes against the DEX mantra. Also none of the mainstream DEXs do this either.

Dec 30 2024, 11:13

Dec 29 2024

emack accepted D17416: [Cashtab] No more utils folder.
Dec 29 2024, 07:42
emack accepted D17402: [Cashtab] Allow user to sort Agora offers by offer count.
Dec 29 2024, 07:38
emack added inline comments to D17414: [e.cash] Add XECX to use ecash page.
Dec 29 2024, 00:08
emack added a comment to D17402: [Cashtab] Allow user to sort Agora offers by offer count.

Also the first toggle's functionality being different to the bottom 2 should be more obvious, like using Tabs for Buy/Manage and toggles for sorting. Or simply a dropdown for sorting so you don't end up with 5 toggles for 5 sorting options.

image.png (251×561 px, 14 KB)

Dec 29 2024, 00:04
emack requested changes to D17402: [Cashtab] Allow user to sort Agora offers by offer count.
Dec 29 2024, 00:01

Dec 28 2024

emack accepted D17394: [Cashtab] Convert Etokens screen to ts.
Dec 28 2024, 23:26

Dec 25 2024

emack accepted D17395: [Cashtab] Link to Cashtab token page instead of explorer for NFTs in a collection.
Dec 25 2024, 00:03
emack requested changes to D17394: [Cashtab] Convert Etokens screen to ts.
Dec 25 2024, 00:01

Dec 24 2024

emack accepted D17391: [Cashtab] Add toggle switch to show Agora prices in XEC or fiat.
Dec 24 2024, 01:09

Dec 23 2024

emack accepted D17385: [Cashtab] Improve portability of getFormattedFiatPrice.
Dec 23 2024, 01:44
emack accepted D17386: [Cashtab] Upgrade BigNumber.js.
Dec 23 2024, 01:41

Dec 22 2024

emack accepted D17383: [Cashtab] Use user modal confirmation settings for minting tokens.
Dec 22 2024, 09:46

Dec 20 2024

emack accepted D17357: [Cashtab] Do not airdrop XEC to agora scripts.
Dec 20 2024, 10:09
emack accepted D17378: [mock-chronik-client] Cache bust dockerfile deployment.
Dec 20 2024, 03:44
emack accepted D17376: [chronik-client] CI patch test.
Dec 20 2024, 03:24
emack requested changes to D17357: [Cashtab] Do not airdrop XEC to agora scripts.
Dec 20 2024, 02:17

Dec 17 2024

emack accepted D17340: [Cashtab] Parse tx history async to resolve UI lock issue on homescreen.
Dec 17 2024, 08:23

Dec 16 2024

emack requested changes to D17340: [Cashtab] Parse tx history async to resolve UI lock issue on homescreen.

confirm there that load times are significantly improved for wallets with Agora txs

Dec 16 2024, 04:51
emack accepted D17353: [Cashtab] Convert Home screen to typescript.
Dec 16 2024, 00:27

Dec 15 2024

emack requested changes to D17353: [Cashtab] Convert Home screen to typescript.
Dec 15 2024, 21:07
emack accepted D17351: [ecash-herald] Correct upgraded mock chronik client in script.
Dec 15 2024, 20:42

Dec 12 2024

emack accepted D17332: [mock-chronik-client] implement ts.
Dec 12 2024, 02:01

Dec 11 2024

emack requested changes to D17332: [mock-chronik-client] implement ts.
Dec 11 2024, 10:27
emack accepted D15631: [chronik-client] Add support for validate-tx endpoint to ChronikClientNode.
Dec 11 2024, 01:52

Dec 10 2024

emack accepted D17326: [Cashtab] Convert airdrop screen and deps to ts.
Dec 10 2024, 08:13
emack requested changes to D15631: [chronik-client] Add support for validate-tx endpoint to ChronikClientNode.
Dec 10 2024, 08:07
emack accepted D17328: [token-server] Bump free xec from 42 to 88.
Dec 10 2024, 08:02
emack accepted D17318: [Cashtab] Convert Tx screen and its deps to typescript.
Dec 10 2024, 07:57

Dec 8 2024

emack requested changes to D17318: [Cashtab] Convert Tx screen and its deps to typescript.
Dec 8 2024, 09:34
emack accepted D17317: [monorepo] Update dockerfiles that build-wasm to include explorer.
Dec 8 2024, 03:04

Dec 7 2024

emack accepted D17311: Revert "Revert "[Cashtab] Convert wallet context to ts"".
Dec 7 2024, 23:16
emack accepted D17310: [Cashtab] Convert TxHistory.js to ts.
Dec 7 2024, 23:02
emack accepted D17309: [Cashtab] Reduce tx history rendering.

There's a 3 second lag to scrolling on this test site. Unlikely to be caused by this diff and I guess we haven't had a diff that necessitated the scrolling of tx history but it is a material issue.

Dec 7 2024, 22:59

Dec 5 2024

emack accepted D17288: [Cashtab] Convert wallet context to ts.
Dec 5 2024, 21:08
emack requested changes to D17288: [Cashtab] Convert wallet context to ts.
Dec 5 2024, 14:46
emack accepted D17293: [ecash-herald] Tighten up daily summary msgs.
Dec 5 2024, 14:18
emack accepted D17291: [Cashtab] Remove swap screen.

FWIW - The widget is working in prod for me

image.png (1×871 px, 66 KB)

Dec 5 2024, 00:19

Dec 4 2024

emack accepted D17289: [Cashtab] Update PWA splash screen colors.
Dec 4 2024, 05:50

Dec 3 2024

emack accepted D17279: [mock-chronik-client] Add new dummy method to allow Agora construction with MockChronikClient.
Dec 3 2024, 07:35
emack accepted D17278: [Cashtab] Standardize mnemonic validation error msg.
Dec 3 2024, 07:32
emack accepted D17273: [token-server] Bump icon upload byte ceiling.
Dec 3 2024, 07:30

Dec 2 2024

emack accepted D17271: [Cashtab] Make agora tiles more useful.
Dec 2 2024, 06:14
emack requested changes to D17271: [Cashtab] Make agora tiles more useful.
Dec 2 2024, 00:13