Page MenuHomePhabricator

emack (Ethan Q)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 4 2021, 00:53 (218 w, 5 d)

Recent Activity

Jul 31 2025

emack requested changes to D18437: [chronik-cache] Init chronik-cache in monorepo.

I'm not see any tests? Have a look at other chronik-client mocks and tests in the repo. There are also discrete methods like the txid sorting function that can be easily unit tested too.

Jul 31 2025, 11:24

Jul 30 2025

emack accepted D18427: [e.cash] Make capitalizations more consistent on build page.
Jul 30 2025, 06:07

Jul 29 2025

emack accepted D18426: [Cashtab] Convert Home tests to ts.
Jul 29 2025, 23:25
emack accepted D18423: [Cashtab] Convert Header tests to tsx.
Jul 29 2025, 12:18

Jul 25 2025

emack accepted D18415: [Cashtab] Convert another test file to ts.
Jul 25 2025, 12:40

Jul 20 2025

emack accepted D18387: [Cashtab] Convert CreateTokenForm test to tsx.
Jul 20 2025, 05:49
emack accepted D18386: [Cashtab] Convert CreateToken test to ts.
Jul 20 2025, 05:42
emack accepted D18384: [cashtab-faucet, ecash-wallet, ecash-lib] Implement ecash-wallet in cashtab-faucet and make requisite mvp improvements.
Jul 20 2025, 05:33

Jul 19 2025

emack accepted D18383: [ecash-wallet] Add Dockerfile for CI deployments.
Jul 19 2025, 14:17
emack requested changes to D18385: [chronik-client] Add more helpful error msg for the case of a user calling broadcastTx with broadcastTxs input.
Jul 19 2025, 14:15
emack accepted D18385: [chronik-client] Add more helpful error msg for the case of a user calling broadcastTx with broadcastTxs input.

Probably needs similar helpful error handling in broadcastTxs if a non-array is supplied there

Jul 19 2025, 14:07

Jul 18 2025

emack accepted D18382: [Cashtab] Select 99% of balance if user cannot afford the whole agora offer.
Jul 18 2025, 16:54
emack accepted D18381: [Cashtab] Catch any errors that come up in creating the agora partial acceptTx.
Jul 18 2025, 03:16
emack requested changes to D18382: [Cashtab] Select 99% of balance if user cannot afford the whole agora offer.

Hitting Max, which shows 99% of max affordable amount as expected, on a wallet balance of 47.64 XEC, is still getting the insufficient utxos error

image.png (1×1 px, 348 KB)

Jul 18 2025, 03:12

Jul 16 2025

emack accepted D18378: [cashtab] Consistently use appConfig.ticker instead of hardcoded 'XEC'.
Jul 16 2025, 14:52
emack accepted D18372: [Cashtab] Convert contacts component test to ts.
Jul 16 2025, 02:59
emack accepted D18373: [ecash-herald] Parse new miner.
Jul 16 2025, 02:45

Jul 15 2025

emack accepted D18361: [Cashtab] Convert Config tests to ts.
Jul 15 2025, 07:45

Jul 14 2025

emack accepted D18360: [Cashtab] Convert qr tests to typescript.
Jul 14 2025, 14:00
emack accepted D18358: [token-server, cashtab-faucet] Split token-server into two apps for faucet and token icon mgmt.
Jul 14 2025, 12:11
emack accepted D18356: [Cashtab] Convert CustomIcons from js to ts.
Jul 14 2025, 11:38

Jul 9 2025

emack accepted D18342: [Cashtab] Add quick select buttons for agora offer buy qty and do not render unbuyable offers.
Jul 9 2025, 12:26
emack requested changes to D18342: [Cashtab] Add quick select buttons for agora offer buy qty and do not render unbuyable offers.

There's the unintended consequence where newly onboarded users with empty or low balance wallets will just see Agora with most if not all offers filtered out, giving the impression of a ghost town. IMO that's worse than the UX improvement.

Jul 9 2025, 04:57
emack accepted D18341: [Cashtab] Migrate Airdrop component tests to ts.
Jul 9 2025, 04:15
emack accepted D18328: [Cashtab, cashtab-connect] Init an npm module to facilitate browser extension interaction in react apps.
Jul 9 2025, 03:52

Jul 6 2025

emack requested changes to D18328: [Cashtab, cashtab-connect] Init an npm module to facilitate browser extension interaction in react apps.
  • From memory these eslint warnings might cause issues with CI when propagating to prod

image.png (347×1 px, 58 KB)

Jul 6 2025, 12:52

Jul 4 2025

emack accepted D18322: [Cashtab] Convert agora tests to ts.
Jul 4 2025, 05:59

Jun 25 2025

emack accepted D18289: [Cashtab] Better handling of edge case utxo selection.
Jun 25 2025, 03:17
emack accepted D18288: [Cashtab] Code splitting only in prod.
Jun 25 2025, 03:05

Jun 18 2025

emack accepted D18262: [mock-chronik-client] Add support for txid ws subscriptions.
Jun 18 2025, 01:42

Jun 15 2025

emack accepted D18133: [Cashtab] Add test for parsing firma redeem tx.
Jun 15 2025, 05:52

Jun 9 2025

emack accepted D18227: [Cashtab] Update tg channel ref in support msg.
Jun 9 2025, 02:30
emack accepted D18226: [Cashtab] Add code splitting to improve initial load time.
Jun 9 2025, 02:29

Jun 8 2025

emack accepted D18225: Revert "[Cashtab] Add code splitting to improve initial load time".
Jun 8 2025, 09:59

Jun 7 2025

emack accepted D18219: [Cashtab] Add code splitting to improve initial load time.
Jun 7 2025, 06:32

Jun 6 2025

emack accepted D18214: [Cashtab] Use chrome API instead of extensionizer.

Unrelated to diff, but a few observations

Jun 6 2025, 14:50
emack accepted D18212: [Cashtab] Do not use alert modal for agora.cash.
Jun 6 2025, 02:34

Jun 5 2025

emack accepted D18203: [Cashtab] Update rendering for fees on FIRMA-USDT redeems.
Jun 5 2025, 07:25

Jun 4 2025

emack accepted D18196: [Cashtab] Add a component to handle external links.
Jun 4 2025, 14:48
emack requested changes to D18196: [Cashtab] Add a component to handle external links.
Jun 4 2025, 06:01
emack accepted D18197: [token-server] Allow icon uploads from cashtab.io.
Jun 4 2025, 05:54
emack requested changes to D18196: [Cashtab] Add a component to handle external links.

I assume the error in token icon submission is because cashtab dot io is not whitelisted with the token icon server?

image.png (133×418 px, 12 KB)

Jun 4 2025, 00:47

May 9 2025

emack added a comment to D18066: [cashtab] Header UI overhaul.

In mobile mode, this new header now takes up 30% of the UI. I know it moves off the screen when scrolling but it reappears with navigating to a new component. I think tooltips like Staking and Savings should be able to be closed or minimized by the user? Or perhaps have an onHover icon?
Also the Learn more link on mobile screens are somewhat harder to click (maybe I just have fat fingers) - perhaps make the whole row a link?

May 9 2025, 09:26
emack accepted D18069: [Cashtab] Update dep per msg seen during build.
May 9 2025, 09:06
emack added a comment to D18069: [Cashtab] Update dep per msg seen during build.

are these the warnings you're referring to when npm run build? If so I'm still seeing them

image.png (361×1 px, 88 KB)

May 9 2025, 04:26
emack accepted D18061: [Cashtab] Allow user to receive specified amount of XEC or FIRMA on Receive page.
May 9 2025, 04:08

May 8 2025

emack requested changes to D18061: [Cashtab] Allow user to receive specified amount of XEC or FIRMA on Receive page.

If you input a large enough number Cashtab crashes with a WSOD and spits out a range error on console. Not a big issue but rather unsightly. The other send amount inputs throughout the app gracefully spits out a Unable to parse sendAmount as a number UI error instead of sharting.

image.png (413×640 px, 39 KB)

May 8 2025, 12:51

May 4 2025

emack accepted D18044: [Cashtab] Load FIRMA agora page with price in fiat instead of XEC.
May 4 2025, 02:14
emack added a comment to D18044: [Cashtab] Load FIRMA agora page with price in fiat instead of XEC.

@bot preview-cashtab

May 4 2025, 02:03

May 2 2025

emack added inline comments to D18041: [Cashtab] Set ConnectionStrategy.ClosestFirst for initialization.
May 2 2025, 00:12

Apr 22 2025

emack accepted D17949: [chronik-client] Add handling for WebSocket closure .
Apr 22 2025, 01:15

Apr 20 2025

emack added inline comments to D17949: [chronik-client] Add handling for WebSocket closure .
Apr 20 2025, 00:20

Apr 19 2025

emack added inline comments to D17949: [chronik-client] Add handling for WebSocket closure .
Apr 19 2025, 23:46

Apr 18 2025

emack requested changes to D17949: [chronik-client] Add handling for WebSocket closure .
Apr 18 2025, 12:14

Apr 17 2025

emack accepted D17941: [cashtab] CSS tweak for default desktop agora view.
Apr 17 2025, 04:44

Apr 3 2025

emack accepted D17884: [chronik.e.cash] enable trailing slashes for consistent URL structure.

Trailing slash now added when navigating to various pages

image.png (137×515 px, 13 KB)

Apr 3 2025, 07:25

Mar 30 2025

emack accepted D17875: [token-server] Bump recaptcha score.
Mar 30 2025, 23:56

Mar 21 2025

emack accepted D17841: [ecash-herald] Improve miner parsing.
Mar 21 2025, 03:03

Mar 18 2025

emack accepted D17814: [chronik-client] Patch failoverProxy to recognize another type of server failure.
Mar 18 2025, 04:07

Mar 17 2025

emack committed rABCd366dd0addf2: [ecash-lib-wasm] Add readme with installation instructions (authored by emack).
[ecash-lib-wasm] Add readme with installation instructions
Mar 17 2025, 01:30
emack closed D17774: [ecash-lib-wasm] Add readme with installation instructions.
Mar 17 2025, 01:30

Mar 16 2025

emack updated the diff for D17774: [ecash-lib-wasm] Add readme with installation instructions.

updated readme

Mar 16 2025, 13:29
emack updated the diff for D17774: [ecash-lib-wasm] Add readme with installation instructions.

updated readme

Mar 16 2025, 00:30

Mar 14 2025

emack updated the diff for D17774: [ecash-lib-wasm] Add readme with installation instructions.

Updated readme

Mar 14 2025, 05:19
emack accepted D17804: [Cashtab] Use ecash-lib for HDNode.
Mar 14 2025, 05:07

Mar 13 2025

emack updated the diff for D17774: [ecash-lib-wasm] Add readme with installation instructions.

Linked docker installation guide

Mar 13 2025, 06:01
emack accepted D17782: [ecash-lib] Allow use of .only in mocha test files.
Mar 13 2025, 05:52

Mar 12 2025

emack accepted D17775: [Cashtab] Show XECX sweeper balance and notice if user redemption will not be instant.
Mar 12 2025, 04:05
emack requested changes to D17782: [ecash-lib] Allow use of .only in mocha test files.

Add .only to a test file in ecash-lib, run arc lint, get a lint error, remove it, all good, npm test with a test using .only and only that test runs

Mar 12 2025, 04:04
emack requested changes to D17775: [Cashtab] Show XECX sweeper balance and notice if user redemption will not be instant.
Mar 12 2025, 02:11

Mar 11 2025

emack requested review of D17774: [ecash-lib-wasm] Add readme with installation instructions.
Mar 11 2025, 04:53
emack accepted D17756: [Cashtab] Add click-outside-area closing effect for NavWrapper using event bubbling.

Tested all ok across chrome and firefox.

Mar 11 2025, 04:17

Mar 8 2025

emack accepted D17755: [monorepo] eslint all the js with a single version-pinned flat config.
Mar 8 2025, 04:37

Mar 7 2025

emack added a comment to D17756: [Cashtab] Add click-outside-area closing effect for NavWrapper using event bubbling.

and arc diff the next update without the linting bypass pls

Mar 7 2025, 02:38
emack requested changes to D17756: [Cashtab] Add click-outside-area closing effect for NavWrapper using event bubbling.
Mar 7 2025, 02:34
emack added a comment to D17755: [monorepo] eslint all the js with a single version-pinned flat config.

Regarding the mypy issue, what are your mypy and python versions ?

Mar 7 2025, 02:11

Mar 6 2025

emack requested changes to D17755: [monorepo] eslint all the js with a single version-pinned flat config.

/modules/chronik-client/.prettierignore and /.prettierignore be removed as it's similar to .eslintignore

Mar 6 2025, 07:21
emack requested changes to D17756: [Cashtab] Add click-outside-area closing effect for NavWrapper using event bubbling.

Implemented a click-outside closing mechanism for the settings window

where is this implemented? I'm not seeing event bubbling above, only the removal of the redundant useEffect.

Mar 6 2025, 06:58

Mar 4 2025

emack accepted D17739: [Cashtab] Validate agora accepts vs user balance.
Mar 4 2025, 00:26
emack accepted D17738: [Cashtab] Do not reset forms on fiat price change unless price is unavailable.
Mar 4 2025, 00:19
emack accepted D17740: [Cashtab] Make ALP the default for token creation.
Mar 4 2025, 00:14

Mar 1 2025

emack accepted D17726: [Cashtab] Include FIRMA in balance header and fiat balance.
Mar 1 2025, 07:30
emack accepted D17731: [ecash-herald] Show the date of the activity in the msg header.
Mar 1 2025, 07:17

Feb 28 2025

emack accepted D17701: [Cashtab] Support one-click redemptions.

As per tg, noting the "minor price change in between clicking list and the listing getting published" issue that is for another diff, perhaps a relist on latest price button or some sort.

image.png (757×604 px, 919 KB)

Feb 28 2025, 12:54

Feb 27 2025

emack added a comment to D17701: [Cashtab] Support one-click redemptions.

v3.14.0 on the netlify instance after multiple refreshes

Feb 27 2025, 23:00
emack added a comment to D17701: [Cashtab] Support one-click redemptions.

Consider a 100% 50% 25% button above the Redeem button similar to binance. Easier for tax calculations when people are just partially selling rounded percentages.

Feb 27 2025, 11:39

Feb 7 2025

emack accepted D17649: [Cashtab] Improve form entry UX for agora listings.
Feb 7 2025, 22:30
emack accepted D17641: [Cashtab] Support one-click redemptions for XECX.
Feb 7 2025, 22:28
emack accepted D17647: [Cashtab] Patch price display in agora cancel modal.
Feb 7 2025, 11:04
emack requested changes to D17641: [Cashtab] Support one-click redemptions for XECX.

Unable to redeem 7ish XECX for XEC, this is above dust so should be possible?

image.png (286×1 px, 19 KB)

Redemption worked fine for 10k XECX.

Feb 7 2025, 10:01

Feb 5 2025

emack accepted D17637: [ecash-agora] Move helper functions to get utxos for accepting and canceling agora txs from Cashtab to ecash-agora.
Feb 5 2025, 12:05
emack accepted D17630: [ecash-agora] Do not include offers that have not been bought or canceled in historicOffers.
Feb 5 2025, 02:47

Feb 4 2025

emack requested changes to D17630: [ecash-agora] Do not include offers that have not been bought or canceled in historicOffers.

image.png (68×317 px, 6 KB)

Can you provide some context on how to validate this output from the script above and that it is indeed excluding the not-bought or cancelled offers?

Feb 4 2025, 13:38

Feb 3 2025

emack accepted D17627: [Cashtab] Make sure hide balance toggle also hides XECX balance.
Feb 3 2025, 01:50
emack accepted D17628: [Cashtab] Do not wordbreak break-all for XECX summaries.
Feb 3 2025, 01:46
emack accepted D17625: [Cashtab] Always show send button on send screen.
Feb 3 2025, 01:43
emack added a comment to D17625: [Cashtab] Always show send button on send screen.

what is the browser / device here?

Ubuntu 22.04 / Chrome 125.0.6422.112

Feb 3 2025, 01:43

Feb 2 2025

emack requested changes to D17626: [Cashtab] Show close modal if window fails to close programmatically.

Tested on iOS Safari 18.1.1 - after paying in cashtab.com it automatically routes back to the paybutton page with the bell and then goes back to the original wp article that triggered it. I'm not seeing the reported issue where it stays on Cashtab.com.

Feb 2 2025, 05:51
emack requested changes to D17625: [Cashtab] Always show send button on send screen.

On extension the Send button is aligned left, which is correct but the rest of the component is overflowing off to the right as per current behavior. Makes the Send button almost look like a pop up not to mention it covers the labels beneath it.

image.png (1×627 px, 99 KB)

Feb 2 2025, 05:00
emack accepted D17624: [Cashtab] Patch button css.
Feb 2 2025, 03:36