User Details
- User Since
- Sep 4 2021, 00:53 (176 w, 1 d)
Yesterday
Fri, Jan 17
I assume the flakiness of the test you're referring to is when the int test is waiting for the spinner to disappear but it doesn't, and the await waitFor() call just hangs there holding up the entire test suite?
Thu, Jan 16
Actually, I did an actual check on the bundle size, one meg over 227 megs is negligible in the grand scheme of things. Non-issue unless the whole bundle is getting to a point where it may start to affect performance?
Minor nit but tested all ok. Can confirm the transparency is not an issue on mobile screenshots, so must be Brave specific.
Sun, Jan 12
Fri, Jan 10
5 tokens to load on this page by default, then have a button to "load all" with a warning about how long it will take
SGTM
I also did a manual test of cashtab-local-dev vs prod, on new wallets, and this diff loads slightly faster than prod, but are still taking over 2 minutes. Is that the expected behavior?
Thu, Jan 9
Tue, Jan 7
Mon, Jan 6
Fri, Jan 3
Remove SlpDecimals import in Inputs.tsx to get the build working
Thu, Jan 2
Wed, Jan 1
@bytesofman - as a side note, current versions of major browsers are all automatically assuming rel="noopener noreferrer" when opening links in a new window.
Tue, Dec 31
Mon, Dec 30
No issues on a technical level, but philosophically, I feel this is overreaching on Cashtab's part. There are valid use cases where the seller is essentially setting this as a limit order, to be sold at their target price. I know scammers are leveraging this but implementing this diff means all etoken prices would only move in controlled increments, which goes against the DEX mantra. Also none of the mainstream DEXs do this either.
Sun, Dec 29
Also the first toggle's functionality being different to the bottom 2 should be more obvious, like using Tabs for Buy/Manage and toggles for sorting. Or simply a dropdown for sorting so you don't end up with 5 toggles for 5 sorting options.
Sat, Dec 28
Wed, Dec 25
Tue, Dec 24
Mon, Dec 23
Sun, Dec 22
Dec 20 2024
Dec 17 2024
Dec 16 2024
confirm there that load times are significantly improved for wallets with Agora txs
Dec 15 2024
Dec 12 2024
Dec 11 2024
Dec 10 2024
Dec 8 2024
Dec 7 2024
There's a 3 second lag to scrolling on this test site. Unlikely to be caused by this diff and I guess we haven't had a diff that necessitated the scrolling of tx history but it is a material issue.
Dec 5 2024
FWIW - The widget is working in prod for me
Dec 4 2024
Dec 3 2024
Dec 2 2024
Dec 1 2024
Nov 30 2024
Nov 29 2024
In these situations I feel it may be more intuitive if you leave the toggle there but simply disable it (maybe greyed out to indicate lock status?) so that it's clear to the user this is SLP only. Otherwise they might be looking for the toggle they saw previously with no on screen hint as to why it's not there.
Nov 28 2024
Nov 27 2024
Nov 26 2024
Nov 25 2024
is the exclusion of non-send token txs on the basis that they're not a use case for QR payments?