Page MenuHomePhabricator

emack (Ethan Q)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 4 2021, 00:53 (176 w, 1 d)

Recent Activity

Yesterday

emack accepted D17560: [Cashtab] Disable claim button while we wait for server response.
Sat, Jan 18, 10:27
emack accepted D17559: [Cashtab] Rewards screen to typescript.
Sat, Jan 18, 04:38
emack accepted D17558: [Cashtab] Improve wallet select behavior on wallets screen.
Sat, Jan 18, 04:27
emack accepted D17557: [Cashtab] Convert wallet management screen to typescript.
Sat, Jan 18, 04:22

Fri, Jan 17

emack added a comment to D17549: [Cashtab] Patch render logic for spinner.

I assume the flakiness of the test you're referring to is when the int test is waiting for the spinner to disappear but it doesn't, and the await waitFor() call just hangs there holding up the entire test suite?

Fri, Jan 17, 08:20
emack accepted D17552: [Cashtab] Lock UI and disable keyboard input while user switches wallets.
Fri, Jan 17, 08:16
emack accepted D17551: [Cashtab] Do not double call updateCashtabState on wallet change.
Fri, Jan 17, 08:10
emack accepted D17550: [Cashtab] Convert WalletLabel to ts.
Fri, Jan 17, 08:07

Thu, Jan 16

emack accepted D17545: [Cashtab] Patch bug in building token change outputs.
Thu, Jan 16, 14:27
emack added a comment to D17540: [Cashtab] Show token qty and cumulative qty in any given agora offer in a tooltip.

image.png (172×542 px, 17 KB)

Actually, I did an actual check on the bundle size, one meg over 227 megs is negligible in the grand scheme of things. Non-issue unless the whole bundle is getting to a point where it may start to affect performance?

Thu, Jan 16, 05:35
emack accepted D17540: [Cashtab] Show token qty and cumulative qty in any given agora offer in a tooltip.

Minor nit but tested all ok. Can confirm the transparency is not an issue on mobile screenshots, so must be Brave specific.

Thu, Jan 16, 05:35

Sun, Jan 12

emack accepted D17518: [Cashtab] Remove artifact useEffect from OrderBook.
Sun, Jan 12, 05:47
emack accepted D17516: [ecash-herald] Show percent capacity in daily summaries.
Sun, Jan 12, 02:03
emack accepted D17515: [Cashtab] Prevent creation of unacceptable agora offers.
Sun, Jan 12, 01:59

Fri, Jan 10

emack accepted D17504: [Cashtab] Show XECX balance.
Fri, Jan 10, 13:59
emack requested changes to D17504: [Cashtab] Show XECX balance.
Fri, Jan 10, 08:31
emack accepted D17506: [mock-chronik-client] Update README.
Fri, Jan 10, 08:30
emack accepted D17505: [Cashtab] Patch CI by including mock-chronik-client.
Fri, Jan 10, 05:08
emack accepted D17500: [Cashtab] Lazy loading for agora.

5 tokens to load on this page by default, then have a button to "load all" with a warning about how long it will take

SGTM

Fri, Jan 10, 04:20
emack added a comment to D17500: [Cashtab] Lazy loading for agora.

I also did a manual test of cashtab-local-dev vs prod, on new wallets, and this diff loads slightly faster than prod, but are still taking over 2 minutes. Is that the expected behavior?

Fri, Jan 10, 03:47
emack requested changes to D17500: [Cashtab] Lazy loading for agora.
Fri, Jan 10, 03:18
emack accepted D17499: [Cashtab] useContext in OrderBook instead of prop drilling.
Fri, Jan 10, 03:02

Thu, Jan 9

emack accepted D17484: [Cashtab] Improve form entry and validation for listing tokens on agora.
Thu, Jan 9, 10:19
emack requested changes to D17484: [Cashtab] Improve form entry and validation for listing tokens on agora.
Thu, Jan 9, 06:22

Tue, Jan 7

emack accepted D17482: [ecash-herald, Cashtab, explorer] chronik back to native1.
Tue, Jan 7, 04:53

Mon, Jan 6

emack accepted D17468: [Cashtab] Bring back noisy test logs if not in CI.
Mon, Jan 6, 08:28
emack accepted D17466: [Cashtab] Prevent agora buys of offers above spot.
Mon, Jan 6, 03:46
emack requested changes to D17466: [Cashtab] Prevent agora buys of offers above spot.
Mon, Jan 6, 01:48

Fri, Jan 3

emack accepted D17459: [Cashtab] [bugfix] Patch genesis supply validation for ALP tokens in create token form and ensure large number input fields are string.
Fri, Jan 3, 05:57
emack requested changes to D17459: [Cashtab] [bugfix] Patch genesis supply validation for ALP tokens in create token form and ensure large number input fields are string.

Remove SlpDecimals import in Inputs.tsx to get the build working

Fri, Jan 3, 03:00

Thu, Jan 2

emack requested changes to D17459: [Cashtab] [bugfix] Patch genesis supply validation for ALP tokens in create token form and ensure large number input fields are string.
Thu, Jan 2, 22:34
emack accepted D17450: [cashtab] Remove the avalanche finalized message/icon in the tx history expanded area.
Thu, Jan 2, 10:33

Wed, Jan 1

emack accepted D17445: [cashtab] Don't open agora offers on a new tab.

@bytesofman - as a side note, current versions of major browsers are all automatically assuming rel="noopener noreferrer" when opening links in a new window.

Wed, Jan 1, 10:20
emack accepted D17444: [e.cash] Add clarificatio to XECX link page.
Wed, Jan 1, 01:48
emack accepted D17443: [Cashtab] Improve price precision for Agora spot prices.
Wed, Jan 1, 00:00

Tue, Dec 31

emack accepted D17438: [Cashtab] Allow typed input for agora quantity selection.
Tue, Dec 31, 23:44
emack requested changes to D17438: [Cashtab] Allow typed input for agora quantity selection.
Tue, Dec 31, 01:49

Mon, Dec 30

emack accepted D17423: [CI] Use recursive deps in CI builds.
Mon, Dec 30, 11:17
emack requested changes to D17426: [Cashtab] Do not show wild-ass agora offers in OrderBook.

No issues on a technical level, but philosophically, I feel this is overreaching on Cashtab's part. There are valid use cases where the seller is essentially setting this as a limit order, to be sold at their target price. I know scammers are leveraging this but implementing this diff means all etoken prices would only move in controlled increments, which goes against the DEX mantra. Also none of the mainstream DEXs do this either.

Mon, Dec 30, 11:13

Sun, Dec 29

emack accepted D17416: [Cashtab] No more utils folder.
Sun, Dec 29, 07:42
emack accepted D17402: [Cashtab] Allow user to sort Agora offers by offer count.
Sun, Dec 29, 07:38
emack added inline comments to D17414: [e.cash] Add XECX to use ecash page.
Sun, Dec 29, 00:08
emack added a comment to D17402: [Cashtab] Allow user to sort Agora offers by offer count.

Also the first toggle's functionality being different to the bottom 2 should be more obvious, like using Tabs for Buy/Manage and toggles for sorting. Or simply a dropdown for sorting so you don't end up with 5 toggles for 5 sorting options.

image.png (251×561 px, 14 KB)

Sun, Dec 29, 00:04
emack requested changes to D17402: [Cashtab] Allow user to sort Agora offers by offer count.
Sun, Dec 29, 00:01

Sat, Dec 28

emack accepted D17394: [Cashtab] Convert Etokens screen to ts.
Sat, Dec 28, 23:26

Wed, Dec 25

emack accepted D17395: [Cashtab] Link to Cashtab token page instead of explorer for NFTs in a collection.
Wed, Dec 25, 00:03
emack requested changes to D17394: [Cashtab] Convert Etokens screen to ts.
Wed, Dec 25, 00:01

Tue, Dec 24

emack accepted D17391: [Cashtab] Add toggle switch to show Agora prices in XEC or fiat.
Tue, Dec 24, 01:09

Mon, Dec 23

emack accepted D17385: [Cashtab] Improve portability of getFormattedFiatPrice.
Mon, Dec 23, 01:44
emack accepted D17386: [Cashtab] Upgrade BigNumber.js.
Mon, Dec 23, 01:41

Sun, Dec 22

emack accepted D17383: [Cashtab] Use user modal confirmation settings for minting tokens.
Sun, Dec 22, 09:46

Dec 20 2024

emack accepted D17357: [Cashtab] Do not airdrop XEC to agora scripts.
Dec 20 2024, 10:09
emack accepted D17378: [mock-chronik-client] Cache bust dockerfile deployment.
Dec 20 2024, 03:44
emack accepted D17376: [chronik-client] CI patch test.
Dec 20 2024, 03:24
emack requested changes to D17357: [Cashtab] Do not airdrop XEC to agora scripts.
Dec 20 2024, 02:17

Dec 17 2024

emack accepted D17340: [Cashtab] Parse tx history async to resolve UI lock issue on homescreen.
Dec 17 2024, 08:23

Dec 16 2024

emack requested changes to D17340: [Cashtab] Parse tx history async to resolve UI lock issue on homescreen.

confirm there that load times are significantly improved for wallets with Agora txs

Dec 16 2024, 04:51
emack accepted D17353: [Cashtab] Convert Home screen to typescript.
Dec 16 2024, 00:27

Dec 15 2024

emack requested changes to D17353: [Cashtab] Convert Home screen to typescript.
Dec 15 2024, 21:07
emack accepted D17351: [ecash-herald] Correct upgraded mock chronik client in script.
Dec 15 2024, 20:42

Dec 12 2024

emack accepted D17332: [mock-chronik-client] implement ts.
Dec 12 2024, 02:01

Dec 11 2024

emack requested changes to D17332: [mock-chronik-client] implement ts.
Dec 11 2024, 10:27
emack accepted D15631: [chronik-client] Add support for validate-tx endpoint to ChronikClientNode.
Dec 11 2024, 01:52

Dec 10 2024

emack accepted D17326: [Cashtab] Convert airdrop screen and deps to ts.
Dec 10 2024, 08:13
emack requested changes to D15631: [chronik-client] Add support for validate-tx endpoint to ChronikClientNode.
Dec 10 2024, 08:07
emack accepted D17328: [token-server] Bump free xec from 42 to 88.
Dec 10 2024, 08:02
emack accepted D17318: [Cashtab] Convert Tx screen and its deps to typescript.
Dec 10 2024, 07:57

Dec 8 2024

emack requested changes to D17318: [Cashtab] Convert Tx screen and its deps to typescript.
Dec 8 2024, 09:34
emack accepted D17317: [monorepo] Update dockerfiles that build-wasm to include explorer.
Dec 8 2024, 03:04

Dec 7 2024

emack accepted D17311: Revert "Revert "[Cashtab] Convert wallet context to ts"".
Dec 7 2024, 23:16
emack accepted D17310: [Cashtab] Convert TxHistory.js to ts.
Dec 7 2024, 23:02
emack accepted D17309: [Cashtab] Reduce tx history rendering.

There's a 3 second lag to scrolling on this test site. Unlikely to be caused by this diff and I guess we haven't had a diff that necessitated the scrolling of tx history but it is a material issue.

Dec 7 2024, 22:59

Dec 5 2024

emack accepted D17288: [Cashtab] Convert wallet context to ts.
Dec 5 2024, 21:08
emack requested changes to D17288: [Cashtab] Convert wallet context to ts.
Dec 5 2024, 14:46
emack accepted D17293: [ecash-herald] Tighten up daily summary msgs.
Dec 5 2024, 14:18
emack accepted D17291: [Cashtab] Remove swap screen.

FWIW - The widget is working in prod for me

image.png (1×871 px, 66 KB)

Dec 5 2024, 00:19

Dec 4 2024

emack accepted D17289: [Cashtab] Update PWA splash screen colors.
Dec 4 2024, 05:50

Dec 3 2024

emack accepted D17279: [mock-chronik-client] Add new dummy method to allow Agora construction with MockChronikClient.
Dec 3 2024, 07:35
emack accepted D17278: [Cashtab] Standardize mnemonic validation error msg.
Dec 3 2024, 07:32
emack accepted D17273: [token-server] Bump icon upload byte ceiling.
Dec 3 2024, 07:30

Dec 2 2024

emack accepted D17271: [Cashtab] Make agora tiles more useful.
Dec 2 2024, 06:14
emack requested changes to D17271: [Cashtab] Make agora tiles more useful.
Dec 2 2024, 00:13

Dec 1 2024

emack accepted D17262: [b58-ts] Set up CI publishing.
Dec 1 2024, 14:07
emack accepted D17270: [Cashtab] Stop showing [object Object] on agora offers yet to populate token cache info.
Dec 1 2024, 14:03
emack accepted D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Dec 1 2024, 14:00

Nov 30 2024

emack accepted D17219: [Cashtab] Support send token txs with bip21 query strings.
Nov 30 2024, 10:23
emack accepted D17240: [Cashtab] Do not show ALP and SLP options for NFT mints.
Nov 30 2024, 10:22

Nov 29 2024

emack requested changes to D17240: [Cashtab] Do not show ALP and SLP options for NFT mints.

In these situations I feel it may be more intuitive if you leave the toggle there but simply disable it (maybe greyed out to indicate lock status?) so that it's clear to the user this is SLP only. Otherwise they might be looking for the toggle they saw previously with no on screen hint as to why it's not there.

Nov 29 2024, 10:30
emack accepted D17241: [Cashtab] Update style element to match redesign.
Nov 29 2024, 10:25
emack requested changes to D17219: [Cashtab] Support send token txs with bip21 query strings.
Nov 29 2024, 10:24

Nov 28 2024

emack accepted D17203: [cashtab] Support agora txs for ALP tokens.
Nov 28 2024, 02:36

Nov 27 2024

emack requested changes to D17203: [cashtab] Support agora txs for ALP tokens.
Nov 27 2024, 11:00
emack accepted D17207: [Cashtab] Convert Send screen and some deps to ts.
Nov 27 2024, 10:24
emack accepted D17186: [cashtab] UI Overhaul.
Nov 27 2024, 10:13

Nov 26 2024

emack accepted D17202: [ecash-herald] Remember to pass the staking info param for daily summary msg.
Nov 26 2024, 13:32
emack requested changes to D17202: [ecash-herald] Remember to pass the staking info param for daily summary msg.
Nov 26 2024, 10:33
emack requested changes to D17186: [cashtab] UI Overhaul.
Nov 26 2024, 10:31

Nov 25 2024

emack accepted D17196: [bip21] Introduce a spec for supporting simple token send txs.
Nov 25 2024, 03:57
emack accepted D17195: [ecash-herald] Add network staking info to daily summaries.
Nov 25 2024, 01:45
emack added a comment to D17196: [bip21] Introduce a spec for supporting simple token send txs.

is the exclusion of non-send token txs on the basis that they're not a use case for QR payments?

Nov 25 2024, 01:28