Page MenuHomePhabricator

emack (Ethan Q)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 4 2021, 00:53 (185 w, 3 d)

Recent Activity

Fri, Mar 21

emack accepted D17841: [ecash-herald] Improve miner parsing.
Fri, Mar 21, 03:03

Tue, Mar 18

emack accepted D17814: [chronik-client] Patch failoverProxy to recognize another type of server failure.
Tue, Mar 18, 04:07

Mon, Mar 17

emack committed rABCd366dd0addf2: [ecash-lib-wasm] Add readme with installation instructions (authored by emack).
[ecash-lib-wasm] Add readme with installation instructions
Mon, Mar 17, 01:30
emack closed D17774: [ecash-lib-wasm] Add readme with installation instructions.
Mon, Mar 17, 01:30

Sun, Mar 16

emack updated the diff for D17774: [ecash-lib-wasm] Add readme with installation instructions.

updated readme

Sun, Mar 16, 13:29
emack updated the diff for D17774: [ecash-lib-wasm] Add readme with installation instructions.

updated readme

Sun, Mar 16, 00:30

Fri, Mar 14

emack updated the diff for D17774: [ecash-lib-wasm] Add readme with installation instructions.

Updated readme

Fri, Mar 14, 05:19
emack accepted D17804: [Cashtab] Use ecash-lib for HDNode.
Fri, Mar 14, 05:07

Thu, Mar 13

emack updated the diff for D17774: [ecash-lib-wasm] Add readme with installation instructions.

Linked docker installation guide

Thu, Mar 13, 06:01
emack accepted D17782: [ecash-lib] Allow use of .only in mocha test files.
Thu, Mar 13, 05:52

Wed, Mar 12

emack accepted D17775: [Cashtab] Show XECX sweeper balance and notice if user redemption will not be instant.
Wed, Mar 12, 04:05
emack requested changes to D17782: [ecash-lib] Allow use of .only in mocha test files.

Add .only to a test file in ecash-lib, run arc lint, get a lint error, remove it, all good, npm test with a test using .only and only that test runs

Wed, Mar 12, 04:04
emack requested changes to D17775: [Cashtab] Show XECX sweeper balance and notice if user redemption will not be instant.
Wed, Mar 12, 02:11

Tue, Mar 11

emack requested review of D17774: [ecash-lib-wasm] Add readme with installation instructions.
Tue, Mar 11, 04:53
emack accepted D17756: [Cashtab] Add click-outside-area closing effect for NavWrapper using event bubbling.

Tested all ok across chrome and firefox.

Tue, Mar 11, 04:17

Sat, Mar 8

emack accepted D17755: [monorepo] eslint all the js with a single version-pinned flat config.
Sat, Mar 8, 04:37

Fri, Mar 7

emack added a comment to D17756: [Cashtab] Add click-outside-area closing effect for NavWrapper using event bubbling.

and arc diff the next update without the linting bypass pls

Fri, Mar 7, 02:38
emack requested changes to D17756: [Cashtab] Add click-outside-area closing effect for NavWrapper using event bubbling.
Fri, Mar 7, 02:34
emack added a comment to D17755: [monorepo] eslint all the js with a single version-pinned flat config.

Regarding the mypy issue, what are your mypy and python versions ?

Fri, Mar 7, 02:11

Thu, Mar 6

emack requested changes to D17755: [monorepo] eslint all the js with a single version-pinned flat config.

/modules/chronik-client/.prettierignore and /.prettierignore be removed as it's similar to .eslintignore

Thu, Mar 6, 07:21
emack requested changes to D17756: [Cashtab] Add click-outside-area closing effect for NavWrapper using event bubbling.

Implemented a click-outside closing mechanism for the settings window

where is this implemented? I'm not seeing event bubbling above, only the removal of the redundant useEffect.

Thu, Mar 6, 06:58

Tue, Mar 4

emack accepted D17739: [Cashtab] Validate agora accepts vs user balance.
Tue, Mar 4, 00:26
emack accepted D17738: [Cashtab] Do not reset forms on fiat price change unless price is unavailable.
Tue, Mar 4, 00:19
emack accepted D17740: [Cashtab] Make ALP the default for token creation.
Tue, Mar 4, 00:14

Sat, Mar 1

emack accepted D17726: [Cashtab] Include FIRMA in balance header and fiat balance.
Sat, Mar 1, 07:30
emack accepted D17731: [ecash-herald] Show the date of the activity in the msg header.
Sat, Mar 1, 07:17

Fri, Feb 28

emack accepted D17701: [Cashtab] Support one-click redemptions.

As per tg, noting the "minor price change in between clicking list and the listing getting published" issue that is for another diff, perhaps a relist on latest price button or some sort.

image.png (757×604 px, 919 KB)

Fri, Feb 28, 12:54

Thu, Feb 27

emack added a comment to D17701: [Cashtab] Support one-click redemptions.

v3.14.0 on the netlify instance after multiple refreshes

Thu, Feb 27, 23:00
emack added a comment to D17701: [Cashtab] Support one-click redemptions.

Consider a 100% 50% 25% button above the Redeem button similar to binance. Easier for tax calculations when people are just partially selling rounded percentages.

Thu, Feb 27, 11:39

Feb 7 2025

emack accepted D17649: [Cashtab] Improve form entry UX for agora listings.
Feb 7 2025, 22:30
emack accepted D17641: [Cashtab] Support one-click redemptions for XECX.
Feb 7 2025, 22:28
emack accepted D17647: [Cashtab] Patch price display in agora cancel modal.
Feb 7 2025, 11:04
emack requested changes to D17641: [Cashtab] Support one-click redemptions for XECX.

Unable to redeem 7ish XECX for XEC, this is above dust so should be possible?

image.png (286×1 px, 19 KB)

Redemption worked fine for 10k XECX.

Feb 7 2025, 10:01

Feb 5 2025

emack accepted D17637: [ecash-agora] Move helper functions to get utxos for accepting and canceling agora txs from Cashtab to ecash-agora.
Feb 5 2025, 12:05
emack accepted D17630: [ecash-agora] Do not include offers that have not been bought or canceled in historicOffers.
Feb 5 2025, 02:47

Feb 4 2025

emack requested changes to D17630: [ecash-agora] Do not include offers that have not been bought or canceled in historicOffers.

image.png (68×317 px, 6 KB)

Can you provide some context on how to validate this output from the script above and that it is indeed excluding the not-bought or cancelled offers?

Feb 4 2025, 13:38

Feb 3 2025

emack accepted D17627: [Cashtab] Make sure hide balance toggle also hides XECX balance.
Feb 3 2025, 01:50
emack accepted D17628: [Cashtab] Do not wordbreak break-all for XECX summaries.
Feb 3 2025, 01:46
emack accepted D17625: [Cashtab] Always show send button on send screen.
Feb 3 2025, 01:43
emack added a comment to D17625: [Cashtab] Always show send button on send screen.

what is the browser / device here?

Ubuntu 22.04 / Chrome 125.0.6422.112

Feb 3 2025, 01:43

Feb 2 2025

emack requested changes to D17626: [Cashtab] Show close modal if window fails to close programmatically.

Tested on iOS Safari 18.1.1 - after paying in cashtab.com it automatically routes back to the paybutton page with the bell and then goes back to the original wp article that triggered it. I'm not seeing the reported issue where it stays on Cashtab.com.

Feb 2 2025, 05:51
emack requested changes to D17625: [Cashtab] Always show send button on send screen.

On extension the Send button is aligned left, which is correct but the rest of the component is overflowing off to the right as per current behavior. Makes the Send button almost look like a pop up not to mention it covers the labels beneath it.

image.png (1×627 px, 99 KB)

Feb 2 2025, 05:00
emack accepted D17624: [Cashtab] Patch button css.
Feb 2 2025, 03:36

Jan 30 2025

emack accepted D17608: [Cashtab] Support buying agora offers above spot, within reason.
Jan 30 2025, 05:56

Jan 26 2025

emack accepted D17593: [Cashtab] Change default setting for camera auto-open.
Jan 26 2025, 11:05

Jan 25 2025

emack accepted D17591: [Cashtab] Reduce tx autoclose time from 5s to 2s.
Jan 25 2025, 08:57

Jan 21 2025

emack accepted D17571: [Cashtab] Make sure selectedOffer cannot be undefined after a ws update.
Jan 21 2025, 13:16

Jan 18 2025

emack accepted D17560: [Cashtab] Disable claim button while we wait for server response.
Jan 18 2025, 10:27
emack accepted D17559: [Cashtab] Rewards screen to typescript.
Jan 18 2025, 04:38
emack accepted D17558: [Cashtab] Improve wallet select behavior on wallets screen.
Jan 18 2025, 04:27
emack accepted D17557: [Cashtab] Convert wallet management screen to typescript.
Jan 18 2025, 04:22

Jan 17 2025

emack added a comment to D17549: [Cashtab] Patch render logic for spinner.

I assume the flakiness of the test you're referring to is when the int test is waiting for the spinner to disappear but it doesn't, and the await waitFor() call just hangs there holding up the entire test suite?

Jan 17 2025, 08:20
emack accepted D17552: [Cashtab] Lock UI and disable keyboard input while user switches wallets.
Jan 17 2025, 08:16
emack accepted D17551: [Cashtab] Do not double call updateCashtabState on wallet change.
Jan 17 2025, 08:10
emack accepted D17550: [Cashtab] Convert WalletLabel to ts.
Jan 17 2025, 08:07

Jan 16 2025

emack accepted D17545: [Cashtab] Patch bug in building token change outputs.
Jan 16 2025, 14:27
emack added a comment to D17540: [Cashtab] Show token qty and cumulative qty in any given agora offer in a tooltip.

image.png (172×542 px, 17 KB)

Actually, I did an actual check on the bundle size, one meg over 227 megs is negligible in the grand scheme of things. Non-issue unless the whole bundle is getting to a point where it may start to affect performance?

Jan 16 2025, 05:35
emack accepted D17540: [Cashtab] Show token qty and cumulative qty in any given agora offer in a tooltip.

Minor nit but tested all ok. Can confirm the transparency is not an issue on mobile screenshots, so must be Brave specific.

Jan 16 2025, 05:35

Jan 12 2025

emack accepted D17518: [Cashtab] Remove artifact useEffect from OrderBook.
Jan 12 2025, 05:47
emack accepted D17516: [ecash-herald] Show percent capacity in daily summaries.
Jan 12 2025, 02:03
emack accepted D17515: [Cashtab] Prevent creation of unacceptable agora offers.
Jan 12 2025, 01:59

Jan 10 2025

emack accepted D17504: [Cashtab] Show XECX balance.
Jan 10 2025, 13:59
emack requested changes to D17504: [Cashtab] Show XECX balance.
Jan 10 2025, 08:31
emack accepted D17506: [mock-chronik-client] Update README.
Jan 10 2025, 08:30
emack accepted D17505: [Cashtab] Patch CI by including mock-chronik-client.
Jan 10 2025, 05:08
emack accepted D17500: [Cashtab] Lazy loading for agora.

5 tokens to load on this page by default, then have a button to "load all" with a warning about how long it will take

SGTM

Jan 10 2025, 04:20
emack added a comment to D17500: [Cashtab] Lazy loading for agora.

I also did a manual test of cashtab-local-dev vs prod, on new wallets, and this diff loads slightly faster than prod, but are still taking over 2 minutes. Is that the expected behavior?

Jan 10 2025, 03:47
emack requested changes to D17500: [Cashtab] Lazy loading for agora.
Jan 10 2025, 03:18
emack accepted D17499: [Cashtab] useContext in OrderBook instead of prop drilling.
Jan 10 2025, 03:02

Jan 9 2025

emack accepted D17484: [Cashtab] Improve form entry and validation for listing tokens on agora.
Jan 9 2025, 10:19
emack requested changes to D17484: [Cashtab] Improve form entry and validation for listing tokens on agora.
Jan 9 2025, 06:22

Jan 7 2025

emack accepted D17482: [ecash-herald, Cashtab, explorer] chronik back to native1.
Jan 7 2025, 04:53

Jan 6 2025

emack accepted D17468: [Cashtab] Bring back noisy test logs if not in CI.
Jan 6 2025, 08:28
emack accepted D17466: [Cashtab] Prevent agora buys of offers above spot.
Jan 6 2025, 03:46
emack requested changes to D17466: [Cashtab] Prevent agora buys of offers above spot.
Jan 6 2025, 01:48

Jan 3 2025

emack accepted D17459: [Cashtab] [bugfix] Patch genesis supply validation for ALP tokens in create token form and ensure large number input fields are string.
Jan 3 2025, 05:57
emack requested changes to D17459: [Cashtab] [bugfix] Patch genesis supply validation for ALP tokens in create token form and ensure large number input fields are string.

Remove SlpDecimals import in Inputs.tsx to get the build working

Jan 3 2025, 03:00

Jan 2 2025

emack requested changes to D17459: [Cashtab] [bugfix] Patch genesis supply validation for ALP tokens in create token form and ensure large number input fields are string.
Jan 2 2025, 22:34
emack accepted D17450: [cashtab] Remove the avalanche finalized message/icon in the tx history expanded area.
Jan 2 2025, 10:33

Jan 1 2025

emack accepted D17445: [cashtab] Don't open agora offers on a new tab.

@bytesofman - as a side note, current versions of major browsers are all automatically assuming rel="noopener noreferrer" when opening links in a new window.

Jan 1 2025, 10:20
emack accepted D17444: [e.cash] Add clarificatio to XECX link page.
Jan 1 2025, 01:48
emack accepted D17443: [Cashtab] Improve price precision for Agora spot prices.
Jan 1 2025, 00:00

Dec 31 2024

emack accepted D17438: [Cashtab] Allow typed input for agora quantity selection.
Dec 31 2024, 23:44
emack requested changes to D17438: [Cashtab] Allow typed input for agora quantity selection.
Dec 31 2024, 01:49

Dec 30 2024

emack accepted D17423: [CI] Use recursive deps in CI builds.
Dec 30 2024, 11:17
emack requested changes to D17426: [Cashtab] Do not show wild-ass agora offers in OrderBook.

No issues on a technical level, but philosophically, I feel this is overreaching on Cashtab's part. There are valid use cases where the seller is essentially setting this as a limit order, to be sold at their target price. I know scammers are leveraging this but implementing this diff means all etoken prices would only move in controlled increments, which goes against the DEX mantra. Also none of the mainstream DEXs do this either.

Dec 30 2024, 11:13

Dec 29 2024

emack accepted D17416: [Cashtab] No more utils folder.
Dec 29 2024, 07:42
emack accepted D17402: [Cashtab] Allow user to sort Agora offers by offer count.
Dec 29 2024, 07:38
emack added inline comments to D17414: [e.cash] Add XECX to use ecash page.
Dec 29 2024, 00:08
emack added a comment to D17402: [Cashtab] Allow user to sort Agora offers by offer count.

Also the first toggle's functionality being different to the bottom 2 should be more obvious, like using Tabs for Buy/Manage and toggles for sorting. Or simply a dropdown for sorting so you don't end up with 5 toggles for 5 sorting options.

image.png (251×561 px, 14 KB)

Dec 29 2024, 00:04
emack requested changes to D17402: [Cashtab] Allow user to sort Agora offers by offer count.
Dec 29 2024, 00:01

Dec 28 2024

emack accepted D17394: [Cashtab] Convert Etokens screen to ts.
Dec 28 2024, 23:26

Dec 25 2024

emack accepted D17395: [Cashtab] Link to Cashtab token page instead of explorer for NFTs in a collection.
Dec 25 2024, 00:03
emack requested changes to D17394: [Cashtab] Convert Etokens screen to ts.
Dec 25 2024, 00:01

Dec 24 2024

emack accepted D17391: [Cashtab] Add toggle switch to show Agora prices in XEC or fiat.
Dec 24 2024, 01:09

Dec 23 2024

emack accepted D17385: [Cashtab] Improve portability of getFormattedFiatPrice.
Dec 23 2024, 01:44
emack accepted D17386: [Cashtab] Upgrade BigNumber.js.
Dec 23 2024, 01:41

Dec 22 2024

emack accepted D17383: [Cashtab] Use user modal confirmation settings for minting tokens.
Dec 22 2024, 09:46

Dec 20 2024

emack accepted D17357: [Cashtab] Do not airdrop XEC to agora scripts.
Dec 20 2024, 10:09
emack accepted D17378: [mock-chronik-client] Cache bust dockerfile deployment.
Dec 20 2024, 03:44