Page MenuHomePhabricator

sdulfari (Skúli Dulfari)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Apr 14 2022, 17:59 (136 w, 1 d)
Roles
Administrator
Slack Username
sdulfari

Recent Activity

Apr 21 2023

sdulfari accepted D13754: [build] don't link boost::filesystem.
Apr 21 2023, 16:48
sdulfari closed D13751: [lint] Fix remaining variables shadowing python builtins and enable detection of shadowed variables going forward.
Apr 21 2023, 15:30
sdulfari committed rABC5488cd9a97d3: [lint] Fix remaining variables shadowing python builtins and enable detection… (authored by sdulfari).
[lint] Fix remaining variables shadowing python builtins and enable detection…
Apr 21 2023, 15:30
sdulfari closed D13750: [lint] Fix variables shadowing python builtins in zmq_sub.py.
Apr 21 2023, 15:30
sdulfari closed D13749: [lint] Ignore shadowing of ord() and chr() builtins in testgen/base58.py.
Apr 21 2023, 15:30
sdulfari committed rABCd7e213a04261: [lint] Fix variables shadowing python builtins in zmq_sub.py (authored by sdulfari).
[lint] Fix variables shadowing python builtins in zmq_sub.py
Apr 21 2023, 15:30
sdulfari committed rABC374f5aafce0a: [lint] Ignore shadowing of ord() and chr() builtins in testgen/base58.py (authored by sdulfari).
[lint] Ignore shadowing of ord() and chr() builtins in testgen/base58.py
Apr 21 2023, 15:30
sdulfari closed D13748: [lint] Fix variables shadowing python builtins in linearize-data.py.
Apr 21 2023, 15:30
sdulfari committed rABC90bf9c092471: [lint] Fix variables shadowing python builtins in linearize-data.py (authored by sdulfari).
[lint] Fix variables shadowing python builtins in linearize-data.py
Apr 21 2023, 15:30

Apr 20 2023

sdulfari requested review of D13751: [lint] Fix remaining variables shadowing python builtins and enable detection of shadowed variables going forward.
Apr 20 2023, 19:52
sdulfari requested review of D13750: [lint] Fix variables shadowing python builtins in zmq_sub.py.
Apr 20 2023, 18:59
sdulfari requested review of D13749: [lint] Ignore shadowing of ord() and chr() builtins in testgen/base58.py.
Apr 20 2023, 18:46
sdulfari requested review of D13748: [lint] Fix variables shadowing python builtins in linearize-data.py.
Apr 20 2023, 18:35
sdulfari closed D13747: [lint] Fix variables shadowing python builtins in gen-ninja-deps.py.
Apr 20 2023, 15:49
sdulfari committed rABC6ecf7d65e2b9: [lint] Fix variables shadowing python builtins in gen-ninja-deps.py (authored by sdulfari).
[lint] Fix variables shadowing python builtins in gen-ninja-deps.py
Apr 20 2023, 15:49

Apr 19 2023

sdulfari accepted D11974: refactor: replace boost::filesystem with std::filesystem.
Apr 19 2023, 23:53
sdulfari accepted D13730: Drop StripRedundantLastElementsOfPath() function.
Apr 19 2023, 23:24
sdulfari accepted D12608: build: remove boost::filesystem and boost::system usages.
Apr 19 2023, 23:13
sdulfari closed D13745: [lint] Fix variables shadowing python builtins in interface_zmq.py.
Apr 19 2023, 20:17
sdulfari committed rABC441aaa28db9b: [lint] Fix variables shadowing python builtins in interface_zmq.py (authored by sdulfari).
[lint] Fix variables shadowing python builtins in interface_zmq.py
Apr 19 2023, 20:17
sdulfari closed D13743: [lint] Fix variables shadowing python builtins in the test framework.
Apr 19 2023, 20:17
sdulfari closed D13742: [lint] Fix variables shadowing python builtins in abc_p2p_avalanche_transaction_voting.py.
Apr 19 2023, 20:17
sdulfari committed rABC4bf9ae763bf5: [lint] Fix variables shadowing python builtins in the test framework (authored by sdulfari).
[lint] Fix variables shadowing python builtins in the test framework
Apr 19 2023, 20:17
sdulfari committed rABC27583ce28e3b: [lint] Fix variables shadowing python builtins in… (authored by sdulfari).
[lint] Fix variables shadowing python builtins in…
Apr 19 2023, 20:17
sdulfari closed D13741: [lint] Fix variables shadowing python builtins in rpc_generateblock.py.
Apr 19 2023, 20:17
sdulfari committed rABC0146b16d7e40: [lint] Fix variables shadowing python builtins in rpc_generateblock.py (authored by sdulfari).
[lint] Fix variables shadowing python builtins in rpc_generateblock.py
Apr 19 2023, 20:17
sdulfari updated the test plan for D13744: [chronik] Fix running chronik tests when websocket is not installed.
Apr 19 2023, 20:16
teamcity awarded D13744: [chronik] Fix running chronik tests when websocket is not installed a Haypence token.
Apr 19 2023, 20:15
sdulfari added a comment to D13744: [chronik] Fix running chronik tests when websocket is not installed.

@bot build-chronik

Apr 19 2023, 20:15
sdulfari updated the diff for D13744: [chronik] Fix running chronik tests when websocket is not installed.

Try PiRK's feedback

Apr 19 2023, 20:15
sdulfari closed D13740: [lint] Require flake8-builtins to ensure we do not add shadowing of python builtins.
Apr 19 2023, 20:04
sdulfari committed rABCb608021456ee: [lint] Require flake8-builtins to ensure we do not add shadowing of python… (authored by sdulfari).
[lint] Require flake8-builtins to ensure we do not add shadowing of python…
Apr 19 2023, 20:04
sdulfari closed D13739: [lint] Fix remaining arguments shadowing python builtins.
Apr 19 2023, 20:04
sdulfari committed rABCa1e08a5f4a70: [lint] Fix remaining arguments shadowing python builtins (authored by sdulfari).
[lint] Fix remaining arguments shadowing python builtins
Apr 19 2023, 20:04
sdulfari requested review of D13747: [lint] Fix variables shadowing python builtins in gen-ninja-deps.py.
Apr 19 2023, 20:02
sdulfari requested review of D13745: [lint] Fix variables shadowing python builtins in interface_zmq.py.
Apr 19 2023, 18:40
sdulfari retitled D13744: [chronik] Fix running chronik tests when websocket is not installed from [chronik] Fix running chronik tests when websockets is not installed to [chronik] Fix running chronik tests when websocket is not installed.
Apr 19 2023, 18:31
sdulfari updated the diff for D13744: [chronik] Fix running chronik tests when websocket is not installed.

Fixup comment

Apr 19 2023, 18:31
sdulfari requested review of D13744: [chronik] Fix running chronik tests when websocket is not installed.
Apr 19 2023, 18:29
sdulfari requested review of D13743: [lint] Fix variables shadowing python builtins in the test framework.
Apr 19 2023, 18:25
sdulfari requested review of D13742: [lint] Fix variables shadowing python builtins in abc_p2p_avalanche_transaction_voting.py.
Apr 19 2023, 18:04
sdulfari requested review of D13741: [lint] Fix variables shadowing python builtins in rpc_generateblock.py.
Apr 19 2023, 18:00
sdulfari updated the test plan for D13740: [lint] Require flake8-builtins to ensure we do not add shadowing of python builtins.
Apr 19 2023, 17:51
sdulfari requested review of D13740: [lint] Require flake8-builtins to ensure we do not add shadowing of python builtins.
Apr 19 2023, 17:51
teamcity awarded D13739: [lint] Fix remaining arguments shadowing python builtins a Haypence token.
Apr 19 2023, 17:39
sdulfari added a comment to D13739: [lint] Fix remaining arguments shadowing python builtins.

@bot build-native-osx

Apr 19 2023, 17:39
sdulfari added a comment to D13739: [lint] Fix remaining arguments shadowing python builtins.

Ignore the lint error. This comes from my local machine which has flake8-builtins installed.

Apr 19 2023, 17:37
sdulfari requested review of D13739: [lint] Fix remaining arguments shadowing python builtins.
Apr 19 2023, 17:36

Apr 11 2023

sdulfari closed D13673: Cleanup unused TEST_RUNNER_TEMPLATE variable.
Apr 11 2023, 20:25
sdulfari committed rABCcc2c510100d5: Cleanup unused TEST_RUNNER_TEMPLATE variable (authored by sdulfari).
Cleanup unused TEST_RUNNER_TEMPLATE variable
Apr 11 2023, 20:25
sdulfari accepted D13676: [CI] Fix diff regex for JS Mocha templates.
Apr 11 2023, 20:22
sdulfari closed D13675: Fix shadowing of python builtins in tests.
Apr 11 2023, 18:37
sdulfari committed rABCe88798b0f81e: Fix shadowing of python builtins in tests (authored by sdulfari).
Fix shadowing of python builtins in tests
Apr 11 2023, 18:37
sdulfari requested review of D13675: Fix shadowing of python builtins in tests.
Apr 11 2023, 18:03
sdulfari accepted D13663: [buildbot] Disallow non ABC members from summoning builds with a docker configuration.
Apr 11 2023, 17:59
sdulfari closed D13670: Rename hash to txid for COutPoint in the test framework.
Apr 11 2023, 17:36
sdulfari committed rABC6456cdacf8f2: Rename hash to txid for COutPoint in the test framework (authored by sdulfari).
Rename hash to txid for COutPoint in the test framework
Apr 11 2023, 17:36
sdulfari accepted D13667: [CI] Use a random port for the website preview.
Apr 11 2023, 17:32
sdulfari accepted D13669: [buildbot] Advertise a preview url is available.
Apr 11 2023, 17:08
sdulfari requested review of D13673: Cleanup unused TEST_RUNNER_TEMPLATE variable.
Apr 11 2023, 17:03
sdulfari committed rABC72a3ee627ac7: [avalanche] Rename variables shadowing builtins in avatools (authored by sdulfari).
[avalanche] Rename variables shadowing builtins in avatools
Apr 11 2023, 16:12
sdulfari closed D13660: [avalanche] Rename variables shadowing builtins in avatools.
Apr 11 2023, 16:12
sdulfari closed D13659: Bump minimum supported mypy version to 0.910.
Apr 11 2023, 16:07
sdulfari committed rABC74563ddb3f8e: Bump minimum supported mypy version to 0.910 (authored by sdulfari).
Bump minimum supported mypy version to 0.910
Apr 11 2023, 16:07
sdulfari added a comment to D13670: Rename hash to txid for COutPoint in the test framework.

Apparently the lint errors come from my local machine since I have flake8-builtins installed. Please ignore for now. I will get to those soon.

Apr 11 2023, 16:04
sdulfari requested review of D13670: Rename hash to txid for COutPoint in the test framework.
Apr 11 2023, 16:01
sdulfari added a comment to D13659: Bump minimum supported mypy version to 0.910.

I tried 0.991, 1.1.1, and 1.2.0 also. All mypy versions above 0.910 give me this on Debian 10:

$ arc lint abc_rpc_isfinal.py
 Exception 
Some linters failed:
    - CommandException: Command failed with error #1!
      COMMAND
      mypy --show-error-codes --ignore-missing-imports --install-types --non-interactive /home/dev/bitcoin-abc/test/functional/abc_rpc_isfinal.py
Apr 11 2023, 15:51
sdulfari requested review of D13660: [avalanche] Rename variables shadowing builtins in avatools.
Apr 11 2023, 06:56
sdulfari closed D13658: [avalanche] Unify finding a hash in poll into can_find_inv_in_poll via avatools.
Apr 11 2023, 06:21
sdulfari committed rABC64e1de95c29b: [avalanche] Unify finding a hash in poll into can_find_inv_in_poll via avatools (authored by sdulfari).
[avalanche] Unify finding a hash in poll into can_find_inv_in_poll via avatools
Apr 11 2023, 06:21
sdulfari added a comment to D13658: [avalanche] Unify finding a hash in poll into can_find_inv_in_poll via avatools.

Yes, changes to come. I'll think up a better name.

Apr 11 2023, 06:21
sdulfari accepted D13653: [CI] Add support for running website containers.
Apr 11 2023, 06:19
sdulfari closed D13657: Cleanup unused Jefferson activation time.
Apr 11 2023, 06:18
sdulfari committed rABCb6deb0a289f4: Cleanup unused Jefferson activation time (authored by sdulfari).
Cleanup unused Jefferson activation time
Apr 11 2023, 06:18
sdulfari requested review of D13659: Bump minimum supported mypy version to 0.910.
Apr 11 2023, 06:17
sdulfari requested review of D13658: [avalanche] Unify finding a hash in poll into can_find_inv_in_poll via avatools.
Apr 11 2023, 05:30
sdulfari requested review of D13657: Cleanup unused Jefferson activation time.
Apr 11 2023, 04:12

Apr 10 2023

sdulfari requested changes to D13653: [CI] Add support for running website containers.

Have you considered using docker-compose instead? That way, you won't have to include all of that config logic in build-configurations.py and you get benefits like automatic port mapping support.

Apr 10 2023, 20:43
sdulfari accepted D13650: [e.cash] Add a Dockerfile to deploy the website.
Apr 10 2023, 15:32

Apr 3 2023

sdulfari closed D13483: Use block policy state instead of parked state to determine if a policy was violated.
Apr 3 2023, 18:24
sdulfari committed rABC39373b71509c: Use block policy state instead of parked state to determine if a policy was… (authored by sdulfari).
Use block policy state instead of parked state to determine if a policy was…
Apr 3 2023, 18:24
sdulfari closed D13482: Log the reason for a block policy violation.
Apr 3 2023, 17:26
sdulfari committed rABC3c6224afcb2c: Log the reason for a block policy violation (authored by sdulfari).
Log the reason for a block policy violation
Apr 3 2023, 17:26
sdulfari closed D13527: test: Use self.wait_until over wait_until_helper.
Apr 3 2023, 16:13
sdulfari committed rABC41da7aa36f15: test: Use self.wait_until over wait_until_helper (authored by fanquake <fanquake@gmail.com>).
test: Use self.wait_until over wait_until_helper
Apr 3 2023, 16:13

Apr 1 2023

sdulfari updated the diff for D13482: Log the reason for a block policy violation.
  • Feedback
  • Replace std::all_of() with std::find_if_not() to make early bail a guarantee
  • Apply new lint
Apr 1 2023, 22:17
sdulfari requested review of D13527: test: Use self.wait_until over wait_until_helper.
Apr 1 2023, 04:01

Mar 31 2023

sdulfari accepted D13491: [avalanche] Sort txs to poll by modified fee rate.
Mar 31 2023, 18:55

Mar 30 2023

sdulfari requested changes to D13491: [avalanche] Sort txs to poll by modified fee rate.
Mar 30 2023, 18:29

Mar 27 2023

sdulfari requested review of D13483: Use block policy state instead of parked state to determine if a policy was violated.
Mar 27 2023, 21:14
sdulfari updated the diff for D13482: Log the reason for a block policy violation.

Fix assert_debug_log related flakiness

Mar 27 2023, 20:41
sdulfari planned changes to D13482: Log the reason for a block policy violation.
Mar 27 2023, 20:38
sdulfari requested review of D13482: Log the reason for a block policy violation.
Mar 27 2023, 19:21
sdulfari accepted D13470: [depends] Don't build shared libs in native protobuf.
Mar 27 2023, 15:57

Mar 24 2023

sdulfari closed D13424: [avalanche] Make peer availability score accessible via getavalanchepeerinfo.
Mar 24 2023, 20:39
sdulfari committed rABCe27b5856fc78: [avalanche] Make peer availability score accessible via getavalanchepeerinfo (authored by sdulfari).
[avalanche] Make peer availability score accessible via getavalanchepeerinfo
Mar 24 2023, 20:39
sdulfari updated the diff for D13424: [avalanche] Make peer availability score accessible via getavalanchepeerinfo.

Fixup unit test

Mar 24 2023, 18:55

Mar 23 2023

sdulfari accepted D13439: Remove a useless iterator cast in txmempool.cpp.
Mar 23 2023, 23:26
sdulfari updated the diff for D13424: [avalanche] Make peer availability score accessible via getavalanchepeerinfo.

Remove averaging in favor of adding node scores to make the peer score

Mar 23 2023, 23:07
sdulfari updated the diff for D13424: [avalanche] Make peer availability score accessible via getavalanchepeerinfo.
  • Add missing RPCResult entry
  • Fix division by zero when calculating average peer score
  • Rebase
Mar 23 2023, 06:37