Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC4bed870fb6eb: convert unsafe fs::path std::string conversion calls [3/7] (interfaces, qt, rpc)

Summary

This is a partial backport of core#22937 [2c/2g]
https://github.com/bitcoin/bitcoin/pull/22937/commits/6544ea5035268025207d2402db2f7d90fde947a6

The backport for this commit was split in to multiple commits to make review easier. This part deals with converting fs::string() calls that
will become unsafe when migrating from boost::filesystem to std::filesystem.

Depends on D10796

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 10 2022, 12:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 10 2022, 12:56

PiRK requested review of this revision.Jan 10 2022, 12:56

teamcity edited the summary of this revision. (Show Details)Jan 10 2022, 12:56

PiRK added a child revision: D10798: convert unsafe fs::path std::string conversion calls [4/7] (test, fuzz, wallet/test).Jan 10 2022, 12:59

Harbormaster completed remote builds in B17853: Diff 31716.Jan 10 2022, 13:21

PiRK retitled this revision from convert unsafe fs::path std::string conversion calls [3/7] to convert unsafe fs::path std::string conversion calls [3/7] (interfaces, qt, rpc).Jan 10 2022, 15:10

PiRK edited the summary of this revision. (Show Details)

Fabien accepted this revision.Jan 11 2022, 09:46

This revision is now accepted and ready to land.Jan 11 2022, 09:46

Closed by commit rABC4bed870fb6eb: convert unsafe fs::path std::string conversion calls [3/7] (interfaces, qt, rpc) (authored by PiRK). · Explain WhyJan 11 2022, 12:26

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC4bed870fb6eb: convert unsafe fs::path std::string conversion calls [3/7] (interfaces, qt, rpc).

convert unsafe fs::path std::string conversion calls [3/7] (interfaces, qt, rpc)
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 31755

src/interfaces/wallet.cpp

src/qt/guiutil.cpp

src/qt/intro.cpp

src/rpc/blockchain.cpp

src/rpc/request.cpp

src/rpc/server.cpp

convert unsafe fs::path std::string conversion calls [3/7] (interfaces, qt, rpc)ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 31755

src/interfaces/wallet.cpp

src/qt/guiutil.cpp

src/qt/intro.cpp

src/rpc/blockchain.cpp

src/rpc/request.cpp

src/rpc/server.cpp

convert unsafe fs::path std::string conversion calls [3/7] (interfaces, qt, rpc)
ClosedPublic
Actions

Revision Contents
Changeset List