Paths

Table of Contentst

Differential D11213

validation: Move invalid block handling to CChainState
ClosedPublic
Actions

Authored by PiRK on Mar 17 2022, 14:34.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC6a1163b5f2fa: validation: Move invalid block handling to CChainState

Summary

Notes:

InvalidChainFound was already moved to CChainState in D7573
CheckForkWarningConditionsOnNewFork was removed by core in core#19905 because it doesn't work, but in Bitcoin ABC it was fixed in D1950.

This is a backport of core#21055 [8/16]
https://github.com/bitcoin/bitcoin/pull/21055/commits/8b99efbcc08ab41caf657c6d730a27e6a91bc356

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr21055

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18547
Build 36889: Build Diff	lint-circular-dependencies · build-diff · build-debug · build-without-wallet · build-clang-tidy · build-clang
Build 36888: arc lint + arc unit

Event Timeline

PiRK created this revision.Mar 17 2022, 14:34

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 17 2022, 14:34

PiRK requested review of this revision.Mar 17 2022, 14:34

teamcity edited the summary of this revision. (Show Details)Mar 17 2022, 14:34

Fabien accepted this revision.Mar 17 2022, 14:55

This revision is now accepted and ready to land.Mar 17 2022, 14:55

PiRK added a child revision: D11214: validation: Move LoadBlockIndexDB to CChainState.Mar 17 2022, 14:56

Harbormaster completed remote builds in B18547: Diff 32814.Mar 17 2022, 14:59

Closed by commit rABC6a1163b5f2fa: validation: Move invalid block handling to CChainState (authored by Carl Dong <contact@carldong.me>, committed by PiRK). · Explain WhyMar 18 2022, 09:51

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC6a1163b5f2fa: validation: Move invalid block handling to CChainState.

Revision Contents
Changeset List

Path

Size

src/

8 lines

29 lines

Diff 32814

src/validation.h

Loading...

src/validation.cpp

Loading...