Page MenuHomePhabricator

Remove incremental relay fee.

Authored by schancel on Mar 6 2018, 04:08.



Remove handling of incremental relay fee which was
added for RBF support.

Test Plan

make check

Diff Detail

rABC Bitcoin ABC
Lint Not Applicable
Tests Not Applicable

Event Timeline

1216 ↗(On Diff #3092)

Seems logic to have something here, but I'm not sure what it should be. Maybe the min relay fee?

It is used for mempool limiting AND replacement. Why isn't it necessary for mempool limiting now ?

Why is a configurable fee increment on the mempool limit necessary? It's re-evaluated after every single txn. It will be increased as necessary anyways. It does make sense to have it as some fraction of the minimum relay fee.

This will be scheduled for 0.17.1 So we can check the effect on the BlockPolicyEstimator.

Leave the flag removed, but keep the same value until investigated further.

deadalnix requested changes to this revision.May 24 2018, 13:42
deadalnix added inline comments.
1211 ↗(On Diff #3856)

This is not about relay anymore, so this should be renamed.

918 ↗(On Diff #3856)

Why is that not checked anymore ? What happen is mempoolRejectFee is negative ?

This revision now requires changes to proceed.May 24 2018, 13:42

Rebase and address comments

This revision is now accepted and ready to land.May 24 2018, 16:53
This revision was automatically updated to reflect the committed changes.