Page MenuHomePhabricator

Remove incremental relay fee.
ClosedPublic

Authored by schancel on Mar 6 2018, 04:08.

Details

Reviewers
deadalnix
jasonbcox
sickpig
Group Reviewers
Restricted Project
Commits
Restricted Diffusion Commit
rABC8b790efbff17: Remove incremental relay fee.
Summary

Remove handling of incremental relay fee which was
added for RBF support.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
remove-incremental
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 2568
Build 3253: Bitcoin ABC Teamcity Staging
Build 3252: arc lint + arc unit

Event Timeline

schancel created this revision.Mar 6 2018, 04:08
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 6 2018, 04:08
schancel added inline comments.Mar 6 2018, 04:11
src/txmempool.cpp
1216 ↗(On Diff #3092)

Seems logic to have something here, but I'm not sure what it should be. Maybe the min relay fee?

It is used for mempool limiting AND replacement. Why isn't it necessary for mempool limiting now ?

schancel added a comment.Mar 6 2018, 13:37

Why is a configurable fee increment on the mempool limit necessary? It's re-evaluated after every single txn. It will be increased as necessary anyways. It does make sense to have it as some fraction of the minimum relay fee.

This will be scheduled for 0.17.1 So we can check the effect on the BlockPolicyEstimator.

schancel updated this revision to Diff 3742.May 3 2018, 01:48

Rebase

schancel updated this revision to Diff 3856.May 9 2018, 20:31

Leave the flag removed, but keep the same value until investigated further.

deadalnix requested changes to this revision.May 24 2018, 13:42
deadalnix added inline comments.
src/txmempool.cpp
1211

This is not about relay anymore, so this should be renamed.

src/validation.cpp
918

Why is that not checked anymore ? What happen is mempoolRejectFee is negative ?

This revision now requires changes to proceed.May 24 2018, 13:42
schancel updated this revision to Diff 3968.May 24 2018, 16:49

Rebase and address comments

deadalnix accepted this revision.May 24 2018, 16:53
This revision is now accepted and ready to land.May 24 2018, 16:53
This revision was automatically updated to reflect the committed changes.