Paths

Table of Contentst

Differential D1361

Move minRelayFee into Config handler
ClosedPublic
Actions

Authored by schancel on May 3 2018, 00:23.

Tags

None

Subscribers

Details

Reviewers

jasonbcox
deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGINGbb1586d321ab: Move minRelayFee into Config handler
rABCbb1586d321ab: Move minRelayFee into Config handler

Summary

This commit is general cleanup. It moves the minRelayFee
global into the global configuration handling object.

Depends on D1173

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

schancel created this revision.May 3 2018, 00:23

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 3 2018, 00:23

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

Harbormaster failed remote builds in B2480: Diff 3737!May 3 2018, 00:25

Clean up a few missed instances...

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2481: Diff 3738.May 3 2018, 01:45

Everything looks good except for the one issue.

src/wallet/wallet.cpp
2949 ↗	(On Diff #3738)	I know the old code didn't do this, but I think we should start differentiating between fee and fee-rate. This minFee is a total fee, whereas most of the other variables in this diff are fee-rates. Can you update the variable names accordingly?

This revision now requires changes to proceed.May 3 2018, 21:08

schancel added inline comments.May 3 2018, 23:50

src/wallet/wallet.cpp
2949 ↗	(On Diff #3738)	Not going to do it in this diff, but yes I intend to clean that stuff up once I simplify the fee insanity.

jasonbcox accepted this revision.May 4 2018, 02:13

jasonbcox added inline comments.

src/wallet/wallet.cpp
2949 ↗	(On Diff #3738)	Great, thanks!

This revision is now accepted and ready to land.May 4 2018, 02:13

deadalnix added a subscriber: deadalnix.May 4 2018, 14:47

deadalnix added inline comments.

src/init.cpp
1587 ↗	(On Diff #3738)	Why is that condition removed ?
1592 ↗	(On Diff #3738)	Why is that log removed ? This doesn't seems covered by the test plan nor justified anywhere.

schancel added a parent revision: D1174: Remove incremental relay fee..May 4 2018, 16:41

schancel added inline comments.

src/init.cpp
1587 ↗	(On Diff #3738)	Because this is some crap associated with RBF that was never removed. Also, I added D1174 as a dependency.

deadalnix accepted this revision.May 4 2018, 18:22

Rebase

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2638: Diff 3969.May 24 2018, 17:24

Closed by commit rABCbb1586d321ab: Move minRelayFee into Config handler (authored by schancel). · Explain WhyMay 24 2018, 18:59

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

10 lines

8 lines

4 lines

net_processing.cpp

4 lines

rpc/

4 lines

4 lines

5 lines

6 lines

wallet/

17 lines

Diff 3973

src/config.h

Loading...

src/config.cpp

Loading...

src/init.cpp

Loading...

src/net_processing.cpp

Loading...

src/rpc/misc.cpp

Loading...

src/rpc/net.cpp

Loading...

src/validation.h

Loading...

src/validation.cpp

Loading...

src/wallet/wallet.cpp

Loading...