Page MenuHomePhabricator

Move minRelayFee into Config handler

Authored by schancel on May 3 2018, 00:23.



This commit is general cleanup. It moves the minRelayFee
global into the global configuration handling object.

Depends on D1173

Test Plan

make check

Diff Detail

rABC Bitcoin ABC
Lint Not Applicable
Tests Not Applicable

Event Timeline

Clean up a few missed instances...

jasonbcox requested changes to this revision.May 3 2018, 21:08
jasonbcox added a subscriber: jasonbcox.

Everything looks good except for the one issue.

2949 ↗(On Diff #3738)

I know the old code didn't do this, but I think we should start differentiating between fee and fee-rate. This minFee is a total fee, whereas most of the other variables in this diff are fee-rates. Can you update the variable names accordingly?

This revision now requires changes to proceed.May 3 2018, 21:08
2949 ↗(On Diff #3738)

Not going to do it in this diff, but yes I intend to clean that stuff up once I simplify the fee insanity.

jasonbcox added inline comments.
2949 ↗(On Diff #3738)

Great, thanks!

This revision is now accepted and ready to land.May 4 2018, 02:13
deadalnix added inline comments.
1587 ↗(On Diff #3738)

Why is that condition removed ?

1592 ↗(On Diff #3738)

Why is that log removed ? This doesn't seems covered by the test plan nor justified anywhere.

schancel added inline comments.
1587 ↗(On Diff #3738)

Because this is some crap associated with RBF that was never removed. Also, I added D1174 as a dependency.

This revision was automatically updated to reflect the committed changes.