Page MenuHomePhabricator

Move minRelayFee into Config handler
ClosedPublic

Authored by schancel on May 3 2018, 00:23.

Details

Reviewers
jasonbcox
deadalnix
Group Reviewers
Restricted Project
Commits
Restricted Diffusion Commit
rABCbb1586d321ab: Move minRelayFee into Config handler
Summary

This commit is general cleanup. It moves the minRelayFee
global into the global configuration handling object.

Depends on D1173

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
relay-fee
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 2481
Build 3091: Bitcoin ABC Teamcity Staging
Build 3090: arc lint + arc unit

Event Timeline

schancel created this revision.May 3 2018, 00:23
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 3 2018, 00:23
schancel updated this revision to Diff 3738.May 3 2018, 01:08

Clean up a few missed instances...

jasonbcox requested changes to this revision.May 3 2018, 21:08
jasonbcox added a subscriber: jasonbcox.

Everything looks good except for the one issue.

src/wallet/wallet.cpp
2949

I know the old code didn't do this, but I think we should start differentiating between fee and fee-rate. This minFee is a total fee, whereas most of the other variables in this diff are fee-rates. Can you update the variable names accordingly?

This revision now requires changes to proceed.May 3 2018, 21:08
schancel added inline comments.May 3 2018, 23:50
src/wallet/wallet.cpp
2949

Not going to do it in this diff, but yes I intend to clean that stuff up once I simplify the fee insanity.

jasonbcox accepted this revision.May 4 2018, 02:13
jasonbcox added inline comments.
src/wallet/wallet.cpp
2949

Great, thanks!

This revision is now accepted and ready to land.May 4 2018, 02:13
deadalnix added inline comments.
src/init.cpp
1587

Why is that condition removed ?

1592

Why is that log removed ? This doesn't seems covered by the test plan nor justified anywhere.

schancel added inline comments.
src/init.cpp
1587

Because this is some crap associated with RBF that was never removed. Also, I added D1174 as a dependency.

deadalnix accepted this revision.May 4 2018, 18:22
This revision was automatically updated to reflect the committed changes.