Details

Reviewers

deadalnix
jasonbcox
sickpig

Group Reviewers

Restricted Project

Commits

rSTAGING8b790efbff17: Remove incremental relay fee.
rABC8b790efbff17: Remove incremental relay fee.

Summary

Remove handling of incremental relay fee which was
added for RBF support.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

remove-incremental

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2484
Build 3097: Bitcoin ABC Buildbot (legacy)
Build 3096: arc lint + arc unit

Event Timeline

schancel created this revision.Mar 6 2018, 04:08

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 6 2018, 04:08

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

schancel added inline comments.Mar 6 2018, 04:11

src/txmempool.cpp
1216 ↗	(On Diff #3092)	Seems logic to have something here, but I'm not sure what it should be. Maybe the min relay fee?

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2006: Diff 3092.Mar 6 2018, 04:35

It is used for mempool limiting AND replacement. Why isn't it necessary for mempool limiting now ?

Why is a configurable fee increment on the mempool limit necessary? It's re-evaluated after every single txn. It will be increased as necessary anyways. It does make sense to have it as some fraction of the minimum relay fee.

This will be scheduled for 0.17.1 So we can check the effect on the BlockPolicyEstimator.

schancel added a task: T287: Release 0.17.1 Inclusions.Mar 13 2018, 18:25

schancel removed a task: T287: Release 0.17.1 Inclusions.May 3 2018, 01:32

Rebase

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2484: Diff 3742.May 3 2018, 02:06

schancel added a child revision: D1361: Move minRelayFee into Config handler.May 4 2018, 16:41

schancel mentioned this in D1361: Move minRelayFee into Config handler.

Leave the flag removed, but keep the same value until investigated further.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2568: Diff 3856.May 9 2018, 20:54

deadalnix requested changes to this revision.May 24 2018, 13:42

deadalnix added inline comments.

src/txmempool.cpp
1211 ↗	(On Diff #3856)	This is not about relay anymore, so this should be renamed.
src/validation.cpp
918 ↗	(On Diff #3856)	Why is that not checked anymore ? What happen is mempoolRejectFee is negative ?

This revision now requires changes to proceed.May 24 2018, 13:42

Rebase and address comments

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

deadalnix accepted this revision.May 24 2018, 16:53

This revision is now accepted and ready to land.May 24 2018, 16:53

Closed by commit rABC8b790efbff17: Remove incremental relay fee. (authored by schancel). · Explain WhyMay 24 2018, 17:12

This revision was automatically updated to reflect the committed changes.

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2637: Diff 3968.May 24 2018, 17:22

Remove incremental relay fee.
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 3742

doc/release-notes.md

src/init.cpp

src/policy/policy.h

src/policy/policy.cpp

src/rpc/net.cpp

src/test/mempool_tests.cpp

src/txmempool.cpp

src/validation.cpp

Remove incremental relay fee.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 3742

doc/release-notes.md

src/init.cpp

src/policy/policy.h

src/policy/policy.cpp

src/rpc/net.cpp

src/test/mempool_tests.cpp

src/txmempool.cpp

src/validation.cpp

Remove incremental relay fee.
ClosedPublic
Actions

Revision Contents
Changeset List