Page MenuHomePhabricator
Differential D12135

MOVEONLY: context-free package policies
ClosedPublic
Actions

Authored by PiRK on Oct 4 2022, 09:55.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCf8aa6035ca37: MOVEONLY: context-free package policies
Summary

Co-authored-by: ariard <antoine.riard@gmail.com>

This concludes backport of core#22084
https://github.com/bitcoin/bitcoin/pull/22084/commits/ee862d6efb4c3c01e55f0d5d7a82cce75323cf40

Depends on D12134

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 4 2022, 09:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 4 2022, 09:55
PiRK requested review of this revision.Oct 4 2022, 09:55
teamcity edited the summary of this revision. (Show Details)Oct 4 2022, 09:55
Harbormaster completed remote builds in B20331: Diff 35398.Oct 4 2022, 10:10
teamcity added a comment.Oct 4 2022, 10:10
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 4 2022, 10:10
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 4 2022, 10:12
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
PiRK added inline comments.Oct 4 2022, 10:42
src/policy/packages.cpp
14 ↗(On Diff #35398)

size_t

Fabien requested changes to this revision.Oct 4 2022, 16:21
Fabien added a subscriber: Fabien.

LGTM except that size_t thing

src/policy/packages.cpp
14 ↗(On Diff #35398)

yes please

This revision now requires changes to proceed.Oct 4 2022, 16:21
teamcity added a comment.Oct 4 2022, 17:34
Build Bitcoin ABC Diffs / Diff Testing (lint-circular-dependencies) failed.

Tail of the build log:

/work /work/abc-ci-builds/lint-circular-dependencies
A new circular dependency in the form of "policy/packages -> txmempool -> validation -> policy/packages" appears to have been introduced.

/work/abc-ci-builds/lint-circular-dependencies
Build lint-circular-dependencies failed with exit code 1
PiRK planned changes to this revision.Oct 4 2022, 18:05

I will rebase this after backporting https://github.com/bitcoin/bitcoin/pull/19935 to avoid introducing the circular dependency.

PiRK updated this revision to Diff 35440.Oct 5 2022, 09:47

fix type, rebase onto D12149 (replace #include <txmempool.h> with #include <util/hasher.h> to avoid introducing a new circular dependency)

Harbormaster completed remote builds in B20360: Diff 35440.Oct 5 2022, 10:26
Fabien accepted this revision.Oct 5 2022, 14:42
This revision is now accepted and ready to land.Oct 5 2022, 14:42
Closed by commit rABCf8aa6035ca37: MOVEONLY: context-free package policies (authored by glozow <gzhao408@berkeley.edu>, committed by PiRK). · Explain WhyOct 5 2022, 16:17
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCf8aa6035ca37: MOVEONLY: context-free package policies.

Revision Contents
Changeset List

PathSize
src/
1 line
policy/
10 lines
75 lines
83 lines

Diff 35450

View Options

src/CMakeLists.txt

Loading...
View Options

src/policy/packages.h

Loading...
View Options

src/policy/packages.cpp

Loading...
View Options

src/validation.cpp

Loading...