⚙ D15501 [chronik-client] Support new tokenId endpoints

bytesofman created this revision.Feb 20 2024, 23:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 20 2024, 23:04

Harbormaster completed remote builds in B27285: Diff 45433.Feb 20 2024, 23:12

Add more tests, need to refine and work out history() test at end

Harbormaster completed remote builds in B27286: Diff 45434.Feb 21 2024, 01:20

Build Bitcoin ABC Diffs / Diff Testing (chronik-client-integration-tests) failed.

Failed tests logs:

====== Get blocktxs, txs, and history for ALP token txs: Can all tx history from tokenId.history().Get blocktxs, txs, and history for ALP token txs Can all tx history from tokenId.history() ======
AssertionError: expected undefined to deeply equal { …(12) }
    at /work/modules/chronik-client/test/integration/token_alp.ts:1061:47
    at Generator.next (<anonymous>)
    at fulfilled (test/integration/token_alp.ts:31:58)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

      + expected - actual:  failed to generate Mocha diff

Each failure log is accessible here:
Get blocktxs, txs, and history for ALP token txs: Can all tx history from tokenId.history().Get blocktxs, txs, and history for ALP token txs Can all tx history from tokenId.history()

tests pass

bytesofman edited the summary of this revision. (Show Details)Feb 21 2024, 03:51

bytesofman edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B27287: Diff 45435.Feb 21 2024, 03:58

Build Bitcoin ABC Diffs / Diff Testing (chronik-client-integration-tests) failed.

Failed tests logs:

====== Get blocktxs, txs, and history for SLP NFT1 token txs: "before each" hook for "Gets an SLP NFT1 child genesis tx from the mempool".Get blocktxs, txs, and history for SLP NFT1 token txs "before each" hook for "Gets an SLP NFT1 child genesis tx from the mempool" ======
Error: Timeout of 20000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/work/modules/chronik-client/test/integration/token_slp_nft1.ts)
    at listOnTimeout (node:internal/timers:573:17)
    at processTimers (node:internal/timers:514:7)

Each failure log is accessible here:
Get blocktxs, txs, and history for SLP NFT1 token txs: "before each" hook for "Gets an SLP NFT1 child genesis tx from the mempool".Get blocktxs, txs, and history for SLP NFT1 token txs "before each" hook for "Gets an SLP NFT1 child genesis tx from the mempool"

bytesofman added inline comments.Feb 21 2024, 04:07

modules/chronik-client/test/integration/token_alp.ts
1080 ↗	(On Diff #45435)	todo work out why the order is different here vs the confirmed ones

Fill out the tests

comment improvement

bytesofman published this revision for review.Feb 21 2024, 17:05

bytesofman added a subscriber: tobias_ruck.

bytesofman added inline comments.

modules/chronik-client/test/integration/token_alp.ts
716 ↗	(On Diff #45451)	Here it happens to be reverse alphabetical, but in other places it is not In all cases, the order we get repeats from test to test. I am not sure what the order is though. It is not broadcast order as the genesis tx is not last or first. See other inline comments for better datasets.
1147 ↗	(On Diff #45451)	here is the order we get for confirmed txs from a tokenId(<tokenId>).history() call not reverse broadcast order genesis tx is 2nd to last and not last alpSendTxid is out of order with alpMultiTxid not alphabetical order alpMegaTxid is alphabetically before other txs I am not sure what the order is. @tobias_ruck is there an expected order here?
1267 ↗	(On Diff #45451)	We see ordering by blockheight. Ordering within blocks is determinate but I am not able to tell the pattern.

will update comments on expected order

Harbormaster completed remote builds in B27297: Diff 45450.Feb 21 2024, 17:48

The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.

Harbormaster completed remote builds in B27298: Diff 45451.Feb 21 2024, 17:57

The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.

Update comments and ordering tests

Harbormaster completed remote builds in B27299: Diff 45452.Feb 21 2024, 18:16

Build Bitcoin ABC Diffs / Diff Testing (chronik-client-integration-tests) failed.

Failed tests logs:

====== Get blocktxs, txs, and history for SLP NFT1 token txs: "before each" hook for "Gets an SLP NFT1 send tx from the mempool".Get blocktxs, txs, and history for SLP NFT1 token txs "before each" hook for "Gets an SLP NFT1 send tx from the mempool" ======
Error: Timeout of 20000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/work/modules/chronik-client/test/integration/token_slp_nft1.ts)
    at listOnTimeout (node:internal/timers:573:17)
    at processTimers (node:internal/timers:514:7)

Each failure log is accessible here:
Get blocktxs, txs, and history for SLP NFT1 token txs: "before each" hook for "Gets an SLP NFT1 send tx from the mempool".Get blocktxs, txs, and history for SLP NFT1 token txs "before each" hook for "Gets an SLP NFT1 send tx from the mempool"

rebase and bump mocha timeout

Harbormaster completed remote builds in B27301: Diff 45455.Feb 21 2024, 18:54

The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.

rebase

Harbormaster completed remote builds in B27304: Diff 45459.Feb 21 2024, 19:50

Fabien added a subscriber: Fabien.Feb 22 2024, 09:34

Fabien added inline comments.

modules/chronik-client/src/ChronikClientNode.ts
1177 ↗	(On Diff #45459)	This is no longer true, it's not present for utxos. Not sure if that's better, is that consistent with other fields returned by the library ?
modules/chronik-client/test/integration/token_alp.ts
1117 ↗	(On Diff #45459)

improve comments on interface definition, fix typo in test

modules/chronik-client/src/ChronikClientNode.ts
1177 ↗	(On Diff #45459)	We could keep it here and always return `entryIdx: -1` for utxos, which is what we get from chronik. But the -1 seems to be there just to inform the user that there is no tokenEntry key of arrays to get this data from. Since the -1 is useless in utxos, I figured it would be better to simply exclude it. We do something similar with fields that are occasionally expected to be undefined (i.e., simply omitting the keys in what chronik-client returns). Updated the comment

Harbormaster completed remote builds in B27316: Diff 45473.Feb 22 2024, 12:04

Build Bitcoin ABC Diffs / Diff Testing (chronik-client-integration-tests) failed.

Failed tests logs:

====== Get blocktxs, txs, and history for SLP NFT1 token txs: "before each" hook for "Gets an SLP NFT1 send tx from the mempool".Get blocktxs, txs, and history for SLP NFT1 token txs "before each" hook for "Gets an SLP NFT1 send tx from the mempool" ======
Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/work/modules/chronik-client/test/integration/token_slp_nft1.ts)
    at listOnTimeout (node:internal/timers:573:17)
    at processTimers (node:internal/timers:514:7)

Each failure log is accessible here:
Get blocktxs, txs, and history for SLP NFT1 token txs: "before each" hook for "Gets an SLP NFT1 send tx from the mempool".Get blocktxs, txs, and history for SLP NFT1 token txs "before each" hook for "Gets an SLP NFT1 send tx from the mempool"