Page MenuHomePhabricator
Differential D1654

Moved CBlockFileInfo class from chain.h into its own header and updated .cpp and .h file dependencies.
ClosedPublic
Actions

Authored by nakihito on Aug 14 2018, 20:13.

Details

Reviewers
jasonbcox
deadalnix
schancel
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGe868c6b3f3df: Moved CBlockFileInfo class from chain.h into its own header and updated .cpp…
rABCe868c6b3f3df: Moved CBlockFileInfo class from chain.h into its own header and updated .cpp…
Summary

Starts work on T380

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
SeperatingBlockFileClass
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3088
Build 4263: Bitcoin ABC Buildbot (legacy)
Build 4262: arc lint + arc unit

Event Timeline

nakihito created this revision.Aug 14 2018, 20:13
Owners added a reviewer: Restricted Owners Package.Aug 14 2018, 20:13
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 14 2018, 20:13
teamcity added a subscriber: teamcity.Aug 14 2018, 20:15

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

nakihito mentioned this in D1655: Seperated CDiskBlockPos from Chain.h into its own .h file and updated .h and .cpp dependencies..Aug 14 2018, 20:27
teamcity added a comment.Aug 14 2018, 20:51

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3082: Diff 4589.Aug 14 2018, 20:52
jasonbcox accepted this revision.Aug 14 2018, 21:15
This revision is now accepted and ready to land.Aug 14 2018, 21:15
nakihito mentioned this in D1656: Seperated enum class BlockValidity from chain.h into its own .h file and updated other .h and .cpp dependencies..Aug 14 2018, 21:16
jasonbcox requested changes to this revision.Aug 15 2018, 22:27
jasonbcox added inline comments.
src/blockfileinfo.h
12 ↗(On Diff #4589)

Forgot, this file needs to be added to Makefile.am

This revision now requires changes to proceed.Aug 15 2018, 22:27
nakihito updated this revision to Diff 4597.Aug 19 2018, 22:01

Added blockfileinfo.h to src/Makefile.am.

jasonbcox accepted this revision.Aug 19 2018, 22:02
This revision is now accepted and ready to land.Aug 19 2018, 22:02
teamcity added a comment.Aug 19 2018, 22:02

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Aug 19 2018, 22:39

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3088: Diff 4597.Aug 19 2018, 22:39
Closed by commit rABCe868c6b3f3df: Moved CBlockFileInfo class from chain.h into its own header and updated .cpp… (authored by nakihito). · Explain WhyAug 21 2018, 00:14
This revision was automatically updated to reflect the committed changes.
nakihito mentioned this in rABC1846d75b46d1: Seperated CDiskBlockPos from Chain.h into its own .h file and updated .h and ..Sep 4 2018, 05:34
nakihito mentioned this in rSTAGING1846d75b46d1: Seperated CDiskBlockPos from Chain.h into its own .h file and updated .h and ..Sep 27 2018, 19:00
PiRK mentioned this in D8629: Convert chain and blockfileinfo to new serialization.Dec 8 2020, 14:27
PiRK mentioned this in rABC0b536d79fbb7: Convert chain and blockfileinfo to new serialization.Dec 8 2020, 19:39
PiRK mentioned this in D12768: Move CBlockFileInfo::ToString method where class is declared.Dec 5 2022, 17:03
PiRK mentioned this in rABCc3c7cb0ab6b6: Move CBlockFileInfo::ToString method where class is declared.Dec 6 2022, 08:04

Revision Contents
Changeset List

PathSize
src/
1 line
75 lines
62 lines
1 line
1 line

Diff 4597

View Options

src/Makefile.am

Loading...
View Options

src/blockfileinfo.h

Loading...
View Options

src/chain.h

Loading...
View Options

src/txdb.h

Loading...
View Options

src/validation.h

Loading...