Page MenuHomePhabricator
Differential D1747

Add Binds, WhiteBinds, Whitelistedrange to CConnman::Options
ClosedPublic
Actions

Authored by deadalnix on Sep 10 2018, 11:48.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING6421c9405615: Add Binds, WhiteBinds, Whitelistedrange to CConnman::Options
rABC6421c9405615: Add Binds, WhiteBinds, Whitelistedrange to CConnman::Options
Summary
  • add WhitelistedRange to CConnman::Options

Part of a series of changes to clean up the instantiation of connman
by decoupling the command line arguments.

  • add Binds, WhiteBinds to CConnman::Options

Part of a series of changes to clean up the instantiation of connman
by decoupling the command line arguments.

We also now abort with an error when explicit binds are set with
-listen=0.

This is a backport of core PR10496

Depends on D1746

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
corepr10496
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3257
Build 4601: Bitcoin ABC Buildbot (legacy)
Build 4600: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 10 2018, 11:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 10 2018, 11:48
teamcity added a subscriber: teamcity.Sep 10 2018, 11:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Sep 10 2018, 12:25

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3240: Diff 4832.Sep 10 2018, 12:25
schancel accepted this revision.Sep 10 2018, 20:26
This revision is now accepted and ready to land.Sep 10 2018, 20:26
deadalnix updated this revision to Diff 4862.Sep 10 2018, 22:03

rebase

Closed by commit rABC6421c9405615: Add Binds, WhiteBinds, Whitelistedrange to CConnman::Options (authored by Marko Bencun <marko.bencun@monetas.net>, committed by deadalnix). · Explain WhySep 10 2018, 22:07
This revision was automatically updated to reflect the committed changes.
teamcity added a comment.Sep 10 2018, 22:15

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Sep 10 2018, 22:50

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3257: Diff 4862.Sep 10 2018, 22:50
jasonbcox mentioned this in D2961: Merge #10057: [init] Deduplicated sigaction() boilerplate.May 7 2019, 03:23

Revision Contents
Changeset List

PathSize
src/
131 lines
16 lines
69 lines

Diff 4862

View Options

src/init.cpp

Loading...
View Options

src/net.h

Loading...
View Options

src/net.cpp

Loading...