Page MenuHomePhabricator
Differential D185

Remove leftover short-circuit evaluation condition from bdb377d68ea8
ClosedPublic
Actions

Authored by awemany on Jun 13 2017, 14:34.

Details

Reviewers
deadalnix
freetrader
sickpig
kyuupichan
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGf3d61491456d: Remove leftover short-circuit evaluation condition from bdb377d68ea8
rABCf3d61491456d: Remove leftover short-circuit evaluation condition from bdb377d68ea8
Summary

Removes extra stuff left over from cleanup in bdb377d68ea8,
"Kill SegWit Step 11: Remove HasWitness".

Test Plan

This fixes the code to evalulate like "tx.HasWitness() == false" holds. Compare also bdb377d68ea8.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cleanup-kill-segwit11
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 252
Build 252: arc lint + arc unit

Event Timeline

awemany created this revision.Jun 13 2017, 14:34
Owners added a reviewer: Restricted Owners Package.Jun 13 2017, 14:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 13 2017, 14:34
awemany edited the test plan for this revision. (Show Details)Jun 13 2017, 14:35
deadalnix accepted this revision.Jun 13 2017, 14:36
This revision is now accepted and ready to land.Jun 13 2017, 14:36
Closed by commit rABCf3d61491456d: Remove leftover short-circuit evaluation condition from bdb377d68ea8 (authored by awemany, committed by awemany). · Explain WhyJun 13 2017, 14:37
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines

Diff 425

View Options

src/net_processing.cpp

Loading...