Page MenuHomePhabricator
Differential D1866

Do not shadow variables (gcc set)
ClosedPublic
Actions

Authored by deadalnix on Oct 2 2018, 15:51.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING5ca09825881e: Do not shadow variables (gcc set)
rABC5ca09825881e: Do not shadow variables (gcc set)
Summary
  • Do not shadow variables (gcc set)
  • Check and enable -Wshadow by default.

This is a backport of core PR8808

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
noshadow
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3486
Build 5048: Bitcoin ABC Buildbot (legacy)
Build 5047: arc lint + arc unit

Event Timeline

deadalnix created this revision.Oct 2 2018, 15:51
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 2 2018, 15:51
teamcity added a subscriber: teamcity.Oct 2 2018, 15:53

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Oct 2 2018, 16:10

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3486: Diff 5232.Oct 2 2018, 16:10
jasonbcox accepted this revision.Oct 3 2018, 01:33
jasonbcox added a subscriber: jasonbcox.

I don't agree with the naming at all, but we can revise those after our backports are caught up.

This revision is now accepted and ready to land.Oct 3 2018, 01:33
Closed by commit rABC5ca09825881e: Do not shadow variables (gcc set) (authored by Pavel Janík <Pavel@Janik.cz>, committed by deadalnix). · Explain WhyOct 3 2018, 12:08
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
1 line
src/
1 line
6 lines
bench/
4 lines
4 lines
script/
12 lines
6 lines
6 lines
support/
4 lines
test/
2 lines
16 lines

Diff 5232

View Options

configure.ac

Loading...
View Options

src/CMakeLists.txt

Loading...
View Options

src/arith_uint256.cpp

Loading...
View Options

src/bench/lockedpool.cpp

Loading...
View Options

src/chain.h

Loading...
View Options

src/script/script.h

Loading...
View Options

src/script/script.cpp

Loading...
View Options

src/streams.h

Loading...
View Options

src/support/lockedpool.cpp

Loading...
View Options

src/test/coins_tests.cpp

Loading...
View Options

src/timedata.h

Loading...