Paths

Table of Contentst

Differential D18739

test: remove bare CBlockHeader `.rehash()`/`.calc_sha256()` calls
ClosedPublic
Actions

Authored by PiRK on Sep 30 2025, 14:59.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCa71669cda074: test: remove bare CBlockHeader `.rehash()`/`.calc_sha256()` calls

Summary

Since the previous commit, CBlockHeader/CBlock object calls to the
methods .rehash() and .calc_sha256() are effectively no-ops
if the returned value is not used, so we can just remove them.

This is a partial backport of core#32868
https://github.com/bitcoin/bitcoin/pull/32868/commits/8b09cc350afac05d22c7c87433d376654f3ce403

Depends on D18738

Test Plan

ninja check-functional-extended

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 34689
Build 68844: Build Diff	build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 68843: arc lint + arc unit

Event Timeline

PiRK created this revision.Sep 30 2025, 14:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 30 2025, 14:59

teamcity edited the summary of this revision. (Show Details)Sep 30 2025, 14:59

PiRK added a child revision: D18740: test: rename CBlockHeader `.rehash()`/`.sha256` -> `.hash_int` for consistency.Sep 30 2025, 15:01

Harbormaster completed remote builds in B34689: Diff 56013.Sep 30 2025, 15:27

PiRK published this revision for review.Sep 30 2025, 18:16

Fabien accepted this revision.Oct 1 2025, 08:00

This revision is now accepted and ready to land.Oct 1 2025, 08:00

Closed by commit rABCa71669cda074: test: remove bare CBlockHeader `.rehash()`/`.calc_sha256()` calls (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>, committed by PiRK). · Explain WhyOct 1 2025, 08:50

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCa71669cda074: test: remove bare CBlockHeader `.rehash()`/`.calc_sha256()` calls.

Revision Contents
Changeset List

Path

Size

test/

functional/

abc-minimaldata.py

2 lines

2 lines

abc-schnorrmultisig.py

2 lines

abc_p2p_compactblocks.py

5 lines

example_test.py

1 line

feature_63_bit_ints.py

2 lines

feature_block.py

1 line

feature_csv_activation.py

1 line

feature_maxuploadtarget.py

1 line

feature_tx_version.py

2 lines

p2p_compactblocks.py

9 lines

p2p_compactblocks_blocksonly.py

1 line

1 line

p2p_invalid_messages.py

3 lines

p2p_sendheaders.py

1 line

rpc_blockchain.py

1 line

test_framework/

1 line

8 lines

Diff 56013

test/functional/abc-minimaldata.py

Loading...

test/functional/abc-schnorr.py

Loading...

test/functional/abc-schnorrmultisig.py

Loading...

test/functional/abc_p2p_compactblocks.py

Loading...

test/functional/example_test.py

Loading...

test/functional/feature_63_bit_ints.py

Loading...

test/functional/feature_block.py

Loading...

test/functional/feature_csv_activation.py

Loading...

test/functional/feature_maxuploadtarget.py

Loading...

test/functional/feature_tx_version.py

Loading...

test/functional/p2p_compactblocks.py

Loading...

test/functional/p2p_compactblocks_blocksonly.py

Loading...

test/functional/p2p_getdata.py

Loading...

test/functional/p2p_invalid_messages.py

Loading...

test/functional/p2p_sendheaders.py

Loading...

test/functional/rpc_blockchain.py

Loading...

test/functional/test_framework/blocktools.py

Loading...

test/functional/test_framework/messages.py

Loading...