Page MenuHomePhabricator
Differential D1892

Add a test case to ensure mempool accounting is correct
ClosedPublic
Actions

Authored by schancel on Oct 5 2018, 21:42.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGbfe41c9185c6: Add a test case to ensure mempool accounting is correct
rABCbfe41c9185c6: Add a test case to ensure mempool accounting is correct
Summary

Add a test case to ensure that accounting of package statistics are
correct across a chain of transactions

Test Plan
make ./src/test/test_bitcoin && ./src/test/test_bitcoin --run_test=mempool_tests/TestPackageAccounting

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schancel created this revision.Oct 5 2018, 21:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 5 2018, 21:42
teamcity added a subscriber: teamcity.Oct 5 2018, 21:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

schancel updated this revision to Diff 5298.Oct 5 2018, 21:44

Remove erroroneous inclusions

schancel edited the test plan for this revision. (Show Details)Oct 5 2018, 21:45
teamcity added a comment.Oct 5 2018, 21:46

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Oct 5 2018, 21:57

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3530: Diff 5297!Oct 5 2018, 21:58
teamcity added a comment.Oct 5 2018, 22:05

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3531: Diff 5298.Oct 5 2018, 22:05
schancel planned changes to this revision.Oct 6 2018, 21:09

This can probably be improved quite a bit.

schancel updated this revision to Diff 5314.Oct 8 2018, 22:12

Make a hypergraph instead of a linear change of transactions.

teamcity added a comment.Oct 8 2018, 22:14

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Oct 8 2018, 22:31

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3535: Diff 5314.Oct 8 2018, 22:31
jasonbcox added a subscriber: jasonbcox.Oct 8 2018, 22:54
jasonbcox added inline comments.
src/test/mempool_tests.cpp
46 ↗(On Diff #5314)

Why use a while-loop instead of a for-loop?

101 ↗(On Diff #5314)

Is this test intended to cover varying fees/values? If so, add some randomness to the fee and/or value of the inputs/outputs.

schancel updated this revision to Diff 5317.Oct 8 2018, 23:18
schancel marked an inline comment as done.

Switch to a for loop, and randomize fees.

teamcity added a comment.Oct 8 2018, 23:19

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B3537: Diff 5317.Oct 8 2018, 23:37
teamcity added a comment.Oct 8 2018, 23:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

schancel retitled this revision from Add a test case to ensure mempool acounting is correct to Add a test case to ensure mempool accounting is correct.Oct 9 2018, 17:25
schancel added a child revision: D1860: Introduce and track a billable size in addition to real txn size.Oct 9 2018, 21:22
jasonbcox accepted this revision.Oct 9 2018, 21:23
This revision is now accepted and ready to land.Oct 9 2018, 21:23
Closed by commit rABCbfe41c9185c6: Add a test case to ensure mempool accounting is correct (authored by schancel). · Explain WhyOct 9 2018, 22:08
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
test/
113 lines

Diff 5361

View Options

src/test/mempool_tests.cpp

Loading...