Page MenuHomePhabricator

Introduce and track a billable size in addition to real txn size
ClosedPublic

Authored by schancel on Oct 1 2018, 22:22.

Details

Summary

Introduce a billable size which can be used to discount, and or increase, fees on specific
sections of a transaction. The future intent is to reduce overall fees, put increase fees
on UTXO generation.

Depends on D1859, D1892

Test Plan
make VERBOSE=1 check && ./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schancel created this revision.Oct 1 2018, 22:22
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 1 2018, 22:22
schancel planned changes to this revision.Oct 2 2018, 00:56

Needs a test

deadalnix requested changes to this revision.Oct 15 2018, 00:48
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/test/transaction_tests.cpp
809 ↗(On Diff #5398)

The addition of GetBillableSize and that test could go in now if they were in their own diff.

However there are vast changes to the mempool code coming with it. The changes to the mempool do not come up with a test.

So I suggest GetBillableSize to be split in its own diff, and this one to be rebased on it. With the addition of a test for the mempool accounting, that second part should be good to go.

This revision now requires changes to proceed.Oct 15 2018, 00:48
schancel updated this revision to Diff 5418.Oct 15 2018, 17:41

Rebase + Include proper tests

jasonbcox accepted this revision.Oct 16 2018, 18:09
deadalnix accepted this revision.Oct 20 2018, 19:04
This revision is now accepted and ready to land.Oct 20 2018, 19:04
This revision was automatically updated to reflect the committed changes.