Introduce and track a billable size in addition to real txn size
ClosedPublic
Actions

Authored by schancel on Oct 1 2018, 22:22.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING3a13d305d291: Introduce and track a billable size in addition to real txn size
rABC3a13d305d291: Introduce and track a billable size in addition to real txn size

Summary

Introduce a billable size which can be used to discount, and or increase, fees on specific
sections of a transaction. The future intent is to reduce overall fees, put increase fees
on UTXO generation.

Depends on D1859, D1892

Test Plan

make VERBOSE=1 check && ./test/functional/test_runner.py --extended

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3589
Build 5253: Bitcoin ABC Buildbot (legacy)
Build 5252: arc lint + arc unit

Event Timeline

schancel created this revision.Oct 1 2018, 22:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 1 2018, 22:22

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

schancel added a child revision: D1801: Begin using billable txn size for wallet and mining.Oct 1 2018, 22:23

schancel edited the summary of this revision. (Show Details)

schancel added a parent revision: D1859: [qa] use billable_size is testnode fee estimates.

Harbormaster completed remote builds in B3474: Diff 5218.Oct 1 2018, 22:40

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Needs a test

schancel edited the summary of this revision. (Show Details)Oct 9 2018, 21:22

schancel added a parent revision: D1892: Add a test case to ensure mempool accounting is correct.

Rebase

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3589: Diff 5398.Oct 12 2018, 21:15

deadalnix requested changes to this revision.Oct 15 2018, 00:48

deadalnix added a subscriber: deadalnix.

deadalnix added inline comments.

src/test/transaction_tests.cpp
809	The addition of `GetBillableSize` and that test could go in now if they were in their own diff. However there are vast changes to the mempool code coming with it. The changes to the mempool do not come up with a test. So I suggest `GetBillableSize` to be split in its own diff, and this one to be rebased on it. With the addition of a test for the mempool accounting, that second part should be good to go.