Page MenuHomePhabricator

Remove minTxFee from wallet
ClosedPublic

Authored by schancel on Sep 23 2018, 21:08.

Details

Summary

Currently, the wallet has a minTxFee which will override the minrelayfee
when calculating minimum fees. This leads to a situation where both must
be adjusted together in order to get the desired effect. -paytxfee should
be used instead, if overriding minrelayfee is desired.

Test Plan

make check && ./test/function/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schancel created this revision.Sep 23 2018, 21:08
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 23 2018, 21:08
jasonbcox accepted this revision.Sep 24 2018, 20:52
This revision is now accepted and ready to land.Sep 24 2018, 20:52
schancel updated this revision to Diff 5037.Sep 25 2018, 21:11

Remove extraneous line from coincontroldialog

schancel planned changes to this revision.Sep 26 2018, 15:50

This got updated with the wrong patch contents.

This revision is now accepted and ready to land.Sep 27 2018, 22:33
schancel updated this revision to Diff 5144.Sep 27 2018, 22:39

Remove whitespace change

This revision was automatically updated to reflect the committed changes.