Page MenuHomePhabricator
Differential D1800

Remove minTxFee from wallet
ClosedPublic
Actions

Authored by schancel on Sep 23 2018, 21:08.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGc0dff931b214: Remove minTxFee from wallet
rABCc0dff931b214: Remove minTxFee from wallet
Summary

Currently, the wallet has a minTxFee which will override the minrelayfee
when calculating minimum fees. This leads to a situation where both must
be adjusted together in order to get the desired effect. -paytxfee should
be used instead, if overriding minrelayfee is desired.

Test Plan

make check && ./test/function/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
arcpatch-D1800
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3425
Build 4926: Bitcoin ABC Buildbot (legacy)
Build 4925: arc lint + arc unit

Event Timeline

schancel created this revision.Sep 23 2018, 21:08
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 23 2018, 21:08
teamcity added a subscriber: teamcity.Sep 23 2018, 21:10

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Sep 23 2018, 21:27

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3345: Diff 4997.Sep 23 2018, 21:27
schancel added a child revision: D1801: Begin using billable txn size for wallet and mining.Sep 24 2018, 00:05
jasonbcox accepted this revision.Sep 24 2018, 20:52
This revision is now accepted and ready to land.Sep 24 2018, 20:52
schancel updated this revision to Diff 5037.Sep 25 2018, 21:11

Remove extraneous line from coincontroldialog

teamcity added a comment.Sep 25 2018, 21:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B3361: Diff 5037!Sep 25 2018, 21:13
teamcity added a comment.Sep 25 2018, 21:13

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

schancel planned changes to this revision.Sep 26 2018, 15:50

This got updated with the wrong patch contents.

schancel updated this revision to Diff 5143.Sep 27 2018, 22:33

Rebase

This revision is now accepted and ready to land.Sep 27 2018, 22:33
teamcity added a comment.Sep 27 2018, 22:34

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

schancel updated this revision to Diff 5144.Sep 27 2018, 22:39

Remove whitespace change

teamcity added a comment.Sep 27 2018, 22:40

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Sep 27 2018, 22:52

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3424: Diff 5143.Sep 27 2018, 22:52
Harbormaster completed remote builds in B3425: Diff 5144.Sep 27 2018, 22:58
teamcity added a comment.Sep 27 2018, 22:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Closed by commit rABCc0dff931b214: Remove minTxFee from wallet (authored by schancel). · Explain WhySep 27 2018, 23:06
This revision was automatically updated to reflect the committed changes.
schancel mentioned this in D1937: Change the maxtxfee to be per kb..Nov 5 2018, 19:31

Revision Contents
Changeset List

PathSize
src/
qt/
12 lines
12 lines
wallet/
6 lines
8 lines
22 lines
3 lines
7 lines

Diff 5144

View Options

src/qt/coincontroldialog.cpp

Loading...
View Options

src/qt/sendcoinsdialog.cpp

Loading...
View Options

src/wallet/fees.h

Loading...
View Options

src/wallet/fees.cpp

Loading...
View Options

src/wallet/init.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...