Page MenuHomePhabricator
Differential D1910

Use unique_ptr for pcoinscatcher/pcoinsdbview/pcoinsTip/pblocktree
ClosedPublic
Actions

Authored by deadalnix on Oct 9 2018, 19:40.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGc698ad5493b9: Use unique_ptr for pcoinscatcher/pcoinsdbview/pcoinsTip/pblocktree
rABCc698ad5493b9: Use unique_ptr for pcoinscatcher/pcoinsdbview/pcoinsTip/pblocktree
Summary
  • pcoinscatcher (CCoinsViewErrorCatcher)
  • pcoinsdbview (CCoinsViewDB)
  • pcoinsTip (CCoinsViewCache)
  • pblocktree (CBlockTreeDB)
  • Remove variables shadowing pcoinsdbview

This is part of Core PR11043

Depends on D1909

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
uniqueptr
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3571
Build 5217: Bitcoin ABC Buildbot (legacy)
Build 5216: arc lint + arc unit

Event Timeline

deadalnix created this revision.Oct 9 2018, 19:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 9 2018, 19:40
teamcity added a subscriber: teamcity.Oct 9 2018, 19:40

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Oct 9 2018, 19:53

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3559: Diff 5355!Oct 9 2018, 19:53
deadalnix updated this revision to Diff 5368.Oct 9 2018, 22:37

rebase

teamcity added a comment.Oct 9 2018, 22:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Oct 9 2018, 22:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3567: Diff 5368.Oct 9 2018, 22:48
deadalnix updated this revision to Diff 5374.Oct 10 2018, 10:42

rebase

teamcity added a comment.Oct 10 2018, 10:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Oct 10 2018, 10:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3571: Diff 5374.Oct 10 2018, 10:54
jasonbcox accepted this revision.Oct 16 2018, 04:52
This revision is now accepted and ready to land.Oct 16 2018, 04:52
Closed by commit rABCc698ad5493b9: Use unique_ptr for pcoinscatcher/pcoinsdbview/pcoinsTip/pblocktree (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by deadalnix). · Explain WhyOct 16 2018, 07:32
This revision was automatically updated to reflect the committed changes.
Fabien mentioned this in D2229: Use unique_ptr for pwalletMain,httpRPCTimerInterface,dbw,dbenv,pdbCopy.Dec 28 2018, 15:52
Fabien mentioned this in rABC6c2476a5c9ed: Use unique_ptr for pwalletMain,httpRPCTimerInterface,dbw,dbenv,pdbCopy.Dec 31 2018, 13:18
Fabien mentioned this in rSTAGING6c2476a5c9ed: Use unique_ptr for pwalletMain,httpRPCTimerInterface,dbw,dbenv,pdbCopy.Jan 20 2019, 23:54
Fabien mentioned this in D3050: Fix more init bugs..May 15 2019, 11:15
Fabien mentioned this in rABCc7f22f815621: Fix more init bugs..May 16 2019, 07:20
Fabien mentioned this in rSTAGINGc7f22f815621: Fix more init bugs..Sep 18 2019, 23:33

Revision Contents
Changeset List

PathSize
src/
39 lines
4 lines
qt/
test/
3 lines
rpc/
7 lines
test/
1 line
12 lines
26 lines
3 lines
6 lines
18 lines

Diff 5374

View Options

src/init.cpp

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/qt/test/rpcnestedtests.h

Loading...
View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/test/test_bitcoin.h

Loading...
View Options

src/test/test_bitcoin.cpp

Loading...
View Options

src/test/txvalidationcache_tests.cpp

Loading...
View Options

src/txmempool.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...