Details
- Reviewers
deadalnix jasonbcox markblundeberg - Group Reviewers
Restricted Project Restricted Owners Package (Owns No Changed Paths)
make check && ./test/functional/test_runner.py
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- arcpatch-D1936
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 3775 Build 5624: Bitcoin ABC Buildbot (legacy) Build 5623: arc lint + arc unit
Event Timeline
src/config.cpp | ||
---|---|---|
87 ↗ | (On Diff #5567) | This is left uninitialized when the config is created. |
src/config.h | ||
109 ↗ | (On Diff #5567) | DEFAULT_TRANSACTION_MAXFEE |
src/test/txvalidationcache_tests.cpp | ||
32 ↗ | (On Diff #5567) | This doesn't seems to be related with the diff. |
src/wallet/init.cpp | ||
222 ↗ | (On Diff #5567) | Remove and initialize the config as expected. |
src/config.cpp | ||
---|---|---|
9 | This most likely indicate that the DEFAULT_TRANSACTION_MAXFEE should be defined elsewhere :) |
src/wallet/init.cpp | ||
---|---|---|
235 ↗ | (On Diff #5988) | This sanity check wasn't ported over. |
src/config.cpp | ||
---|---|---|
89 ↗ | (On Diff #5988) | @deadalnix You asked me to move the sanity check here. Am I missing something? |
src/wallet/init.cpp | ||
235 ↗ | (On Diff #5988) | You asked previously to move it to bool GlobalConfig::SetMaxFee(Amount fee)? Is there something wrong with what I put there? |
This looks good on the surface, but I need to do another pass of review to make sure.
src/config.cpp | ||
---|---|---|
81 ↗ | (On Diff #7768) | This looks like a simple rename from feePerKB -> minFeePerKB. If that's the case, please remove feePerKB from the config. Otherwise, explain why both are needed and why they're separate. |
src/config.cpp | ||
---|---|---|
81 ↗ | (On Diff #7768) | Please elaborate? This is the minimum fee that will be relayed per KB. The MaxFee is not currently enforced Per KB -- the next commit on the stack fixes that. |