Page MenuHomePhabricator

Add activation code for the block size parameter of UAHF.
ClosedPublic

Authored by deadalnix on Jun 13 2017, 21:26.

Details

Summary

This ensure no block larger than 1MB is mined before the fork. After the fork, larger blocks can be mined.

Depends on D190

Test Plan
make check
../qa/pull-tester/rpc-tests.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Update MedianPastTime => MedianTimePast

Set fake fork time in the future instead of in the past so we don't have to adapt all existing tests when adding the > 1MB rule.

Fix abc-p2p-fullblocktest.py

Please change test plan to run the '-extended' regression tests.
Changing block validity like this could impact the other tests.

This revision now requires changes to proceed.Jun 14 2017, 20:28
deadalnix edited edge metadata.

I ran the extended test suite on the whole stack and it is green. I can do it on this one, but it's going to take a long time. Can you review the diff in the meantime assuming it's green ?

Fixed more comments.
Run the extended test suite and it's green.

Code comments updated by author via online discussion.

Test passed, code makes sense - accepting.

This revision is now accepted and ready to land.Jun 14 2017, 21:16
This revision was automatically updated to reflect the committed changes.