Page MenuHomePhabricator
Differential D200

Enforce that a large block is produced when the HF triggers
ClosedPublic
Actions

Authored by deadalnix on Jun 14 2017, 13:33.

Details

Reviewers
freetrader
sickpig
awemany
kyuupichan
Group Reviewers
Restricted Project
Commits
rSTAGING6c6719b09f06: Enforce that a large block is produced when the HF triggers
rABC6c6719b09f06: Enforce that a large block is produced when the HF triggers
Summary

This is as per spec. The first block of the HF must be larger than 1MB in order to avoid reorg.

Test Plan
make check

Added integration tests to check for the proper activation of the fork.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Jun 14 2017, 13:33
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 14 2017, 13:33
deadalnix added a parent revision: D197: Test OP_RETURN anti replay feature.Jun 14 2017, 13:33
deadalnix updated this revision to Diff 484.Jun 14 2017, 21:26

Rebase

Harbormaster completed remote builds in B292: Diff 484.Jun 14 2017, 21:26
deadalnix added a child revision: D202: Test SIGHASH_FORKID activation.Jun 14 2017, 21:27
freetrader added inline comments.Jun 14 2017, 22:00
qa/rpc-tests/abc-p2p-activation.py
272 ↗(On Diff #465)

You should attempt this more than once IMO, just to verify that it cannot be overcome after first too-small block.

qa/rpc-tests/abc-p2p-fullblocktest.py
215 ↗(On Diff #465)

This comment seems like it was meant for bfork further down.
block(0) is initialized to current machine time + 1s , not to HF start time, as per the change introduced in next_block()...

deadalnix updated this revision to Diff 485.Jun 14 2017, 22:17

Fix faulty comments

freetrader accepted this revision.Jun 14 2017, 22:32
This revision is now accepted and ready to land.Jun 14 2017, 22:32
Closed by commit rABC6c6719b09f06: Enforce that a large block is produced when the HF triggers (authored by deadalnix, committed by deadalnix). · Explain WhyJun 14 2017, 22:42
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
qa/
rpc-tests/
11 lines
24 lines
src/
28 lines

Diff 487

View Options

qa/rpc-tests/abc-p2p-activation.py

Loading...
View Options

qa/rpc-tests/abc-p2p-fullblocktest.py

Loading...
View Options

src/validation.cpp

Loading...