Page MenuHomePhabricator
Differential D2322

remove minimum total fee option
ClosedPublic
Actions

Authored by jasonbcox on Jan 15 2019, 23:52.

Details

Reviewers
deadalnix
Fabien
Mengerian
Group Reviewers
Restricted Project
Commits
rSTAGING7b1fba8cb016: remove minimum total fee option
rABC7b1fba8cb016: remove minimum total fee option
Summary

Backport of Core PR10390
https://github.com/bitcoin/bitcoin/pull/10390/files

Completes T522

Test Plan

bitcoin-qt removes the total radio button option as expected.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr10390
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4677
Build 7417: Bitcoin ABC Buildbot (legacy)
Build 7416: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jan 15 2019, 23:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 15 2019, 23:52
Herald added a subscriber: schancel. · View Herald Transcript
jasonbcox planned changes to this revision.Jan 15 2019, 23:52
jasonbcox edited the summary of this revision. (Show Details)
teamcity added a subscriber: teamcity.Jan 15 2019, 23:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 16 2019, 00:03

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4538: Diff 6686.Jan 16 2019, 00:03
jasonbcox requested review of this revision.Jan 16 2019, 19:53
jasonbcox edited the test plan for this revision. (Show Details)
Fabien accepted this revision.Jan 17 2019, 14:24

Note : there is a lot of missing braces in this file

This revision is now accepted and ready to land.Jan 17 2019, 14:24
Fabien requested changes to this revision.Jan 17 2019, 14:38

I failed to run the test plan, I simply cannot find the button before this change. Is there something to do to make it appear ?

This revision now requires changes to proceed.Jan 17 2019, 14:38
Mengerian added a subscriber: Mengerian.Jan 23 2019, 16:27

@Fabien Yeah, that's strange, I have the same issue.

I can see the radio button when I run the last release on Windows, but not running a build from latest master on Linux

jasonbcox updated this revision to Diff 6888.Jan 24 2019, 00:32

Rebase

I checked again and I see the radio button on master.

teamcity added a comment.Jan 24 2019, 00:33

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B4677: Diff 6888.Jan 24 2019, 00:46
teamcity added a comment.Jan 24 2019, 00:46

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix edited the summary of this revision. (Show Details)Jan 24 2019, 02:07
teamcity added a comment.Jan 24 2019, 23:14

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B4677: Diff 6888!Jan 24 2019, 23:27
teamcity added a comment.Jan 24 2019, 23:27

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

teamcity added a comment.Jan 25 2019, 23:26

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 25 2019, 23:40

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4677: Diff 6888.Jan 25 2019, 23:40
markblundeberg added a subscriber: markblundeberg.Jan 26 2019, 06:07

@Fabien @Mengerian you need to have coin control settings enabled to see the radio, and it becomes selectable once you select some coins to spend --

Screenshot from 2019-01-25 22-04-58.png (618×1 px, 166 KB)

Fabien accepted this revision.Jan 26 2019, 08:40

@markblundeberg Thanks, this was the trick I was looking for !

This revision is now accepted and ready to land.Jan 26 2019, 08:40
jasonbcox updated this revision to Diff 6951.Jan 27 2019, 20:36

Rebase

teamcity added a comment.Jan 27 2019, 20:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 27 2019, 20:52

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4716: Diff 6951.Jan 27 2019, 20:52
Mengerian accepted this revision.Jan 27 2019, 20:54

Yup, I can confirm the it works for me also, after enabling Coin Control as Mark suggested.

Closed by commit rABC7b1fba8cb016: remove minimum total fee option (authored by Gregory Sanders <gsanders87@gmail.com>, committed by jasonbcox). · Explain WhyJan 27 2019, 21:26
This revision was automatically updated to reflect the committed changes.
markblundeberg added inline comments.Feb 16 2019, 02:22
src/qt/sendcoinsdialog.cpp
164 ↗(On Diff #6952)

I am having crashes here.

markblundeberg added a comment.Feb 16 2019, 02:41

Need fix: https://github.com/bitcoin/bitcoin/pull/11332

markblundeberg mentioned this in D2559: fix Qt crash.Feb 16 2019, 03:02
Diffusion mentioned this in rABCeafa2b46d818: fix Qt crash.Feb 16 2019, 03:41
jasonbcox added a commit: rSTAGING7b1fba8cb016: remove minimum total fee option.Sep 18 2019, 22:07
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rSTAGINGeafa2b46d818: fix Qt crash.Sep 18 2019, 22:25

Revision Contents
Changeset List

PathSize
src/
qt/
6 lines
forms/
13 lines
32 lines
wallet/
3 lines
5 lines

Diff 6888

View Options

src/qt/coincontroldialog.cpp

Loading...
View Options

src/qt/forms/sendcoinsdialog.ui

Loading...
View Options

src/qt/sendcoinsdialog.cpp

Loading...
View Options

src/wallet/coincontrol.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...