Page MenuHomePhabricator

remove minimum total fee option
ClosedPublic

Authored by jasonbcox on Jan 15 2019, 23:52.

Details

Summary
Test Plan

bitcoin-qt removes the total radio button option as expected.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr10390
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4716
Build 7495: Bitcoin ABC Buildbot (legacy)
Build 7494: arc lint + arc unit

Event Timeline

jasonbcox edited the summary of this revision. (Show Details)
jasonbcox edited the test plan for this revision. (Show Details)

Note : there is a lot of missing braces in this file

This revision is now accepted and ready to land.Jan 17 2019, 14:24
Fabien requested changes to this revision.Jan 17 2019, 14:38

I failed to run the test plan, I simply cannot find the button before this change. Is there something to do to make it appear ?

This revision now requires changes to proceed.Jan 17 2019, 14:38

@Fabien Yeah, that's strange, I have the same issue.

I can see the radio button when I run the last release on Windows, but not running a build from latest master on Linux

Rebase

I checked again and I see the radio button on master.

@Fabien @Mengerian you need to have coin control settings enabled to see the radio, and it becomes selectable once you select some coins to spend --

Screenshot from 2019-01-25 22-04-58.png (618×1 px, 166 KB)

@markblundeberg Thanks, this was the trick I was looking for !

This revision is now accepted and ready to land.Jan 26 2019, 08:40

Yup, I can confirm the it works for me also, after enabling Coin Control as Mark suggested.

This revision was automatically updated to reflect the committed changes.
src/qt/sendcoinsdialog.cpp
164 ↗(On Diff #6952)

I am having crashes here.