[tests] Move only: move NodeConnCB below NodeConn
ClosedPublic
Actions

Authored by Fabien on Jan 21 2019, 09:16.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGec708a35e20c: [tests] Move only: move NodeConnCB below NodeConn
rABCec708a35e20c: [tests] Move only: move NodeConnCB below NodeConn

Summary

This is required since NodeConnCB will inherit from NodeConn
after the next commit.

Partial backport of core PR11712 (commit e30d404)

Depends on D2358

Test Plan

./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR11712_part3

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4603
Build 7269: Bitcoin ABC Buildbot (legacy)
Build 7268: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 21 2019, 09:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 21 2019, 09:16

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4603: Diff 6773.Jan 21 2019, 09:26

Fabien added a child revision: D2360: [tests] Make NodeConnCB a subclass of NodeConn.Jan 21 2019, 10:41

deadalnix accepted this revision.Jan 22 2019, 17:11

This revision is now accepted and ready to land.Jan 22 2019, 17:11

Closed by commit rABCec708a35e20c: [tests] Move only: move NodeConnCB below NodeConn (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyJan 22 2019, 17:13

This revision was automatically updated to reflect the committed changes.

Fabien mentioned this in T471: Backport Core PR11712.Jul 7 2019, 17:06

Fabien added a commit: rSTAGINGec708a35e20c: [tests] Move only: move NodeConnCB below NodeConn.Sep 18 2019, 22:00

Revision Contents
Changeset List

Path

Size

test/

functional/

test_framework/

mininode.py

328 lines

Diff 6773

View Options

test/functional/test_framework/mininode.py

[tests] Move only: move NodeConnCB below NodeConnClosedPublicActions