Page MenuHomePhabricator
Differential D2463

Migrate MakeUnique to c++14 std::make_unique
ClosedPublic
Actions

Authored by Fabien on Jan 31 2019, 16:39.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING45660ed52203: Migrate MakeUnique to c++14 std::make_unique
rABC45660ed52203: Migrate MakeUnique to c++14 std::make_unique
Summary

Remove the temporary MakeUnique definition.

Depends on D2462

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
c++14_upgrade_make_unique
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4795
Build 7653: Bitcoin ABC Buildbot (legacy)
Build 7652: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 31 2019, 16:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 31 2019, 16:39
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 31 2019, 16:40

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 31 2019, 16:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4795: Diff 7068.Jan 31 2019, 16:54
jasonbcox accepted this revision.Jan 31 2019, 19:07
This revision is now accepted and ready to land.Jan 31 2019, 19:07
Fabien updated this revision to Diff 7902.Apr 2 2019, 09:36

Rebase

teamcity added a comment.Apr 2 2019, 09:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 2 2019, 09:51

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5353: Diff 7902.Apr 2 2019, 09:51
Closed by commit rABC45660ed52203: Migrate MakeUnique to c++14 std::make_unique (authored by Fabien). · Explain WhyApr 9 2019, 18:49
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rSTAGING45660ed52203: Migrate MakeUnique to c++14 std::make_unique.Sep 18 2019, 22:56
PiRK mentioned this in D8238: p2p: Avoid allocating memory for addrKnown where we don't need it.Nov 2 2020, 16:50
PiRK mentioned this in rABC59d4627bec11: p2p: Avoid allocating memory for addrKnown where we don't need it.Nov 3 2020, 11:20

Revision Contents
Changeset List

PathSize
src/
3 lines
6 lines
2 lines
test/
4 lines
2 lines
6 lines
wallet/
7 lines
test/
2 lines
2 lines

Diff 7068

View Options

src/httprpc.cpp

Loading...
View Options

src/net.cpp

Loading...
View Options

src/radix.h

Loading...
View Options

src/test/dbwrapper_tests.cpp

Loading...
View Options

src/test/radix_tests.cpp

Loading...
View Options

src/util.h

Loading...
View Options

src/wallet/db.cpp

Loading...
View Options

src/wallet/test/wallet_test_fixture.cpp

Loading...
View Options

src/wallet/wallet.cpp

Loading...