Block ActivateBestChain to empty validationinterface queue
ClosedPublic
Actions

Authored by Fabien on Feb 26 2019, 11:14.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING7ab0c1d0d538: Block ActivateBestChain to empty validationinterface queue
rABC7ab0c1d0d538: Block ActivateBestChain to empty validationinterface queue

Summary

Partial backport of core PR11824 (commit 3613749)

Depends on D2609

Test Plan

make check
./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR11824_part6

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5090
Build 8243: Bitcoin ABC Buildbot (legacy)
Build 8242: arc lint + arc unit

Event Timeline

Fabien created this revision.Feb 26 2019, 11:14

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 26 2019, 11:14

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien added a child revision: D2611: Add helper to wait for validation interface queue to catch up.Feb 26 2019, 11:23

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5074: Diff 7484.Feb 26 2019, 11:27

Rebase

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5090: Diff 7504.Feb 27 2019, 08:49

deadalnix accepted this revision.Feb 28 2019, 14:50

This revision is now accepted and ready to land.Feb 28 2019, 14:50

Closed by commit rABC7ab0c1d0d538: Block ActivateBestChain to empty validationinterface queue (authored by Matt Corallo <git@bluematt.me>, committed by Fabien). · Explain WhyFeb 28 2019, 18:51

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rSTAGING7ab0c1d0d538: Block ActivateBestChain to empty validationinterface queue.Sep 18 2019, 22:34

Revision Contents
Changeset List

Path

Size

src/

test/

test_bitcoin.cpp

7 lines

validation.cpp

12 lines

Diff 7504

View Options

src/test/test_bitcoin.cpp