Page MenuHomePhabricator
Differential D2710

Avoid slow transaction search with txindex enabled
ClosedPublic
Actions

Authored by nakihito on Mar 19 2019, 17:41.

Details

Reviewers
jasonbcox
deadalnix
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING70575e5662a5: Avoid slow transaction search with txindex enabled
rABC70575e5662a5: Avoid slow transaction search with txindex enabled
Summary

Backport of PR11529: https://github.com/bitcoin/bitcoin/pull/11529/
Completes T565

Test Plan

make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
BackportPR11529
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5250
Build 8563: Bitcoin ABC Buildbot (legacy)
Build 8562: arc lint + arc unit

Event Timeline

nakihito created this revision.Mar 19 2019, 17:41
Owners added a reviewer: Restricted Owners Package.Mar 19 2019, 17:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 19 2019, 17:41
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Mar 19 2019, 17:42

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Mar 19 2019, 17:56

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5250: Diff 7750.Mar 19 2019, 17:56
Fabien accepted this revision.Mar 20 2019, 10:12
This revision is now accepted and ready to land.Mar 20 2019, 10:12
Closed by commit rABC70575e5662a5: Avoid slow transaction search with txindex enabled (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by nakihito). · Explain WhyMar 25 2019, 19:22
This revision was automatically updated to reflect the committed changes.
deadalnix added a comment.Mar 26 2019, 12:52

The test plan doesn't test the behavior change and there is no test. Why is that getting accepted and merged ?

Nico Guiton <nico@bitframe.org> added a commit: rSTAGING70575e5662a5: Avoid slow transaction search with txindex enabled.Sep 18 2019, 22:48

Revision Contents
Changeset List

PathSize
src/
3 lines

Diff 7750

View Options

src/validation.cpp

Loading...