Page MenuHomePhabricator
Differential D2717

Allow for running secp256k1 java build/tests out of tree
ClosedPublic
Actions

Authored by Fabien on Mar 20 2019, 21:32.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING232eb7ae769d: Allow for running secp256k1 java build/tests out of tree
rABC232eb7ae769d: Allow for running secp256k1 java build/tests out of tree
Summary

As per title

Test Plan
mkdir -p src/secp256k1/build
cd src/secp256k1
mkdir -p src/java/guava
wget https://search.maven.org/remotecontent?filepath=com/google/guava/guava/18.0/guava-18.0.jar -O src/java/guava/guava-18.0.jar
./autogen.sh
cd build
../configure --enable-jni --enable-experimental --enable-module-ecdh
make check-java

(make check-java may pass or fail depending of D2685)
Use make clean to remove the .class files generated by javac.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
secp256k1_build_out_of_tree
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5258
Build 8579: Bitcoin ABC Buildbot (legacy)
Build 8578: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 20 2019, 21:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 20 2019, 21:33
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Mar 20 2019, 21:33

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien edited the test plan for this revision. (Show Details)Mar 20 2019, 21:33
jasonbcox accepted this revision.Mar 20 2019, 21:37
This revision is now accepted and ready to land.Mar 20 2019, 21:37
Harbormaster completed remote builds in B5258: Diff 7763.Mar 20 2019, 21:48
teamcity added a comment.Mar 20 2019, 21:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox added a child revision: D2686: Added build-secp256k1.sh for running secp tests in TeamCity.Mar 20 2019, 22:11
jasonbcox mentioned this in D2699: Merge #10742: scripted-diff: Use scoped enumerations (C++11, "enum class").Mar 20 2019, 22:45
Closed by commit rABC232eb7ae769d: Allow for running secp256k1 java build/tests out of tree (authored by Fabien). · Explain WhyMar 21 2019, 22:51
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rSTAGING232eb7ae769d: Allow for running secp256k1 java build/tests out of tree.Sep 18 2019, 22:46

Revision Contents
Changeset List

PathSize
src/
secp256k1/
4 lines

Diff 7763

View Options

src/secp256k1/Makefile.am

Loading...