Differential D2722

Merge #8665: Assert all the things!
ClosedPublic
Actions

Authored by jasonbcox on Mar 21 2019, 18:10.

Tags

None

Subscribers

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING379dd8366d10: Merge #8665: Assert all the things!
rABC379dd8366d10: Merge #8665: Assert all the things!

Summary

4d51e9b Assert ConnectBlock block and pIndex are the same block (NicolasDorier)
972714c pow: GetNextWorkRequired never called with NULL pindexLast (Daniel Cousens)
cc44c8f ContextualCheckBlockHeader should never have pindexPrev to NULL (NicolasDorier)

Tree-SHA512: 7cc568bf9417267c335f21ec3d1505b26e56e5b3d5f4d3dbb555279489800aaa65a3bcd7bc376e274dd102912aec16ddbb18de2e2060b2667b41eb979cd9321e

Backport of Core PR 8665
https://github.com/bitcoin/bitcoin/pull/8665/files

Test Plan

make check
test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr8665

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5266
Build 8595: Bitcoin ABC Buildbot (legacy)
Build 8594: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Mar 21 2019, 18:10

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 21 2019, 18:10

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5266: Diff 7777.Mar 21 2019, 18:26

jasonbcox added a child revision: D2723: Merge #11028: Avoid masking of difficulty adjustment errors by checkpoints.Mar 21 2019, 18:44

Fabien accepted this revision.Mar 21 2019, 23:02

This revision is now accepted and ready to land.Mar 21 2019, 23:02

Closed by commit rABC379dd8366d10: Merge #8665: Assert all the things! (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by jasonbcox). · Explain WhyMar 22 2019, 19:43

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rSTAGING379dd8366d10: Merge #8665: Assert all the things!.Sep 18 2019, 22:47

Revision Contents
Changeset List

Path

Size

src/

6 lines

9 lines

Diff 7777

src/pow.cpp

Loading...

src/validation.cpp

Loading...