Page MenuHomePhabricator

Fix comment about s in schnorr sigs
ClosedPublic

Authored by florian on Tue, Mar 26, 20:32.

Details

Reviewers
markblundeberg
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABCc80bf903f979: Fix comment about s in schnorr sigs
Summary

s/order/n/ for consistency.

Test Plan

None

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

florian created this revision.Tue, Mar 26, 20:32
Owners added a reviewer: Restricted Owners Package.Tue, Mar 26, 20:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Mar 26, 20:32
Herald added a subscriber: schancel. · View Herald Transcript
deadalnix requested changes to this revision.Wed, Mar 27, 02:00
deadalnix added inline comments.
src/secp256k1/src/modules/schnorr/schnorr_impl.h
31 ↗(On Diff #7837)

It's always mod n, so this is redundant. mod n is required on the previous line because the hash is not a scalar fields element.

This revision now requires changes to proceed.Wed, Mar 27, 02:00
florian updated this revision to Diff 7855.Thu, Mar 28, 00:31

Revert the mod n change.

Fabien accepted this revision as: Fabien.Thu, Mar 28, 10:58
jasonbcox accepted this revision.Fri, Mar 29, 17:11
deadalnix accepted this revision.Sun, Mar 31, 16:55
This revision is now accepted and ready to land.Sun, Mar 31, 16:55
florian edited the summary of this revision. (Show Details)Tue, Apr 2, 01:18
This revision was automatically updated to reflect the committed changes.