Page MenuHomePhabricator
Differential D2741

Fix comment about s in schnorr sigs
ClosedPublic
Actions

Authored by florian on Mar 26 2019, 20:32.

Details

Reviewers
markblundeberg
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGc80bf903f979: Fix comment about s in schnorr sigs
rABCc80bf903f979: Fix comment about s in schnorr sigs
Summary

s/order/n/ for consistency.

Test Plan

None

Diff Detail

Repository
rABC Bitcoin ABC
Branch
schnorrcomment
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5322
Build 8706: Bitcoin ABC Buildbot (legacy)
Build 8705: arc lint + arc unit

Event Timeline

florian created this revision.Mar 26 2019, 20:32
Owners added a reviewer: Restricted Owners Package.Mar 26 2019, 20:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 26 2019, 20:32
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a comment.Mar 26 2019, 20:33

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Mar 26 2019, 20:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5307: Diff 7837.Mar 26 2019, 20:48
deadalnix requested changes to this revision.Mar 27 2019, 02:00
deadalnix added inline comments.
src/secp256k1/src/modules/schnorr/schnorr_impl.h
31 ↗(On Diff #7837)

It's always mod n, so this is redundant. mod n is required on the previous line because the hash is not a scalar fields element.

This revision now requires changes to proceed.Mar 27 2019, 02:00
florian updated this revision to Diff 7855.Mar 28 2019, 00:31

Revert the mod n change.

teamcity added a comment.Mar 28 2019, 00:31

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Mar 28 2019, 00:46

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5322: Diff 7855.Mar 28 2019, 00:46
Fabien accepted this revision as: Fabien.Mar 28 2019, 10:58
jasonbcox accepted this revision.Mar 29 2019, 17:11
deadalnix accepted this revision.Mar 31 2019, 16:55
This revision is now accepted and ready to land.Mar 31 2019, 16:55
florian edited the summary of this revision. (Show Details)Apr 2 2019, 01:18
Closed by commit rABCc80bf903f979: Fix comment about s in schnorr sigs (authored by florian). · Explain WhyApr 2 2019, 01:18
This revision was automatically updated to reflect the committed changes.
florian added a commit: rSTAGINGc80bf903f979: Fix comment about s in schnorr sigs.Sep 19 2019, 14:54

Revision Contents
Changeset List

PathSize
src/
secp256k1/
src/
modules/
schnorr/
2 lines

Diff 7855

View Options

src/secp256k1/src/modules/schnorr/schnorr_impl.h

Loading...