Page MenuHomePhabricator
Differential D2766

Add Sent and Received information to the debug menu peer list
ClosedPublic
Actions

Authored by nakihito on Apr 2 2019, 21:55.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGc29c9a8522b4: Add Sent and Received information to the debug menu peer list
rABCc29c9a8522b4: Add Sent and Received information to the debug menu peer list
Summary

Add Sent and Received information to the debug menu peer list

Backport of Core PR11499
https://github.com/bitcoin/bitcoin/pull/11499

Completes T554

Test Plan

bitcoin-qt
Help -> Debug Window -> Peers should display Sent and Received information

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Apr 2 2019, 21:55
Owners added a reviewer: Restricted Owners Package.Apr 2 2019, 21:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 2 2019, 21:55
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a comment.Apr 2 2019, 21:56

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

nakihito planned changes to this revision.Apr 2 2019, 21:56
teamcity added a comment.Apr 2 2019, 22:10

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5367: Diff 7923.Apr 2 2019, 22:10
nakihito updated this revision to Diff 7925.Apr 2 2019, 22:15

Squashed together two commits.

teamcity added a comment.Apr 2 2019, 22:15

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

nakihito planned changes to this revision.Apr 2 2019, 22:15
teamcity added a comment.Apr 2 2019, 22:29

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5368: Diff 7925.Apr 2 2019, 22:29
nakihito requested review of this revision.Apr 9 2019, 19:33
nakihito edited the test plan for this revision. (Show Details)
nakihito edited the test plan for this revision. (Show Details)
jasonbcox requested changes to this revision.Apr 10 2019, 20:24
jasonbcox added inline comments.
src/qt/guiutil.cpp
1008 ↗(On Diff #7925)

All three if-statements needs brackets to match our new codestyle. Many backports do not contain them, but we add them for readability and reduced bug introduction risk.

This revision now requires changes to proceed.Apr 10 2019, 20:24
nakihito updated this revision to Diff 8060.Apr 15 2019, 16:31

Added braces {} to if statements. Linter did not catch these for some reason?

teamcity added a comment.Apr 15 2019, 16:31

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

nakihito marked an inline comment as done.Apr 15 2019, 16:43
teamcity added a comment.Apr 15 2019, 16:46

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5458: Diff 8060.Apr 15 2019, 16:46
Fabien requested changes to this revision.Apr 16 2019, 07:54
Fabien added inline comments.
src/qt/rpcconsole.cpp
1290 ↗(On Diff #8060)

Restore

This revision now requires changes to proceed.Apr 16 2019, 07:54
nakihito updated this revision to Diff 8074.Apr 16 2019, 17:11

Restored newline.

teamcity added a comment.Apr 16 2019, 17:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 16 2019, 17:27

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5467: Diff 8074.Apr 16 2019, 17:27
Fabien accepted this revision.Apr 16 2019, 19:51
deadalnix accepted this revision.Apr 17 2019, 12:11
deadalnix added inline comments.
src/qt/peertablemodel.h
60 ↗(On Diff #8074)

trailing coma

jasonbcox accepted this revision.Apr 18 2019, 15:08
This revision is now accepted and ready to land.Apr 18 2019, 15:08
nakihito marked an inline comment as done.Apr 19 2019, 17:57
nakihito updated this revision to Diff 8153.Apr 19 2019, 18:11

Added trailing comma to ColumnIndex enum.

teamcity added a comment.Apr 19 2019, 18:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 19 2019, 18:25

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5527: Diff 8153.Apr 19 2019, 18:25
Closed by commit rABCc29c9a8522b4: Add Sent and Received information to the debug menu peer list (authored by Aaron Golliver <aaron.golliver@gmail.com>, committed by nakihito). · Explain WhyApr 19 2019, 18:26
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rSTAGINGc29c9a8522b4: Add Sent and Received information to the debug menu peer list.Sep 18 2019, 23:02

Revision Contents
Changeset List

PathSize
src/
qt/
2 lines
14 lines
9 lines
22 lines
1 line
24 lines

Diff 8154

View Options

src/qt/guiutil.h

Loading...
View Options

src/qt/guiutil.cpp

Loading...
View Options

src/qt/peertablemodel.h

Loading...
View Options

src/qt/peertablemodel.cpp

Loading...
View Options

src/qt/rpcconsole.h

Loading...
View Options

src/qt/rpcconsole.cpp

Loading...