build: Move interfaces/* to libbitcoin_server
ClosedPublic
Actions

Authored by jasonbcox on Apr 19 2019, 19:58.

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING176342ca4a94: build: Move interfaces/* to libbitcoin_server
rABC176342ca4a94: build: Move interfaces/* to libbitcoin_server

Summary

Backport of Core PR 14204
https://github.com/bitcoin/bitcoin/pull/14204/files
Fixes cmake build issue where interfaces/wallet.cpp wasn't linking correctly in D2817

Test Plan

Build D2817 with this diff applied instead of the linking attempts included in that diff.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr14204

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5529
Build 9120: Bitcoin ABC Buildbot (legacy)
Build 9119: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Apr 19 2019, 19:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 19 2019, 19:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien accepted this revision.Apr 19 2019, 20:08

This revision is now accepted and ready to land.Apr 19 2019, 20:08

Harbormaster completed remote builds in B5529: Diff 8163.Apr 19 2019, 20:13

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Closed by commit rABC176342ca4a94: build: Move interfaces/* to libbitcoin_server (authored by jasonbcox). · Explain WhyApr 19 2019, 21:33

This revision was automatically updated to reflect the committed changes.

jasonbcox mentioned this in D2817: Remove direct bitcoin calls from qt/splashscreen.cpp.Apr 19 2019, 21:34

jasonbcox added a child revision: D2817: Remove direct bitcoin calls from qt/splashscreen.cpp.Apr 19 2019, 21:34

jasonbcox added a commit: rSTAGING176342ca4a94: build: Move interfaces/* to libbitcoin_server.Sep 18 2019, 23:04

Revision Contents
Changeset List

Path

Size

src/

CMakeLists.txt

4 lines

Makefile.am

4 lines

Diff 8163

View Options

src/CMakeLists.txt