Page MenuHomePhabricator
Differential D2927

scripted-diff: Rename SetBestChain callback ChainStateFlushed
ClosedPublic
Actions

Authored by markblundeberg on May 5 2019, 04:10.

Details

Reviewers
deadalnix
jasonbcox
Fabien
Mengerian
Group Reviewers
Restricted Project
Maniphest Tasks
T632: Backport PR 13106 "Simplify semantics of ChainStateFlushed callback"
Commits
rSTAGING34964a601d4b: scripted-diff: Rename SetBestChain callback ChainStateFlushed
rABC34964a601d4b: scripted-diff: Rename SetBestChain callback ChainStateFlushed
Summary

backport of first commit (50b6533) from PR13106

Note from Mark -- Matt missed renaming in a couple of comments--fixed => backport of core PR13154.

Depends on D2904

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13106a
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5678
Build 9418: Bitcoin ABC Buildbot (legacy)
Build 9417: arc lint + arc unit

Event Timeline

markblundeberg created this revision.May 5 2019, 04:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 5 2019, 04:10
Herald added a reviewer: deadalnix. · View Herald Transcript
markblundeberg added a task: T632: Backport PR 13106 "Simplify semantics of ChainStateFlushed callback".May 5 2019, 04:11
teamcity added a comment.May 5 2019, 04:11

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg added a child revision: D2928: Simplify semantics of ChainStateFlushed callback.May 5 2019, 04:14
teamcity added a comment.May 5 2019, 04:25

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5678: Diff 8393.May 5 2019, 04:25
markblundeberg edited the summary of this revision. (Show Details)May 5 2019, 17:10
markblundeberg added reviewers: jasonbcox, Fabien.May 7 2019, 15:40
markblundeberg added a reviewer: Mengerian.
Fabien added a comment.May 8 2019, 09:53

Note: missed comments are updated in PR13154, I add the reference to the summary

Fabien edited the summary of this revision. (Show Details)May 8 2019, 09:54
Fabien accepted this revision.May 8 2019, 09:57
This revision is now accepted and ready to land.May 8 2019, 09:57
Closed by commit rABC34964a601d4b: scripted-diff: Rename SetBestChain callback ChainStateFlushed (authored by Matt Corallo <git@bluematt.me>, committed by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyMay 20 2019, 23:17
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING34964a601d4b: scripted-diff: Rename SetBestChain callback ChainStateFlushed.Sep 18 2019, 23:38

Revision Contents
Changeset List

PathSize
src/
2 lines
index/
2 lines
4 lines
4 lines
2 lines
4 lines
16 lines
wallet/
2 lines
6 lines

Diff 8393

View Options

src/chainparams.cpp

Loading...
View Options

src/index/txindex.h

Loading...
View Options

src/index/txindex.cpp

Loading...
View Options

src/init.cpp

Loading...
View Options

src/validation.cpp

Loading...
View Options

src/validationinterface.h

Loading...
View Options

src/validationinterface.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...