Page MenuHomePhabricator
Differential D2935

index: Extract logic from TxIndex into reusable base class.
ClosedPublic
Actions

Authored by markblundeberg on May 5 2019, 20:22.

Details

Reviewers
deadalnix
jasonbcox
Fabien
Group Reviewers
Restricted Project
Maniphest Tasks
T630: Backport PR 13243 "Make reusable base class for auxiliary indices"
Commits
rSTAGING3b2079b88dfb: index: Extract logic from TxIndex into reusable base class.
rABC3b2079b88dfb: index: Extract logic from TxIndex into reusable base class.
Summary

backported third commit (61a1226d8) from PR13243
https://github.com/bitcoin/bitcoin/commit/61a1226d8

Depends on D2924

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
baseidxC
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5687
Build 9436: Bitcoin ABC Buildbot (legacy)
Build 9435: arc lint + arc unit

Event Timeline

markblundeberg created this revision.May 5 2019, 20:22
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 5 2019, 20:22
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.May 5 2019, 20:23

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg added a task: T630: Backport PR 13243 "Make reusable base class for auxiliary indices".May 5 2019, 20:27
markblundeberg added a child revision: D2936: index: Generalize logged statements in BaseIndex..May 5 2019, 20:29
teamcity added a comment.May 5 2019, 20:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5687: Diff 8402.May 5 2019, 20:37
markblundeberg added reviewers: jasonbcox, Fabien.May 23 2019, 00:58
markblundeberg planned changes to this revision.May 23 2019, 23:08
markblundeberg updated this revision to Diff 8892.May 27 2019, 00:39

rebase

teamcity added a comment.May 27 2019, 00:39

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5995: Diff 8892.May 27 2019, 00:54
teamcity added a comment.May 27 2019, 00:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

markblundeberg edited the summary of this revision. (Show Details)May 27 2019, 01:29
markblundeberg planned changes to this revision.May 27 2019, 01:34
markblundeberg requested review of this revision.May 27 2019, 01:40
markblundeberg added inline comments.
src/index/txindex.h
104 ↗(On Diff #8892)

got confused by the diff-detection here being so different from github; actual diff is the same

deadalnix accepted this revision.May 27 2019, 21:01
This revision is now accepted and ready to land.May 27 2019, 21:01
Closed by commit rABC3b2079b88dfb: index: Extract logic from TxIndex into reusable base class. (authored by jimpo, committed by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyMay 28 2019, 16:01
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABC3b2079b88dfb: index: Extract logic from TxIndex into reusable base class..
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING3b2079b88dfb: index: Extract logic from TxIndex into reusable base class..Sep 18 2019, 23:52

Revision Contents
Changeset List

PathSize
src/
index/
95 lines
38 lines

Diff 8402

View Options

src/index/txindex.h

Loading...
View Options

src/index/txindex.cpp

Loading...