Page MenuHomePhabricator
Differential D2936

index: Generalize logged statements in BaseIndex.
ClosedPublic
Actions

Authored by markblundeberg on May 5 2019, 20:29.

Details

Reviewers
deadalnix
jasonbcox
Fabien
Group Reviewers
Restricted Project
Maniphest Tasks
T630: Backport PR 13243 "Make reusable base class for auxiliary indices"
Commits
rSTAGINGfa0dbf7e7f10: index: Generalize logged statements in BaseIndex.
rABCfa0dbf7e7f10: index: Generalize logged statements in BaseIndex.
Summary

backported fourth commit (f376a4924) from PR13243
https://github.com/bitcoin/bitcoin/commit/f376a4924

Depends on D2935

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
baseidxD
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5688
Build 9438: Bitcoin ABC Buildbot (legacy)
Build 9437: arc lint + arc unit

Event Timeline

markblundeberg created this revision.May 5 2019, 20:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 5 2019, 20:29
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.May 5 2019, 20:29

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg added a task: T630: Backport PR 13243 "Make reusable base class for auxiliary indices".May 5 2019, 20:29
markblundeberg added a child revision: D2937: MOVEONLY: Move BaseIndex to its own file..May 5 2019, 20:38
Harbormaster completed remote builds in B5688: Diff 8403.May 5 2019, 20:43
teamcity added a comment.May 5 2019, 20:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

markblundeberg added reviewers: jasonbcox, Fabien.May 23 2019, 00:57
markblundeberg planned changes to this revision.May 23 2019, 23:08
markblundeberg updated this revision to Diff 8893.May 27 2019, 00:39

rebase

teamcity added a comment.May 27 2019, 00:40

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 27 2019, 00:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5996: Diff 8893.May 27 2019, 00:54
markblundeberg edited the summary of this revision. (Show Details)May 27 2019, 01:47
deadalnix accepted this revision.May 27 2019, 21:02
This revision is now accepted and ready to land.May 27 2019, 21:02
Closed by commit rABCfa0dbf7e7f10: index: Generalize logged statements in BaseIndex. (authored by jimpo, committed by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyMay 28 2019, 16:01
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABCfa0dbf7e7f10: index: Generalize logged statements in BaseIndex..
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGINGfa0dbf7e7f10: index: Generalize logged statements in BaseIndex..Sep 18 2019, 23:52

Revision Contents
Changeset List

PathSize
src/
index/
5 lines
23 lines

Diff 8403

View Options

src/index/txindex.h

Loading...
View Options

src/index/txindex.cpp

Loading...