Page MenuHomePhabricator
Differential D2937

MOVEONLY: Move BaseIndex to its own file.
ClosedPublic
Actions

Authored by markblundeberg on May 5 2019, 20:38.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Project
Maniphest Tasks
T630: Backport PR 13243 "Make reusable base class for auxiliary indices"
Commits
rSTAGING99cbd491e734: MOVEONLY: Move BaseIndex to its own file.
rABC99cbd491e734: MOVEONLY: Move BaseIndex to its own file.
Summary

backported fifth commit (2318affd2) from PR13243
https://github.com/bitcoin/bitcoin/commit/2318affd2

Depends on D2936

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
baseidxE
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5689
Build 9440: Bitcoin ABC Buildbot (legacy)
Build 9439: arc lint + arc unit

Event Timeline

markblundeberg created this revision.May 5 2019, 20:38
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 5 2019, 20:38
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.May 5 2019, 20:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg added a task: T630: Backport PR 13243 "Make reusable base class for auxiliary indices".May 5 2019, 20:38
teamcity added a comment.May 5 2019, 20:52

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5689: Diff 8404.May 5 2019, 20:52
markblundeberg added a child revision: D2938: index: Move index DBs into index/ directory..May 5 2019, 23:45
markblundeberg added reviewers: Fabien, jasonbcox.May 23 2019, 00:57
markblundeberg planned changes to this revision.May 23 2019, 23:08
markblundeberg updated this revision to Diff 8894.May 27 2019, 00:39

rebase

teamcity added a comment.May 27 2019, 00:40

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 27 2019, 00:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5997: Diff 8894.May 27 2019, 00:54
markblundeberg edited the summary of this revision. (Show Details)May 27 2019, 02:11
deadalnix accepted this revision.May 27 2019, 21:03
This revision is now accepted and ready to land.May 27 2019, 21:03
Closed by commit rABC99cbd491e734: MOVEONLY: Move BaseIndex to its own file. (authored by jimpo, committed by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyMay 28 2019, 16:02
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABC99cbd491e734: MOVEONLY: Move BaseIndex to its own file..
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING99cbd491e734: MOVEONLY: Move BaseIndex to its own file..Sep 18 2019, 23:52

Revision Contents
Changeset List

PathSize
src/
1 line
2 lines
index/
base.h
txindex.h
43 lines
base.cpp
txindex.cpp
61 lines
79 lines
248 lines
test/
lint/
2 lines

Diff 8404

View Options

src/CMakeLists.txt

Loading...
View Options

src/Makefile.am

Loading...
View Options

src/index/base.h

Loading...
View Options

src/index/base.cpp

Loading...
View Options

src/index/txindex.h

Loading...
View Options

src/index/txindex.cpp

Loading...
View Options

test/lint/lint-format-strings.py

Loading...