Page MenuHomePhabricator

[CMAKE] Fix the prl conversion script library path issue
ClosedPublic

Authored by Fabien on May 6 2019, 23:40.

Details

Summary

The prl conversion script contrib/qt/convert-rpl-libs-to-cmake.pl
determines the library installation directory as being the given library
directory.
While this is true in most cases, it fails with plugins libraries which
are located in their own subtree.
This diff adds a new argument to the perl script so the caller can set
the library directory.

Also adds some quotes surrounding the paths to avoid dealing with issues
with spaces.

Depends on D2947.

Test Plan
cmake -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Win64.cmake -GNinja \
-DBUILD_BITCOIN_SEEDER=OFF ..
ninja

Check the build is successful

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_fix_prl_convert
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 5706
Build 9474: Bitcoin ABC Buildbot (legacy)
Build 9473: arc lint + arc unit