Page MenuHomePhabricator

New -includeconf argument for including external configuration files
ClosedPublic

Authored by Fabien on May 13 2019, 14:01.

Details

Summary
  • adds -includeconf=<path>, where <path> is relative to datadir or to

the path of the file being read, if in a file

  • protects against circular includes
  • updates help docs

Backport of core PR10267
https://github.com/bitcoin/bitcoin/pull/10267/files

Includes a fix from PR13126
https://github.com/bitcoin/bitcoin/pull/10267#issuecomment-388580967

Completes T541
Progresses towards T652

Test Plan
make check
./test/functional/test_runner.py feature_includeconf

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR10267
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5867
Build 9794: Bitcoin ABC Buildbot (legacy)
Build 9793: arc lint + arc unit

Event Timeline

Herald added a reviewer: deadalnix. ยท View Herald Transcript

You were first to submit, you get the priority

Ah I see the extra clause is the fix you mention.

doc/release-notes.md
7 โ†—(On Diff #8631)

I like your release notes more than mine :)

src/init.cpp
391 โ†—(On Diff #8631)

should alphabetically sort after -finalizationdelay

src/util.cpp
818 โ†—(On Diff #8631)

hmm mine lacks this clause

test/functional/timing.json
108 โ†—(On Diff #8631)

Interesting, didn't know about this file!

Update help ordering and add missing newline in release notes.

This revision is now accepted and ready to land.May 13 2019, 14:58
This revision was automatically updated to reflect the committed changes.