As per title.
Details
Details
- Reviewers
freetrader sickpig kyuupichan awemany - Group Reviewers
Restricted Project - Commits
- rSTAGING4faef14fa5a4: Sign using replay protection by default in raw transaction RPC
rABC4faef14fa5a4: Sign using replay protection by default in raw transaction RPC
Fixed all integration tests to reflect the change.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- rawtxsign
- Lint
Lint Passed Severity Location Code Message Auto-Fix src/script/sign.cpp:1 CFMT Code style violation - Unit
No Test Coverage - Build Status
Buildable 477 Build 477: arc lint + arc unit
Event Timeline
| qa/rpc-tests/bip9-softforks.py | ||
|---|---|---|
| 30 ↗ | (On Diff #771) | Two blank lines before class definition is actually good Python style. Removing them will just make Python linters complain more. |
| src/rpc/rawtransaction.cpp | ||
| 976 ↗ | (On Diff #771) | Imo it would be more user-friendly to not produce protected transactions by default prior to the fork. i.e. set SIGHASH_FORKID automatically after the fork has activated, not before. |
| src/rpc/rawtransaction.cpp | ||
|---|---|---|
| 976 ↗ | (On Diff #771) | Doesn't matter really. It'll avoid people making mistakes and there is no point making it complex for something that'll be useful 2 week. If you are savy enough to use the RPC, you are savy enough to do what's right. |