Page MenuHomePhabricator

Sign using replay protection by default in raw transaction RPC
ClosedPublic

Authored by deadalnix on Jul 10 2017, 12:14.

Details

Summary

As per title.

Test Plan

Fixed all integration tests to reflect the change.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
rawtxsign
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 478
Build 478: arc lint + arc unit

Event Timeline

qa/rpc-tests/bip9-softforks.py
30 ↗(On Diff #771)

Two blank lines before class definition is actually good Python style.

Removing them will just make Python linters complain more.

src/rpc/rawtransaction.cpp
976 ↗(On Diff #771)

Imo it would be more user-friendly to not produce protected transactions by default prior to the fork.

i.e. set SIGHASH_FORKID automatically after the fork has activated, not before.

src/rpc/rawtransaction.cpp
976 ↗(On Diff #771)

Doesn't matter really. It'll avoid people making mistakes and there is no point making it complex for something that'll be useful 2 week. If you are savy enough to use the RPC, you are savy enough to do what's right.

This revision is now accepted and ready to land.Jul 14 2017, 14:59
This revision was automatically updated to reflect the committed changes.