Page MenuHomePhabricator
Differential D3285

Merge #10587: Net: Fix resource leak in ReadBinaryFile(...)
ClosedPublic
Actions

Authored by nakihito on Jun 10 2019, 22:49.

Details

Reviewers
jasonbcox
deadalnix
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING2f1adeefb67e: Merge #10587: Net: Fix resource leak in ReadBinaryFile(...)
rABC2f1adeefb67e: Merge #10587: Net: Fix resource leak in ReadBinaryFile(...)
Summary

f2fb132cb Net: Fix resource leak in ReadBinaryFile(...) (practicalswift)

Tree-SHA512: 879b9334d8bb681fa4b6f96d8ecb54e2a8948065f7be5fe7880131479c813602fc9d4a4314f043e6591e1aed50ffafa7c247362a9cdeb049b0721170e227b89a

Backport of Core PR10587
https://github.com/bitcoin/bitcoin/pull/10587

Dependent on D3283

Completes T613

This should land immediately after its dependency.

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR10587
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6259
Build 10565: Bitcoin ABC Buildbot (legacy)
Build 10564: arc lint + arc unit

Event Timeline

nakihito created this revision.Jun 10 2019, 22:49
Owners added a reviewer: Restricted Owners Package.Jun 10 2019, 22:49
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 10 2019, 22:49
teamcity added a comment.Jun 10 2019, 22:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

nakihito mentioned this in D3283: Merge #10408, #13291, and partial #13163.Jun 10 2019, 22:49
teamcity added a comment.Jun 10 2019, 22:55

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6259: Diff 9306.Jun 10 2019, 22:55
jasonbcox accepted this revision.Jun 10 2019, 23:03
This revision is now accepted and ready to land.Jun 10 2019, 23:03
Fabien added a comment.Jun 11 2019, 06:25

Needs rebase

nakihito updated this revision to Diff 9328.Jun 11 2019, 22:27

Rebased.

teamcity added a comment.Jun 11 2019, 22:27

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

nakihito added a child revision: D3293: Merge #13163: Make it clear which functions that are intended to be translation unit local.Jun 11 2019, 22:29
teamcity added a comment.Jun 11 2019, 22:35

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6271: Diff 9328.Jun 11 2019, 22:35
Nico Guiton <nico@bitframe.org> mentioned this in rABCbe756d0c7f94: Merge #10408, #13291, and partial #13163.Jun 27 2019, 23:26
Closed by commit rABC2f1adeefb67e: Merge #10587: Net: Fix resource leak in ReadBinaryFile(...) (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyJun 27 2019, 23:40
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABC2f1adeefb67e: Merge #10587: Net: Fix resource leak in ReadBinaryFile(...).
Nico Guiton <nico@bitframe.org> added a commit: rSTAGING2f1adeefb67e: Merge #10587: Net: Fix resource leak in ReadBinaryFile(...).Sep 19 2019, 00:40
Nico Guiton <nico@bitframe.org> mentioned this in rSTAGINGbe756d0c7f94: Merge #10408, #13291, and partial #13163.

Revision Contents
Changeset List

PathSize
src/
5 lines

Diff 9306

View Options

src/torcontrol.cpp

Loading...