Page MenuHomePhabricator

[refactor multisig] remove redundant counters
ClosedPublic

Authored by markblundeberg on Jul 15 2019, 01:10.

Details

Reviewers
deadalnix
Mengerian
Group Reviewers
Restricted Project
Commits
rABC637c25c0bc00: [refactor multisig] remove redundant counters
Summary

This is perhaps debatable but the ikey, isig indices are always intended
to iterate in step with the number of remaining objects, and the numbers
remaining are the important values needed to know when to stop iteration.
The ikey, isig thus only serve to avoid some (fast) arithmetic.

Depends on D3625

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
rms3
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 6859
Build 11765: Bitcoin ABC Teamcity Staging
Build 11764: arc lint + arc unit