Page MenuHomePhabricator
Differential D3675

[refactor multisig] remove redundant counters
ClosedPublic
Actions

Authored by markblundeberg on Jul 15 2019, 01:10.

Details

Reviewers
deadalnix
Mengerian
Group Reviewers
Restricted Project
Commits
rSTAGING637c25c0bc00: [refactor multisig] remove redundant counters
rABC637c25c0bc00: [refactor multisig] remove redundant counters
Summary

This is perhaps debatable but the ikey, isig indices are always intended
to iterate in step with the number of remaining objects, and the numbers
remaining are the important values needed to know when to stop iteration.
The ikey, isig thus only serve to avoid some (fast) arithmetic.

Depends on D3625

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
rms3
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6859
Build 11765: Bitcoin ABC Buildbot (legacy)
Build 11764: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Jul 15 2019, 01:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 15 2019, 01:10
teamcity added a comment.Jul 15 2019, 01:10

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 15 2019, 01:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6859: Diff 10293.Jul 15 2019, 01:16
deadalnix accepted this revision.Jul 15 2019, 16:20
This revision is now accepted and ready to land.Jul 15 2019, 16:20
Mengerian accepted this revision.Jul 15 2019, 16:42
Mengerian added a subscriber: Mengerian.

This makes the code more readable for me, so it seems like a good change.

Closed by commit rABC637c25c0bc00: [refactor multisig] remove redundant counters (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyJul 16 2019, 20:22
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABC637c25c0bc00: [refactor multisig] remove redundant counters.
markblundeberg mentioned this in D3474: Implement new checkmultisig trigger logic and execution logic..Jul 20 2019, 00:14
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING637c25c0bc00: [refactor multisig] remove redundant counters.Sep 19 2019, 01:18

Revision Contents
Changeset List

PathSize
src/
script/
10 lines

Diff 10293

View Options

src/script/interpreter.cpp

Loading...