Page MenuHomePhabricator

Abstract out BlockAssembler options
ClosedPublic

Authored by deadalnix on Sep 13 2019, 16:35.

Details

Summary

This is a partial backport of Core PR9868

It was modified as to extract the required infos from the config and only use the option object going forward, which avoid having two source of truth.

Test Plan
make check
./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Sep 13 2019, 16:35
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 13 2019, 16:35
jasonbcox requested changes to this revision.Sep 13 2019, 20:39
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/miner.h
169 ↗(On Diff #11289)

nExcesiveBlockSize -> nExcessiveBlockSize

This revision now requires changes to proceed.Sep 13 2019, 20:39
deadalnix updated this revision to Diff 11308.Sep 14 2019, 09:16

nExcesiveBlockSize -> nExcessiveBlockSize

Fabien added a subscriber: Fabien.Sep 16 2019, 08:55
Fabien added inline comments.
src/miner.cpp
64 ↗(On Diff #11308)

I don't understand how this can build:
blockMinFeeRate is a CFeeRate which has an explicit constructor. Passing an Amount should then raise a compiler error ?

92 ↗(On Diff #11308)

Is the IsArgSet() call useful ? The default value for Options.nMaxGeneratedBlockSize is DEFAULT_MAX_GENERATED_BLOCK_SIZE so if -blockmaxsize is not set the value is always DEFAULT_MAX_GENERATED_BLOCK_SIZE.

deadalnix updated this revision to Diff 13056.Sat, Sep 21, 12:41

Rebase and ping

deadalnix updated this revision to Diff 13082.Mon, Sep 23, 11:41

Ping. This has not recieved any substancial review for 10 days now.

jasonbcox accepted this revision.Mon, Sep 23, 16:20
This revision is now accepted and ready to land.Mon, Sep 23, 16:20
This revision was automatically updated to reflect the committed changes.